Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: v8/v8
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9.0.257.13
Choose a base ref
...
head repository: v8/v8
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 9.0.257.16
Choose a head ref
  • 6 commits
  • 6 files changed
  • 4 contributors

Commits on Mar 29, 2021

  1. Merged: [debugger] Fix infinite loop in FindSharedFunctionInfoInScript

    This CL fixes a bug in which we did not correctly handle the
    case if CompileTopLevel would not return any result. Check the
    result of CompileTopLevel, correctly handle pending
    exceptions and break out of the loop if top-level compile
    did not succeed.
    
    Bug: v8:11598
    No-Try: true
    No-Presubmit: true
    No-Tree-Checks: true
    Change-Id: I3408d171c462474cbe8829218c6011f31804fd01
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2790173
    Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
    Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/branch-heads/9.0@{#26}
    Cr-Branched-From: bd0108b-refs/heads/9.0.257@{#1}
    Cr-Branched-From: 349bcc6-refs/heads/master@{#73001}
    ktran authored and Commit Bot committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    a0c9540 View commit details
    Browse the repository at this point in the history
  2. Version 9.0.257.14

    TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com
    
    Change-Id: I5df421d8c9291e27f230d8b7720ce0caf76c9c5f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2790517
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/branch-heads/9.0@{#27}
    Cr-Branched-From: bd0108b-refs/heads/9.0.257@{#1}
    Cr-Branched-From: 349bcc6-refs/heads/master@{#73001}
    V8 Autoroll committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    30ee58f View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2021

  1. Merged: Clamp properly in the String.p.indexOf reduction

    This fixes a bug introduced in crrev.com/c/2660995.
    String.prototype.indexOf must clamp the `position` argument as per
    step:
    
      7. Let start be the result of clamping pos between 0 and len.
    
    Source: tc39.es/ecma262/#sec-string.prototype.indexof
    
    Previously, this was done in the StringIndexOf builtin, but the recent
    refactor changed builtin implementations to match the spec more
    closely (i.e. to clamp in String.prototype.indexOf, not
    StringIndexOf). This means we now have to clamp in
    JSCallReducer::ReduceStringPrototypeIndexOf.
    
    (cherry picked from commit 232bf1f)
    
    No-Try: true
    No-Presubmit: true
    No-Treechecks: true
    Tbr: neis@chromium.org
    Bug: chromium:1194869
    Change-Id: I5af8d41b50f4905453f03079e3ee6d46186536db
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2799359
    Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Original-Commit-Position: refs/heads/master@{#73772}
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2808934
    Cr-Commit-Position: refs/branch-heads/9.0@{#28}
    Cr-Branched-From: bd0108b-refs/heads/9.0.257@{#1}
    Cr-Branched-From: 349bcc6-refs/heads/master@{#73001}
    schuay authored and Commit Bot committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    4076646 View commit details
    Browse the repository at this point in the history
  2. Version 9.0.257.15

    TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com
    
    Change-Id: I256b64d3497e3cf014181c5b8c02850c5d1293f2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2810257
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/branch-heads/9.0@{#29}
    Cr-Branched-From: bd0108b-refs/heads/9.0.257@{#1}
    Cr-Branched-From: 349bcc6-refs/heads/master@{#73001}
    V8 Autoroll committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    1bff49d View commit details
    Browse the repository at this point in the history
  3. Merged: [wasm-simd][liftoff][x64][ia32] Fix i64x2.mul codegen

    We are overwriting rhs when dst == rhs && dst != lhs. This is not a
    problem on TurboFan because we specify unique registers and dst == lhs
    in the instruction-selector.
    
    The fix is to use the helper EmitSimdCommutativeBinOp, which will check
    for dst == rhs (pmuludq is commutative).
    
    (cherry picked from commit 7514db4)
    
    No-Try: true
    No-Presubmit: true
    No-Tree-Checks: true
    Tbr: gdeepti@chromium.org
    Bug: v8:11612
    Change-Id: I833a6bb21d41ca173ee36353758682128f706b8b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2805620
    Reviewed-by: Zhi An Ng <zhin@chromium.org>
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Cr-Commit-Position: refs/branch-heads/9.0@{#30}
    Cr-Branched-From: bd0108b-refs/heads/9.0.257@{#1}
    Cr-Branched-From: 349bcc6-refs/heads/master@{#73001}
    ngzhian authored and Commit Bot committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    04cca68 View commit details
    Browse the repository at this point in the history
  4. Version 9.0.257.16

    TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com
    
    Change-Id: I71ac6d2f9b37e06d38d8750cca63f342fdbb1c23
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2810185
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/branch-heads/9.0@{#31}
    Cr-Branched-From: bd0108b-refs/heads/9.0.257@{#1}
    Cr-Branched-From: 349bcc6-refs/heads/master@{#73001}
    V8 Autoroll committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    85e5cbe View commit details
    Browse the repository at this point in the history
Loading