Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: v8/v8
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7.0.276.36
Choose a base ref
...
head repository: v8/v8
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7.0.276.38
Choose a head ref
  • 4 commits
  • 6 files changed
  • 3 contributors

Commits on Nov 6, 2018

  1. Merged: [wasm] Fix streaming instantiation with no code section 

    Because of ordering issues we didn't set the wire bytes on the
{NativeModule} during {OnFinishedStream}. We then failed during
instantiation when trying to read the import names from the wire bytes.

This CL fixes this locally without much code churn. I plan to clean up
the interaction between {AsyncCompileJob} and {AsyncStreamingProcessor}
in a follow-up CL.

R=ahaas@chromium.org

Bug: chromium:898310
Change-Id: I88a651f4842f05c3316030b15ac096249acab7d7
Originally-reviewed-on: https://chromium-review.googlesource.com/c/1296467
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Reviewed-on: https://chromium-review.googlesource.com/c/1319587
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/branch-heads/7.0@{#75}
Cr-Branched-From: 6e2adae-refs/heads/7.0.276@{#1}
Cr-Branched-From: bc08a86-refs/heads/master@{#55424}
    @backes
    backes authored and Commit Bot committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    4949313 View commit details
    Browse the repository at this point in the history

  2. Version 7.0.276.37 

    TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: I9b96b1f18e5ee1aab48af061998826e3acdf9fbe
Reviewed-on: https://chromium-review.googlesource.com/c/1319255
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.0@{#76}
Cr-Branched-From: 6e2adae-refs/heads/7.0.276@{#1}
Cr-Branched-From: bc08a86-refs/heads/master@{#55424}
    V8 Autoroll committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    0901ee5 View commit details
    Browse the repository at this point in the history

  3. Merged: [array] Fix left-trimming in Array.p.sort 

    Whenever left-trimming is possible (e.g. whenever user code is
called), we must not store a reference to an exposed JSArray's
elements.

Original CL: https://crrev.com/c/1292066.

No-Try: true
No-Presubmit: true
No-Treechecks: true
Bug: chromium:897366,v8:7382
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.v8.try:v8_linux_noi18n_rel_ng
Change-Id: I200eca23a09ee4b5d5e4a4ed0440a8037efd6bfa
Reviewed-on: https://chromium-review.googlesource.com/c/1319752
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/branch-heads/7.0@{#77}
Cr-Branched-From: 6e2adae-refs/heads/7.0.276@{#1}
Cr-Branched-From: bc08a86-refs/heads/master@{#55424}
    @schuay
    schuay authored and Commit Bot committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    5d42640 View commit details
    Browse the repository at this point in the history

  4. Version 7.0.276.38 

    TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: I1aaa0c54298d383daed047fb458e1a9318f08309
Reviewed-on: https://chromium-review.googlesource.com/c/1319261
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.0@{#78}
Cr-Branched-From: 6e2adae-refs/heads/7.0.276@{#1}
Cr-Branched-From: bc08a86-refs/heads/master@{#55424}
    V8 Autoroll committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    2084ccf View commit details
    Browse the repository at this point in the history
Loading