Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: v8/v8
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 11.0.193
Choose a base ref
...
head repository: v8/v8
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 11.0.194
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 19 commits
  • 74 files changed
  • 12 contributors

Commits on Dec 8, 2022

  1. [maglev] Fix uninitialized read in ForInNext 

    ForInPrepare should store the accumulator into the {cache_type}
register. Since this was not being done, we were extending
the lifetime of whatever was in this register (in this case
a CallRuntime coming from a catch block) to ForInNext.
So we were basically doing an uninitialized read in that node.

Bug: v8:7700
Fixed: chromium:1393547
Change-Id: If3fe4118bfffac089757170ae9ed5ccba9e4af86
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4084792
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84719}
    @victorgomes
    victorgomes authored and V8 LUCI CQ committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    011d5ea View commit details
    Browse the repository at this point in the history

  2. [resultdb] Add more data about tests 

    Data added:
 - subtest_id as it is generated by Processors
 - processor_name to trace back the processors that generate subtests
 - path of the test
 - test_id suffixes introduced by processors:
   - numfuzz will have
     - an `analysis` suffix for analysis phase
     - a number suffix for the variants generated after analysis
   - variant processor adds a suffix for every variant
   - subtests will inherit suffixes from the parent tests (origin)

V8-Recipe-Flags: resultdb
Cq-Include-Trybots: luci.v8.try:v8_numfuzz_dbg,v8_numfuzz_rel,v8_numfuzz_tsan_compile_rel,v8_numfuzz_tsan_rel
Bug: v8:13316
Change-Id: I67d8b92b575c31b201238cfbcfc76cd076a2f7af
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4081127
Commit-Queue: Liviu Rau <liviurau@google.com>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84720}
    Liviu Rau authored and V8 LUCI CQ committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    576d8f9 View commit details
    Browse the repository at this point in the history

  3. [turbolizer] Allow live ranges display to switch axes 

    Add the option to swap what is displayed on which
axis and increase the density in the horizontal axis
when displaying live ranges in turbolizer.

Bug: v8:7327
Change-Id: I47ac94d93942bdf760ad330a19f8f567078fd531
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4085144
Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
Commit-Queue: George Wort <george.wort@arm.com>
Cr-Commit-Position: refs/heads/main@{#84721}
    @GeorgeWort
    GeorgeWort authored and V8 LUCI CQ committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    a5ef6cd View commit details
    Browse the repository at this point in the history

  4. [heap] Disable black allocation in shared heap during client GC 

    A scavenger GC can run on a client isolate while incremental marking
is enabled in the shared space isolate. While we pause black
allocation in the client's heap, we can't really pause it in the
shared heap isolate.

This CL solves that by marking ConcurrentAllocator instances created
for the GC. Black allocation is never enabled during GC. This will
probably also be useful when moving LABs out of the spaces.

Bug: v8:13267
Change-Id: Ie92848854c39229a8eca74cb07bd4be19a725ec8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4085503
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
Auto-Submit: Dominik Inführ <dinfuehr@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84722}
    Dominik Inführ authored and V8 LUCI CQ committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    f5f735b View commit details
    Browse the repository at this point in the history

  5. [maglev] Fix early return in MaterialiseValueNode 

    When we split MaterialisedValueNodes to x64 and arm64, we
changed a bit the logic and we should return early in case
of a constant, otherwise we would fail in the DCHECK in line 269.

Bug: v8:7700
Fixed: chromium:1395603
Change-Id: I3ce6dcb5e4e8e0040ef16fb3b3065ef7b86c7c36
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4088362
Commit-Queue: Patrick Thier <pthier@chromium.org>
Reviewed-by: Patrick Thier <pthier@chromium.org>
Auto-Submit: Victor Gomes <victorgomes@chromium.org>
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84723}
    @victorgomes
    victorgomes authored and V8 LUCI CQ committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    fd3112b View commit details
    Browse the repository at this point in the history

  6. [maglev] Force arguments to apply() be a tagged value 

    When reducing the apply() builtin, we should force the arguments
to be tagged.

Bug: v8:7700
Fixed: chromium:1394787
Change-Id: Ic62ea1dcf669a271f9ab20454b70dbb9374f166f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4086544
Reviewed-by: Patrick Thier <pthier@chromium.org>
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Commit-Queue: Patrick Thier <pthier@chromium.org>
Auto-Submit: Victor Gomes <victorgomes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84724}
    @victorgomes
    victorgomes authored and V8 LUCI CQ committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    c690be5 View commit details
    Browse the repository at this point in the history

  7. [turbolizer] Remove tslint:recommended so that presubmit can be run 

    TSLint has been deprecated and so the presubmit script will not
run because of tslint:recommended. Removing this allows the
explicit rules to be run but does not properly fix the use of
TSLint. Also fix the issues that do not pass the linter.

Bug: v8:7327
Change-Id: I9f463ba9520ee2caa4141b21b81fd15012afedff
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4085145
Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
Commit-Queue: George Wort <george.wort@arm.com>
Cr-Commit-Position: refs/heads/main@{#84725}
    @GeorgeWort
    GeorgeWort authored and V8 LUCI CQ committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    d5c6b92 View commit details
    Browse the repository at this point in the history

  8. [codegen] Adding victorgomes to OWNERS 

    Change-Id: I5abecd9ae018e7add14eab02073ac6511804e359
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4078907
Auto-Submit: Victor Gomes <victorgomes@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84726}
    @victorgomes
    victorgomes authored and V8 LUCI CQ committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    6b3ab95 View commit details
    Browse the repository at this point in the history

  9. [heap] Fix typo in pretenuring 

    PretenturingHandler -> PretenuringHandler

Change-Id: If25e8be65dc6050688213fbb481751d7cbcd0e8b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4085984
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84727}
    @omerktz
    omerktz authored and V8 LUCI CQ committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    350f572 View commit details
    Browse the repository at this point in the history

  10. [wasm-gc] Change MatchesSignature to use canonical types 

    Specifically, the methods in {WasmJSFunction} and {WasmCapiFunction}.
Drive-by:
- Fix a bug in {WasmCapiFunction::GetSignature}.
- Fix a bug in wasm-module-builder.js.

Bug: v8:7748
Change-Id: I7408d07766536ed37f23b97ad210212b986412bf
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4079097
Commit-Queue: Manos Koukoutos <manoskouk@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84728}
    @manoskouk
    manoskouk authored and V8 LUCI CQ committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    ba6be82 View commit details
    Browse the repository at this point in the history

  11. [maglev][arm64] AssertStackSize 

    Bug: v8:7700
Change-Id: Id3874b55790dd26cc2da4583fbc00ea39e8b1c8a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4084765
Auto-Submit: Victor Gomes <victorgomes@chromium.org>
Reviewed-by: Darius Mercadier <dmercadier@chromium.org>
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Commit-Queue: Darius Mercadier <dmercadier@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84729}
    @victorgomes
    victorgomes authored and V8 LUCI CQ committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    5d7b57b View commit details
    Browse the repository at this point in the history

  12. [heap] Adjust pretenuring heuristic for MinorMC 

    MinorMC needed to process pretenuring feedback both after sweeping and
at the end of the atomic pause, despite having no new feedback at the
end of the atomic pause, because the heuristics didn't hold after
sweeping. This CL adjusts the heuristics for MinorMC so that processing
twice is no longer needed.

Bug: v8:12612
Change-Id: I4d3ebaeaa6e7868bcdcae6fbdb3bcecb0ebcb8bf
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4085983
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84730}
    @omerktz
    omerktz authored and V8 LUCI CQ committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    a614ccb View commit details
    Browse the repository at this point in the history

  13. [heap][wasm] Scan wasm inactive stacks 

    Wasm stack switching breaks the expectations of the unified V8/C++
heap by breaking the stack into multiple segments. To fix this:

- Store a list of interesting inactive stacks in the heap's Stack object
- When wasm switches stack, update this list, and also update the stack
  start pointer
- Change {Stack::IteratePointers} to also visit pointers in the current
  list of inactive stacks

R=nikolaos@chromium.org,jkummerow@chromium.org
CC=​​irezvov@chromium.org

Bug: v8:13493
Change-Id: Ieafeb89da31325e542e67403b6dc66c28d3be2fe
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4081126
Commit-Queue: Thibaud Michaud <thibaudm@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Nikolaos Papaspyrou <nikolaos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84731}
    @thibaudmichaud
    thibaudmichaud authored and V8 LUCI CQ committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    d9aa68e View commit details
    Browse the repository at this point in the history

  14. Doubling shards for slow tests on V8 Linux(64) - debug 

    Bug: v8:13572
Change-Id: I83535b54ecaa26009076602be06908705d2836c1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4088503
Commit-Queue: Almothana Athamneh <almuthanna@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Auto-Submit: Almothana Athamneh <almuthanna@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84732}
    @almuthanna-athamina
    almuthanna-athamina authored and V8 LUCI CQ committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    bf17a2c View commit details
    Browse the repository at this point in the history

  15. [wasm-gc] Add new br_on_cast_fail variant taking a heap type immediate 

    Adds new `br_on_cast_fail <branch depth> <heap type>` instruction
with opcode 0xfb43.
The instruction branches if the cast fails. `null` is treated as a cast
failure (meaning the branch is taken).
The heap type may be any concreate heap type index or an abstract
type like `(ref null eq)`.

Bug: v8:7748
Change-Id: I97a78d6d0872703ab825016cab4e737f8f79995f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4084981
Reviewed-by: Manos Koukoutos <manoskouk@chromium.org>
Commit-Queue: Matthias Liedtke <mliedtke@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84733}
    @Liedtke
    Liedtke authored and V8 LUCI CQ committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    c2a1261 View commit details
    Browse the repository at this point in the history

  16. PPC[liftoff]: Implement simd fp qfma ops 

    Change-Id: I4faac2355eb6d84a33674fd47bb2f728ace2ccb9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4086423
Reviewed-by: Vasili Skurydzin <vasili.skurydzin@ibm.com>
Commit-Queue: Milad Farazmand <mfarazma@redhat.com>
Cr-Commit-Position: refs/heads/main@{#84734}
    Milad Fa authored and V8 LUCI CQ committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    73801da View commit details
    Browse the repository at this point in the history

  17. [maglev][arm64] Implement first Float64 operations 

    Bug: v8:7700
Change-Id: Ib2d9d0cab90042e2b425f56da8022b25b94c4805
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4082208
Commit-Queue: Darius Mercadier <dmercadier@chromium.org>
Reviewed-by: Victor Gomes <victorgomes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84735}
    @DadaIsCrazy
    DadaIsCrazy authored and V8 LUCI CQ committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    ada6f41 View commit details
    Browse the repository at this point in the history

  18. [resultdb] Make suffixes more distinguishable 

    Test ids would get an uniform format between different kinds of tests:
prefix//test_id//suffix

 - prefix:
   - empty for regular tests
   - or 'special test' token, as in 'numfuzz'
 - test_id is the full name of the test as generated by test runner:
   - suite_name/path/to/actual/test_name
 - suffix is anything a test runner processor might want to add to the name:
   - numfuzz processor will add 'analysis' of a numeric value
   - variant processor will add the variant name

Bug: v8:13316
Change-Id: Ied8f958173f82d8e26c62e39ccc21167ca2928ab
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4084763
Commit-Queue: Liviu Rau <liviurau@google.com>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84736}
    Liviu Rau authored and V8 LUCI CQ committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    46efa1b View commit details
    Browse the repository at this point in the history

  19. Version 11.0.194 

    Change-Id: I95bd30feb0547f6de68205fd686adee5f82048a5
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4085137
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/11.0.194@{#1}
Cr-Branched-From: 46efa1b-refs/heads/main@{#84736}
    v8-ci-autoroll-builder committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    3ed2281 View commit details
    Browse the repository at this point in the history
Loading