Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: v8/v8
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 10.8.168.21
Choose a base ref
...
head repository: v8/v8
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 10.8.168.25
Choose a head ref
  • 8 commits
  • 8 files changed
  • 4 contributors

Commits on Dec 7, 2022

  1. Merged: [sandbox] Do not trigger GC during EPT entry allocation

    This simplifies some call sites as they do not need to worry about
    stores to external pointer fields (especially lazily initialized ones)
    triggering GCs. This also keeps the sandbox and non-sandbox mode more
    consistent, as these stores will never trigger GC in non-sandbox builds.
    Since there must be millions of objects that own the external pointer
    table entries, the chances are quite high that GCs will anyway be
    scheduled. If not, we should instead see if we can introduce an API
    to only schedule incremental marking but not perform GC finalization.
    
    Bug: v8:13535
    Cr-Commit-Position: refs/heads/main@{#84508}
    (cherry picked from commit 852aa18)
    
    Change-Id: I6e7b927ec722b7c9aff2fc6e620b70c94b29db41
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4086221
    Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Samuel Groß <saelo@chromium.org>
    Cr-Commit-Position: refs/branch-heads/10.8@{#42}
    Cr-Branched-From: f1bc03f-refs/heads/10.8.168@{#1}
    Cr-Branched-From: 237de89-refs/heads/main@{#83672}
    Samuel Groß authored and V8 LUCI CQ committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    46e5212 View commit details
    Browse the repository at this point in the history
  2. Version 10.8.168.22

    Change-Id: I9959ca7f1aba9e51f5f3179a079a120882bdc160
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4086503
    Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/branch-heads/10.8@{#43}
    Cr-Branched-From: f1bc03f-refs/heads/10.8.168@{#1}
    Cr-Branched-From: 237de89-refs/heads/main@{#83672}
    V8 Autoroll committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    4bbab24 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. Merged: [parser] Reset the calls_eval flag after arrow head

    Otherwise it's propagated to the parent
    
    Bug: chromium:1394973
    (cherry picked from commit e1e0890)
    
    Change-Id: I723e7b289b9aa3016cc466bd349898d7c7e0ffe9
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4108349
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Commit-Queue: Igor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/branch-heads/10.8@{#44}
    Cr-Branched-From: f1bc03f-refs/heads/10.8.168@{#1}
    Cr-Branched-From: 237de89-refs/heads/main@{#83672}
    verwaest authored and V8 LUCI CQ committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    4ace4b0 View commit details
    Browse the repository at this point in the history
  2. Version 10.8.168.23

    Change-Id: If72ddb9fdcc1f33fba2ef13277a8485d4c495ed5
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4107472
    Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/branch-heads/10.8@{#45}
    Cr-Branched-From: f1bc03f-refs/heads/10.8.168@{#1}
    Cr-Branched-From: 237de89-refs/heads/main@{#83672}
    V8 Autoroll committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    7fed14d View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. Merged: [wasm][turbofan] Load 32-bit values more efficiently

    When loading a 32-bit value from the stack, just load 32 bit and
    zero-extend them into the target register, instead of loading the full
    64 bits.
    
    As there are things to fix (see https://crbug.com/1356461), we only
    enable this optimization for Wasm for now.
    
    Also include the related fix https://crrev.com/c/4096985.
    
    R=mslekova@chromium.org
    
    (cherry picked from commit 2ee5244)
    (cherry picked from commit a382099)
    
    Bug: chromium:1395604
    Change-Id: I54a2182ada6fadbfcf5565f0dc8d4f477ecff393
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4110897
    Reviewed-by: Maya Lekova <mslekova@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/branch-heads/10.8@{#46}
    Cr-Branched-From: f1bc03f-refs/heads/10.8.168@{#1}
    Cr-Branched-From: 237de89-refs/heads/main@{#83672}
    backes authored and V8 LUCI CQ committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    0f481c9 View commit details
    Browse the repository at this point in the history
  2. Version 10.8.168.24

    Change-Id: I8c928228c51f32689687b3929439a214d3cd4a1e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4111702
    Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/branch-heads/10.8@{#47}
    Cr-Branched-From: f1bc03f-refs/heads/10.8.168@{#1}
    Cr-Branched-From: 237de89-refs/heads/main@{#83672}
    V8 Autoroll committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    3afa264 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. Merged: [arm] Do not emit the constant pool before a branch

    After computing the branch offset but before emitting the actual branch,
    we should not emit a constant pool. Otherwise the previously computed
    offset would be off.
    
    Instead of handling this indirectly via the Assembler::branch_offset
    method, do this directly in the Assembler::b method (and friends), so it
    is not missed on other call sites.
    
    R=nicohartmann@chromium.org
    
    (cherry picked from commit 9be597d)
    Bug: chromium:1399424
    
    Change-Id: Ie30ba70508b4fb8913f79e049a33108608915704
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4118864
    Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/branch-heads/10.8@{#48}
    Cr-Branched-From: f1bc03f-refs/heads/10.8.168@{#1}
    Cr-Branched-From: 237de89-refs/heads/main@{#83672}
    backes authored and V8 LUCI CQ committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    28b9c1c View commit details
    Browse the repository at this point in the history
  2. Version 10.8.168.25

    Change-Id: I2d2232348e3c8d8bfc3e837bb564dc20dcbae270
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4117883
    Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/branch-heads/10.8@{#49}
    Cr-Branched-From: f1bc03f-refs/heads/10.8.168@{#1}
    Cr-Branched-From: 237de89-refs/heads/main@{#83672}
    V8 Autoroll committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    18a6255 View commit details
    Browse the repository at this point in the history
Loading