use explicit v8::String namespace in internal code

joyeecheung · V8 LUCI CQ · commit a580b463ac35 · 2025-02-17T08:03:33.000-08:00
This otherwise does not compile with clangcl 18.1 on Windows because it would be inferred as v8::internal::String Refs: nodejs/node#56959 Change-Id: Ia14e2a5c2a730772a64e1c31019d0144d4eeb78f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6271543 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#98734}
diff --git a/src/wasm/wasm-module-sourcemap.cc b/src/wasm/wasm-module-sourcemap.cc
@@ -69,7 +69,7 @@ WasmModuleSourceMap::WasmModuleSourceMap(v8::Isolate* v8_isolate,
     size_t file_name_sz = file_name->Utf8LengthV2(v8_isolate) + 1;
     std::unique_ptr<char[]> file_name_buf(new char[file_name_sz]);
     file_name->WriteUtf8V2(v8_isolate, file_name_buf.get(), file_name_sz,
-                           String::WriteFlags::kNullTerminate);
+                           v8::String::WriteFlags::kNullTerminate);
     filenames.emplace_back(file_name_buf.get());
   }
 
@@ -84,7 +84,7 @@ WasmModuleSourceMap::WasmModuleSourceMap(v8::Isolate* v8_isolate,
   size_t mappings_sz = mappings->Utf8LengthV2(v8_isolate) + 1;
   std::unique_ptr<char[]> mappings_buf(new char[mappings_sz]);
   mappings->WriteUtf8V2(v8_isolate, mappings_buf.get(), mappings_sz,
-                        String::WriteFlags::kNullTerminate);
+                        v8::String::WriteFlags::kNullTerminate);
 
   valid_ = DecodeMapping(mappings_buf.get());
 }
