Fix mistake in the skip branch of test/mjsunit/regress-1320641.js

joyeecheung · V8 LUCI CQ · commit 9f4b7699f68e · 2023-07-19T17:03:09.000Z
It was doing a `string.test(regex)` which was wrong. It's supposed to be `regex.test(string)`. It wasn't caught in the CI because the skip path is not normally taken in the V8 CI. Change-Id: Id1bdab5bbc41968bba8adc1cb3664e8f95fb5d72 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4697855 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#89044}
diff --git a/test/mjsunit/regress/regress-1320641.js b/test/mjsunit/regress/regress-1320641.js
@@ -13,7 +13,7 @@ var skip = false;
 try {
   new Uint16Array(3775336418);
 } catch (e) {
-  if (e.message.test(/Array buffer allocation failed/)) {
+  if (/Array buffer allocation failed/.test(e.message)) {
     skip = true;  // We don't have enough memory, just skip the test.
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ var skip = false;`
`13`	`13`	`try {`
`14`	`14`	`new Uint16Array(3775336418);`
`15`	`15`	`} catch (e) {`
`16`		`- if (e.message.test(/Array buffer allocation failed/)) {`
	`16`	`+ if (/Array buffer allocation failed/.test(e.message)) {`
`17`	`17`	`skip = true; // We don't have enough memory, just skip the test.`
`18`	`18`	`}`
`19`	`19`	`}`