[symbol-as-weakmap-key] Ship the proposal

syg · V8 LUCI CQ · commit 705e374124ae · 2022-11-08T17:47:17.000Z
I2S with 3 LGTMs: https://groups.google.com/a/chromium.org/g/blink-dev/c/E6pDZP_TiBA/m/ZcXLwiz8AAAJ Bug: v8:12947 Change-Id: Ibce4abc8b0610afb2041d44cc9ed136db8b62c0d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4004610 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#84128}
diff --git a/src/flags/flag-definitions.h b/src/flags/flag-definitions.h
@@ -231,12 +231,11 @@ DEFINE_BOOL(harmony_shipping, true, "enable all shipped harmony features")
 #endif
 
 // Features that are complete (but still behind the --harmony flag).
-#define HARMONY_STAGED_BASE(V)                                    \
-  V(harmony_rab_gsab,                                             \
-    "harmony ResizableArrayBuffer / GrowableSharedArrayBuffer")   \
-  V(harmony_array_grouping, "harmony array grouping")             \
-  V(harmony_change_array_by_copy, "harmony change-Array-by-copy") \
-  V(harmony_symbol_as_weakmap_key, "harmony symbols as weakmap keys")
+#define HARMONY_STAGED_BASE(V)                                  \
+  V(harmony_rab_gsab,                                           \
+    "harmony ResizableArrayBuffer / GrowableSharedArrayBuffer") \
+  V(harmony_array_grouping, "harmony array grouping")           \
+  V(harmony_change_array_by_copy, "harmony change-Array-by-copy")
 
 #ifdef V8_INTL_SUPPORT
 #define HARMONY_STAGED(V) HARMONY_STAGED_BASE(V)
@@ -250,7 +249,8 @@ DEFINE_BOOL(harmony_shipping, true, "enable all shipped harmony features")
   V(harmony_atomics, "harmony atomics")                               \
   V(harmony_class_static_blocks, "harmony static initializer blocks") \
   V(harmony_array_find_last, "harmony array find last helpers")       \
-  V(harmony_import_assertions, "harmony import assertions")
+  V(harmony_import_assertions, "harmony import assertions")           \
+  V(harmony_symbol_as_weakmap_key, "harmony symbols as weakmap keys")
 
 #ifdef V8_INTL_SUPPORT
 #define HARMONY_SHIPPING(V) \
diff --git a/test/mjsunit/es6/collections.js b/test/mjsunit/es6/collections.js
@@ -77,7 +77,6 @@ function TestInvalidCalls(m) {
   assertThrows(function () { m.set(null, 0) }, TypeError);
   assertThrows(function () { m.set(0, 0) }, TypeError);
   assertThrows(function () { m.set('a-key', 0) }, TypeError);
-  assertThrows(function () { m.set(Symbol(), 0) }, TypeError);
 }
 TestInvalidCalls(new WeakMap);
 
diff --git a/test/mjsunit/harmony/weakrefs/basics.js b/test/mjsunit/harmony/weakrefs/basics.js
@@ -51,7 +51,6 @@
   assertThrows(() => fg.register(1, "holdings"), TypeError, message);
   assertThrows(() => fg.register(false, "holdings"), TypeError, message);
   assertThrows(() => fg.register("foo", "holdings"), TypeError, message);
-  assertThrows(() => fg.register(Symbol(), "holdings"), TypeError, message);
   assertThrows(() => fg.register(null, "holdings"), TypeError, message);
   assertThrows(() => fg.register(undefined, "holdings"), TypeError, message);
 })();
@@ -97,7 +96,6 @@
   assertThrows(() => fg.unregister(1), TypeError);
   assertThrows(() => fg.unregister(1n), TypeError);
   assertThrows(() => fg.unregister('one'), TypeError);
-  assertThrows(() => fg.unregister(Symbol()), TypeError);
   assertThrows(() => fg.unregister(true), TypeError);
   assertThrows(() => fg.unregister(false), TypeError);
   assertThrows(() => fg.unregister(undefined), TypeError);
@@ -121,7 +119,6 @@
   assertThrows(() => new WeakRef(1), TypeError, message);
   assertThrows(() => new WeakRef(false), TypeError, message);
   assertThrows(() => new WeakRef("foo"), TypeError, message);
-  assertThrows(() => new WeakRef(Symbol()), TypeError, message);
   assertThrows(() => new WeakRef(null), TypeError, message);
   assertThrows(() => new WeakRef(undefined), TypeError, message);
 })();

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,6 @@ function TestInvalidCalls(m) {`
`77`	`77`	`assertThrows(function () { m.set(null, 0) }, TypeError);`
`78`	`78`	`assertThrows(function () { m.set(0, 0) }, TypeError);`
`79`	`79`	`assertThrows(function () { m.set('a-key', 0) }, TypeError);`
`80`		`- assertThrows(function () { m.set(Symbol(), 0) }, TypeError);`
`81`	`80`	`}`
`82`	`81`	`TestInvalidCalls(new WeakMap);`
`83`	`82`