Emit better error message if array buffer allocation fails

skomski · Commit bot · commit 60f831749fa4 · 2015-10-09T20:44:50.000Z
Now emits `Array buffer allocation failed` instead of `Invalid array buffer length`. Review URL: https://codereview.chromium.org/1393263003 Cr-Commit-Position: refs/heads/master@{#31200}
diff --git a/src/messages.h b/src/messages.h
@@ -253,6 +253,7 @@ class CallSite {
   T(DateRange, "Provided date is not in valid range.")                         \
   T(ExpectedLocation, "Expected Area/Location for time zone, got %")           \
   T(InvalidArrayBufferLength, "Invalid array buffer length")                   \
+  T(ArrayBufferAllocationFailed, "Array buffer allocation failed")             \
   T(InvalidArrayLength, "Invalid array length")                                \
   T(InvalidCodePoint, "Invalid code point %")                                  \
   T(InvalidCountValue, "Invalid count value")                                  \
diff --git a/src/runtime/runtime-typedarray.cc b/src/runtime/runtime-typedarray.cc
@@ -33,7 +33,7 @@ RUNTIME_FUNCTION(Runtime_ArrayBufferInitialize) {
           holder, isolate, allocated_length, true,
           is_shared ? SharedFlag::kShared : SharedFlag::kNotShared)) {
     THROW_NEW_ERROR_RETURN_FAILURE(
-        isolate, NewRangeError(MessageTemplate::kInvalidArrayBufferLength));
+        isolate, NewRangeError(MessageTemplate::kArrayBufferAllocationFailed));
   }
   return *holder;
 }

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ RUNTIME_FUNCTION(Runtime_ArrayBufferInitialize) {`
`33`	`33`	`holder, isolate, allocated_length, true,`
`34`	`34`	`is_shared ? SharedFlag::kShared : SharedFlag::kNotShared)) {`
`35`	`35`	`THROW_NEW_ERROR_RETURN_FAILURE(`
`36`		`- isolate, NewRangeError(MessageTemplate::kInvalidArrayBufferLength));`
	`36`	`+ isolate, NewRangeError(MessageTemplate::kArrayBufferAllocationFailed));`
`37`	`37`	`}`
`38`	`38`	`return *holder;`
`39`	`39`	`}`