[flags] Split off header with implementation details

mi-ac · V8 LUCI CQ · commit 4af6461ae38d · 2024-02-20T10:17:46.000Z
Bug: 41497291 Change-Id: I930f6157e2a5ffbc1ac9bd9c76b008029ce7de63 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5300310 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#92417}
diff --git a/BUILD.bazel b/BUILD.bazel
@@ -674,6 +674,7 @@ filegroup(
     name = "v8_flags",
     srcs = [
         "src/flags/flag-definitions.h",
+        "src/flags/flags-impl.h",
         "src/flags/flags.h",
     ] + select({
         "is_v8_enable_webassembly": ["src/wasm/wasm-feature-flags.h"],
@@ -1540,6 +1541,7 @@ filegroup(
         "src/extensions/trigger-failure-extension.cc",
         "src/extensions/trigger-failure-extension.h",
         "src/flags/flag-definitions.h",
+        "src/flags/flags-impl.h",
         "src/flags/flags.cc",
         "src/flags/flags.h",
         "src/handles/global-handles.cc",
diff --git a/BUILD.gn b/BUILD.gn
@@ -3145,6 +3145,7 @@ v8_header_set("v8_flags") {
 
   sources = [
     "src/flags/flag-definitions.h",
+    "src/flags/flags-impl.h",
     "src/flags/flags.h",
   ]
 
diff --git a/src/flags/flags-impl.h b/src/flags/flags-impl.h
@@ -0,0 +1,23 @@
+// Copyright 2024 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef V8_FLAGS_FLAGS_IMPL_H_
+#define V8_FLAGS_FLAGS_IMPL_H_
+
+#include "src/base/macros.h"
+
+namespace v8::internal {
+
+class V8_EXPORT_PRIVATE FlagHelpers {
+ public:
+  static char NormalizeChar(char ch);
+
+  static int FlagNamesCmp(const char* a, const char* b);
+
+  static bool EqualNames(const char* a, const char* b);
+};
+
+}  // namespace v8::internal
+
+#endif  // V8_FLAGS_FLAGS_IMPL_H_
diff --git a/src/flags/flags.cc b/src/flags/flags.cc
@@ -20,6 +20,7 @@
 #include "src/base/logging.h"
 #include "src/base/platform/platform.h"
 #include "src/codegen/cpu-features.h"
+#include "src/flags/flags-impl.h"
 #include "src/logging/counters.h"
 #include "src/logging/tracing-flags.h"
 #include "src/tracing/tracing-category-observer.h"
diff --git a/src/flags/flags.h b/src/flags/flags.h
@@ -18,15 +18,6 @@
 
 namespace v8::internal {
 
-class V8_EXPORT_PRIVATE FlagHelpers {
- public:
-  static char NormalizeChar(char ch);
-
-  static int FlagNamesCmp(const char* a, const char* b);
-
-  static bool EqualNames(const char* a, const char* b);
-};
-
 // The value of a single flag (this is the type of all v8_flags.* fields).
 template <typename T>
 class FlagValue {
diff --git a/test/unittests/flags/flag-definitions-unittest.cc b/test/unittests/flags/flag-definitions-unittest.cc
@@ -27,6 +27,7 @@
 
 #include <stdlib.h>
 
+#include "src/flags/flags-impl.h"
 #include "src/flags/flags.h"
 #include "src/init/v8.h"
 #include "test/unittests/fuzztest.h"

Original file line number	Diff line number	Diff line change
`@@ -3145,6 +3145,7 @@ v8_header_set("v8_flags") {`
`3145`	`3145`
`3146`	`3146`	`sources = [`
`3147`	`3147`	`"src/flags/flag-definitions.h",`
	`3148`	`+ "src/flags/flags-impl.h",`
`3148`	`3149`	`"src/flags/flags.h",`
`3149`	`3150`	`]`
`3150`	`3151`