Skip to content

Commit 2cd2f5f

Browse files
jeisingerCommit Bot
jeisinger
authored and
Commit Bot
committed
Remove experimental fast accessor builder API
As the code isn't used, but would have to be ported from hand-written assembly to CodeStubAssembler anyways, I propose to remove it and restore it if we decide that we actually need it. R=vogelheim@chromium.org BUG= Change-Id: Iffd7fc6ec534b1dd7a9144da900424355c8a7a02 Reviewed-on: https://chromium-review.googlesource.com/453461 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#43763}
1 parent 97254b0 commit 2cd2f5f

37 files changed

Lines changed: 14 additions & 2336 deletions

‎BUILD.gn‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -890,7 +890,6 @@ v8_source_set("v8_base") {
890890

891891
### gcmole(all) ###
892892
"include/v8-debug.h",
893-
"include/v8-experimental.h",
894893
"include/v8-platform.h",
895894
"include/v8-profiler.h",
896895
"include/v8-testing.h",
@@ -908,8 +907,6 @@ v8_source_set("v8_base") {
908907
"src/api-arguments-inl.h",
909908
"src/api-arguments.cc",
910909
"src/api-arguments.h",
911-
"src/api-experimental.cc",
912-
"src/api-experimental.h",
913910
"src/api-natives.cc",
914911
"src/api-natives.h",
915912
"src/api.cc",
@@ -1390,8 +1387,6 @@ v8_source_set("v8_base") {
13901387
"src/external-reference-table.h",
13911388
"src/factory.cc",
13921389
"src/factory.h",
1393-
"src/fast-accessor-assembler.cc",
1394-
"src/fast-accessor-assembler.h",
13951390
"src/fast-dtoa.cc",
13961391
"src/fast-dtoa.h",
13971392
"src/feedback-vector-inl.h",

‎include/v8-experimental.h‎

Lines changed: 0 additions & 58 deletions
This file was deleted.

‎include/v8.h‎

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -137,10 +137,6 @@ class CallHandlerHelper;
137137
class EscapableHandleScope;
138138
template<typename T> class ReturnValue;
139139

140-
namespace experimental {
141-
class FastAccessorBuilder;
142-
} // namespace experimental
143-
144140
namespace internal {
145141
class Arguments;
146142
class Heap;
@@ -5100,16 +5096,6 @@ class V8_EXPORT FunctionTemplate : public Template {
51005096
static MaybeLocal<FunctionTemplate> FromSnapshot(Isolate* isolate,
51015097
size_t index);
51025098

5103-
/**
5104-
* Creates a function template with a fast handler. If a fast handler is set,
5105-
* the callback cannot be null.
5106-
*/
5107-
static Local<FunctionTemplate> NewWithFastHandler(
5108-
Isolate* isolate, FunctionCallback callback,
5109-
experimental::FastAccessorBuilder* fast_handler = nullptr,
5110-
Local<Value> data = Local<Value>(),
5111-
Local<Signature> signature = Local<Signature>(), int length = 0);
5112-
51135099
/**
51145100
* Creates a function template backed/cached by a private property.
51155101
*/
@@ -5137,9 +5123,8 @@ class V8_EXPORT FunctionTemplate : public Template {
51375123
* callback is called whenever the function created from this
51385124
* FunctionTemplate is called.
51395125
*/
5140-
void SetCallHandler(
5141-
FunctionCallback callback, Local<Value> data = Local<Value>(),
5142-
experimental::FastAccessorBuilder* fast_handler = nullptr);
5126+
void SetCallHandler(FunctionCallback callback,
5127+
Local<Value> data = Local<Value>());
51435128

51445129
/** Set the predefined length property for the FunctionTemplate. */
51455130
void SetLength(int length);

‎src/api-experimental.cc‎

Lines changed: 0 additions & 139 deletions
This file was deleted.

‎src/api-experimental.h‎

Lines changed: 0 additions & 28 deletions
This file was deleted.

0 commit comments

Comments
 (0)