[parser] Fix the MSVC build

gengjiawen · V8 LUCI CQ · commit 2a0bc36dec12 · 2021-10-11T11:46:49.000Z
MSVC seems to instantiate the Parser::PreParserIdentifierToAstRawString method despite it being unused. This CL adds an (unreachable) definition for it. Bug: v8:12266 Change-Id: I355ca82a9d6b7bc8cd16768a8df93e40f8bfc638 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3199856 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#77313}
diff --git a/src/parsing/parser.h b/src/parsing/parser.h
@@ -709,6 +709,13 @@ class V8_EXPORT_PRIVATE Parser : public NON_EXPORTED_BASE(ParserBase<Parser>) {
     return arg;
   }
 
+  const AstRawString* PreParserIdentifierToAstRawString(
+      const PreParserIdentifier& arg) {
+    // This method definition is only needed due to an MSVC oddity that
+    // instantiates the method despite it being unused. See crbug.com/v8/12266 .
+    UNREACHABLE();
+  }
+
   IterationStatement* AsIterationStatement(BreakableStatement* s) {
     return s->AsIterationStatement();
   }

Original file line number	Diff line number	Diff line change
`@@ -709,6 +709,13 @@ class V8_EXPORT_PRIVATE Parser : public NON_EXPORTED_BASE(ParserBase<Parser>) {`
`709`	`709`	`return arg;`
`710`	`710`	`}`
`711`	`711`
	`712`	`+ const AstRawString* PreParserIdentifierToAstRawString(`
	`713`	`+ const PreParserIdentifier& arg) {`
	`714`	`+ // This method definition is only needed due to an MSVC oddity that`
	`715`	`+ // instantiates the method despite it being unused. See crbug.com/v8/12266 .`
	`716`	`+ UNREACHABLE();`
	`717`	`+ }`
	`718`	`+`
`712`	`719`	`IterationStatement* AsIterationStatement(BreakableStatement* s) {`
`713`	`720`	`return s->AsIterationStatement();`
`714`	`721`	`}`