Skip to content

Commit 166fd2f

Browse files
gengjiawenV8 LUCI CQ
authored andcommitted
[cppgc]: Fix build on msvc
Fixes compilation with msvc 2019 toolchain. See: nodejs/node#37330 (comment) Bug: v8:12661 Change-Id: I7cfd87a3dd531a2e4913d82b743fb8ecdfdb5ed8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3533019 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#85087}
1 parent 419a1c7 commit 166fd2f

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

include/v8-cppgc.h

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,15 @@ struct WrapperDescriptor final {
7777
};
7878

7979
struct V8_EXPORT CppHeapCreateParams {
80+
CppHeapCreateParams(
81+
std::vector<std::unique_ptr<cppgc::CustomSpaceBase>> custom_spaces,
82+
WrapperDescriptor wrapper_descriptor)
83+
: custom_spaces(std::move(custom_spaces)),
84+
wrapper_descriptor(wrapper_descriptor) {}
85+
86+
CppHeapCreateParams(const CppHeapCreateParams&) = delete;
87+
CppHeapCreateParams& operator=(const CppHeapCreateParams&) = delete;
88+
8089
std::vector<std::unique_ptr<cppgc::CustomSpaceBase>> custom_spaces;
8190
WrapperDescriptor wrapper_descriptor;
8291
/**

0 commit comments

Comments
 (0)