fdsend-common: using strncpy instead of strcpy

echoechoin · echoechoin · commit 0f6a82337967 · 2026-02-04T15:36:15.000+08:00
diff --git a/misc-utils/fdsend-common.c b/misc-utils/fdsend-common.c
@@ -66,7 +66,7 @@ static int sockpath_from_spec(const char *spec, char *path, size_t size)
 			errno = ENAMETOOLONG;
 			return -1;
 		}
-		strcpy(path, spec);
+		strncpy(path, spec, size);
 		return 0;
 	}
 
@@ -123,7 +123,7 @@ static int fdsend_wait_for_socket(const char *sockpath, int blocking)
 		errno = ENAMETOOLONG;
 		return -1;
 	}
-	strcpy(dir, sockpath);
+	strncpy(dir, sockpath, sizeof(dir));
 	base = strrchr(dir, '/');
 	if (base) {
 		*base = '\0';

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ static int sockpath_from_spec(const char spec, char path, size_t size)`
`66`	`66`	`errno = ENAMETOOLONG;`
`67`	`67`	`return -1;`
`68`	`68`	`}`
`69`		`- strcpy(path, spec);`
	`69`	`+ strncpy(path, spec, size);`
`70`	`70`	`return 0;`
`71`	`71`	`}`
`72`	`72`
`@@ -123,7 +123,7 @@ static int fdsend_wait_for_socket(const char *sockpath, int blocking)`
`123`	`123`	`errno = ENAMETOOLONG;`
`124`	`124`	`return -1;`
`125`	`125`	`}`
`126`		`- strcpy(dir, sockpath);`
	`126`	`+ strncpy(dir, sockpath, sizeof(dir));`
`127`	`127`	`base = strrchr(dir, '/');`
`128`	`128`	`if (base) {`
`129`	`129`	`*base = '\0';`