add parenthesis to conditional expression and format log messages

PhilippSalvisberg · PhilippSalvisberg · commit e9fc29c6565f · 2020-05-26T16:38:25.000+02:00
diff --git a/sqldev/src/main/java/org/utplsql/sqldev/runner/UtplsqlRunner.java b/sqldev/src/main/java/org/utplsql/sqldev/runner/UtplsqlRunner.java
@@ -268,7 +268,8 @@ private void produce() {
             dao.produceReport(reporterId, pathList);
             logger.fine(() -> "All events produced for reporter id " + reporterId + ".");
         } catch (Exception e) {
-            logger.severe(() -> "Error while producing events for reporter id " + reporterId + ": " + e != null ? e.getMessage() : "");
+            logger.severe(() -> "Error while producing events for reporter id " + reporterId + ": "
+                    + (e != null ? e.getMessage() : ""));
         }
     }
 
@@ -279,7 +280,8 @@ private void consume() {
             dao.consumeReport(reporterId, this);
             logger.fine(() -> "All events consumed.");
         } catch (final Exception e) {
-            logger.severe(() -> "Error while consuming events for reporter id " + reporterId + ": " + e != null ? e.getMessage() : "");
+            logger.severe(() -> "Error while consuming events for reporter id " + reporterId + ": "
+                    + (e != null ? e.getMessage() : ""));
         }
         if (run.getTotalNumberOfTests() < 0) {
             run.setStatus(UtplsqlResources.getString("RUNNER_NO_TESTS_FOUND_TEXT"));

Original file line number	Diff line number	Diff line change
`@@ -268,7 +268,8 @@ private void produce() {`
`268`	`268`	`dao.produceReport(reporterId, pathList);`
`269`	`269`	`logger.fine(() -> "All events produced for reporter id " + reporterId + ".");`
`270`	`270`	`} catch (Exception e) {`
`271`		`- logger.severe(() -> "Error while producing events for reporter id " + reporterId + ": " + e != null ? e.getMessage() : "");`
	`271`	`+ logger.severe(() -> "Error while producing events for reporter id " + reporterId + ": "`
	`272`	`+ + (e != null ? e.getMessage() : ""));`
`272`	`273`	`}`
`273`	`274`	`}`
`274`	`275`
`@@ -279,7 +280,8 @@ private void consume() {`
`279`	`280`	`dao.consumeReport(reporterId, this);`
`280`	`281`	`logger.fine(() -> "All events consumed.");`
`281`	`282`	`} catch (final Exception e) {`
`282`		`- logger.severe(() -> "Error while consuming events for reporter id " + reporterId + ": " + e != null ? e.getMessage() : "");`
	`283`	`+ logger.severe(() -> "Error while consuming events for reporter id " + reporterId + ": "`
	`284`	`+ + (e != null ? e.getMessage() : ""));`
`283`	`285`	`}`
`284`	`286`	`if (run.getTotalNumberOfTests() < 0) {`
`285`	`287`	`run.setStatus(UtplsqlResources.getString("RUNNER_NO_TESTS_FOUND_TEXT"));`