remove unnecessary this usages

PhilippSalvisberg · PhilippSalvisberg · commit e5bb2bf6c463 · 2020-05-25T11:27:16.000+02:00
diff --git a/sqldev/src/main/java/org/utplsql/sqldev/coverage/CodeCoverageReporter.java b/sqldev/src/main/java/org/utplsql/sqldev/coverage/CodeCoverageReporter.java
@@ -49,7 +49,7 @@ public CodeCoverageReporter(final List<String> pathList, final List<String> incl
             final String connectionName) {
         this.pathList = pathList;
         this.includeObjectList = includeObjectList;
-        this.setConnection(connectionName);
+        setConnection(connectionName);
     }
 
     public CodeCoverageReporter(final List<String> pathList, final List<String> includeObjectList,
@@ -67,7 +67,7 @@ private void setConnection(final String connectionName) {
         } else {
             try {
                 // must be closed manually
-                this.conn = Connections.getInstance()
+                conn = Connections.getInstance()
                         .cloneConnection(Connections.getInstance().getConnection(connectionName));
             } catch (ConnectionException e) {
                 logger.severe(() -> "ConnectionException while setting connection: " + e.getMessage());
@@ -94,9 +94,9 @@ private ArrayList<String> toStringList(final String s) {
     private void run() {
         logger.fine(() -> "Running code coverage reporter for " + pathList + "...");
         try {
-            final UtplsqlDao dal = new UtplsqlDao(this.conn);
-            final String content = dal.htmlCodeCoverage(this.pathList, this.toStringList(this.schemas),
-                    this.toStringList(this.includeObjects), this.toStringList(this.excludeObjects));
+            final UtplsqlDao dal = new UtplsqlDao(conn);
+            final String content = dal.htmlCodeCoverage(pathList, toStringList(schemas),
+                    toStringList(includeObjects), toStringList(excludeObjects));
             final File file = File.createTempFile("utplsql_", ".html");
             logger.fine(() -> "Writing result to " + file + "...");
             Files.write(file.toPath(), Arrays.asList(content.split(System.lineSeparator())), StandardCharsets.UTF_8);
@@ -130,22 +130,22 @@ public void setFrame(final CodeCoverageReporterDialog frame) {
     }
 
     public CodeCoverageReporterDialog getFrame() {
-        return this.frame;
+        return frame;
     }
 
     public Connection getConnection() {
-        return this.conn;
+        return conn;
     }
 
     public List<String> getPathList() {
-        return this.pathList;
+        return pathList;
     }
 
     public List<String> getIncludeObjectList() {
-        if ((this.includeObjectList == null)) {
+        if ((includeObjectList == null)) {
             return new ArrayList<String>();
         } else {
-            return this.includeObjectList;
+            return includeObjectList;
         }
     }
 
@@ -163,7 +163,7 @@ public void setExcludeObjects(final String excludeObjects) {
 
     public Thread runAsync() {
         final Thread thread = new Thread(() -> {
-            this.run();
+            run();
         });
         thread.setName("code coverage reporter");
         thread.start();
