throw new runtime exceptions with specific messages

PhilippSalvisberg · PhilippSalvisberg · commit 789ebeb2d480 · 2020-05-25T11:27:16.000+02:00
diff --git a/sqldev/src/main/java/org/utplsql/sqldev/coverage/CodeCoverageReporter.java b/sqldev/src/main/java/org/utplsql/sqldev/coverage/CodeCoverageReporter.java
@@ -28,6 +28,8 @@
 import java.util.logging.Logger;
 
 import org.utplsql.sqldev.dal.UtplsqlDao;
+import org.utplsql.sqldev.exception.GenericDatabaseAccessException;
+import org.utplsql.sqldev.exception.GenericRuntimeException;
 import org.utplsql.sqldev.ui.coverage.CodeCoverageReporterDialog;
 
 import oracle.dbtools.raptor.utils.Connections;
@@ -63,18 +65,20 @@ private void setConnection(final String connectionName) {
         if (connectionName == null) {
             final String msg = "Cannot initialize a CodeCoverageReporter without a ConnectionName";
             logger.severe(() -> msg);
-            throw new RuntimeException(msg);
+            throw new NullPointerException();
         } else {
             try {
                 // must be closed manually
                 conn = Connections.getInstance()
                         .cloneConnection(Connections.getInstance().getConnection(connectionName));
             } catch (ConnectionException e) {
-                logger.severe(() -> "ConnectionException while setting connection: " + e.getMessage());
-                throw new RuntimeException(e);
+                final String msg = "ConnectionException while setting connection: " + e.getMessage();
+                logger.severe(() -> msg);
+                throw new GenericDatabaseAccessException(msg, e);
             } catch (DBException e) {
-                logger.severe(() -> "DBException while setting connection: " + e.getMessage());
-                throw new RuntimeException(e);
+                final String msg = "DBException while setting connection: " + e.getMessage();
+                logger.severe(() -> msg);
+                throw new GenericDatabaseAccessException(msg, e);
             }
         }
     }
@@ -111,8 +115,9 @@ private void run() {
                         () -> "Could not launch " + file + "in browser. No default browser defined on this system.");
             }
         } catch (Exception e) {
-            logger.severe(() -> "Error while running code coverage: " + e.getMessage());
-            throw new RuntimeException(e);
+            final String msg = "Error while running code coverage: " + e.getMessage();
+            logger.severe(() -> msg);
+            throw new GenericRuntimeException(msg, e);
         } finally {
             try {
                 conn.close();
diff --git a/sqldev/src/main/java/org/utplsql/sqldev/dal/RealtimeReporterDao.java b/sqldev/src/main/java/org/utplsql/sqldev/dal/RealtimeReporterDao.java
@@ -35,6 +35,7 @@
 import org.springframework.jdbc.core.CallableStatementCallback;
 import org.springframework.jdbc.core.JdbcTemplate;
 import org.springframework.jdbc.datasource.SingleConnectionDataSource;
+import org.utplsql.sqldev.exception.GenericRuntimeException;
 import org.utplsql.sqldev.model.XMLTools;
 import org.utplsql.sqldev.model.runner.Counter;
 import org.utplsql.sqldev.model.runner.Expectation;
@@ -166,14 +167,17 @@ private RealtimeReporterEvent convert(final String itemType, final String text)
             }
             return event;
         } catch (ParserConfigurationException e) {
-            logger.severe(() -> "cannot create docBuilder, due to " + e.getMessage());
-            throw new RuntimeException(e);
+            final String msg = "cannot create docBuilder, due to " + e.getMessage();
+            logger.severe(() -> msg);
+            throw new GenericRuntimeException(msg, e);
         } catch (SAXException e) {
-            logger.severe(() -> "parse error while processing event: " + e.getMessage());
-            throw new RuntimeException(e);
+            final String msg = "parse error while processing event: " + e.getMessage();
+            logger.severe(() -> msg);
+            throw new GenericRuntimeException(msg, e);
         } catch (IOException e) {
-            logger.severe(() -> "I/O error while processing event: " + e.getMessage());
-            throw new RuntimeException(e);
+            final String msg = "I/O error while processing event: " + e.getMessage();
+            logger.severe(() -> msg);
+            throw new GenericRuntimeException(msg, e);
         }
     }
 
