simplify, return result as early as possible

PhilippSalvisberg · PhilippSalvisberg · commit 330d1d3747aa · 2020-05-25T11:27:17.000+02:00
diff --git a/sqldev/src/main/java/org/utplsql/sqldev/model/PrefixTools.java b/sqldev/src/main/java/org/utplsql/sqldev/model/PrefixTools.java
@@ -78,8 +78,7 @@ public static String commonPrefix(final List<String> list) {
                 }
             } else {
                 final String[] testArray = new String[list.size()];
-                final String prefix = commonPrefix(list.toArray(testArray), list.size());
-                return prefix;
+                return commonPrefix(list.toArray(testArray), list.size());
             }
 
         } catch (final Exception e) {

Original file line number	Diff line number	Diff line change
`@@ -78,8 +78,7 @@ public static String commonPrefix(final List<String> list) {`
`78`	`78`	`}`
`79`	`79`	`} else {`
`80`	`80`	`final String[] testArray = new String[list.size()];`
`81`		`- final String prefix = commonPrefix(list.toArray(testArray), list.size());`
`82`		`- return prefix;`
	`81`	`+ return commonPrefix(list.toArray(testArray), list.size());`
`83`	`82`	`}`
`84`	`83`
`85`	`84`	`} catch (final Exception e) {`