Reverting rollback changes - they should go as a separate PR.

jgebal · jgebal · commit f3421958d1cf · 2018-11-17T21:11:56.000Z
diff --git a/development/releasing.md b/development/releasing.md
@@ -9,7 +9,8 @@ To create a release:
    - wait for th build to complete successfully
    - merge the release branch to master and wait for master build to complete successfully
    - create a release from the master branch using [github releases page](https://github.com/utPLSQL/utPLSQL/releases) and populate release description using information found on the issues and pull requests since previous release.
-   To find issues closed after certain date use [advanced filters](https://help.github.com/articles/searching-issues-and-pull-requests/#search-by-open-or-closed-state) 
+   To find issues closed after certain date use [advanced filters](https://help.github.com/articles/searching-issues-and-pull-requests/#search-by-open-or-closed-state). 
+   Example: [`is:issue closed:>2018-07-22`](https://github.com/utPLSQL/utPLSQL/issues?utf8=%E2%9C%93&q=is%3Aissue+closed%3A%3E2018-07-22+) 
 
 The following will happen:
    - build executed on branch `release/vX.Y.Z-[something]` updates files `sonar-project.properties`, `VERSION` with project version derived from the release branch name
diff --git a/source/api/ut_runner.pkb b/source/api/ut_runner.pkb
@@ -83,8 +83,7 @@ create or replace package body ut_runner is
     a_include_objects ut_varchar2_list := null,
     a_exclude_objects ut_varchar2_list := null,
     a_fail_on_errors boolean := false,
-    a_client_character_set varchar2 := null,
-    a_perform_rollback boolean := true
+    a_client_character_set varchar2 := null
   ) is
     l_run                   ut_run;
     l_coverage_schema_names ut_varchar2_rows;
@@ -142,17 +141,13 @@ create or replace package body ut_runner is
       l_run.do_execute();
 
       finish_run(l_run);
-      if a_perform_rollback then
-        rollback;
-      end if;
+      rollback;
     exception
       when others then
         finish_run(l_run);
         dbms_output.put_line(dbms_utility.format_error_backtrace);
         dbms_output.put_line(dbms_utility.format_error_stack);
-        if a_perform_rollback then
-          rollback;
-        end if;
+        rollback;
         raise;
     end;
     if a_fail_on_errors and l_run.result in (ut_utils.gc_failure, ut_utils.gc_error) then
diff --git a/source/api/ut_runner.pks b/source/api/ut_runner.pks
@@ -44,8 +44,6 @@ create or replace package ut_runner authid current_user is
   * @param a_exclude_objects        list of database objects (in format 'owner.name') that coverage should be skipped for
   * @param a_fail_on_errors         true/false - should an exception be thrown when tests are completed with failures/errors
   * @param a_client_character_set   if provided, affects some of reporters by setting specific character set for XML/HTML reports
-  * @param a_perform_rollback       true/false - should rollback be performed as part of test execution (default true)
-
   *
   * @example
   * Parameter `a_paths` accepts values of the following formats:
@@ -68,8 +66,7 @@ create or replace package ut_runner authid current_user is
     a_include_objects ut_varchar2_list := null,
     a_exclude_objects ut_varchar2_list := null,
     a_fail_on_errors boolean := false,
-    a_client_character_set varchar2 := null,
-    a_perform_rollback boolean := true
+    a_client_character_set varchar2 := null
   );
 
   /**
diff --git a/source/api/ut_suite_item_info.tps b/source/api/ut_suite_item_info.tps
@@ -15,13 +15,13 @@ create or replace type ut_suite_item_info as object (
   See the License for the specific language governing permissions and
   limitations under the License.
   */
-  object_owner     varchar2(250),
-  object_name      varchar2(250),
-  item_name        varchar2(250),
-  item_description varchar2(250),
-  item_type        varchar2(250),
-  item_line_no     integer,
-  path             varchar2(4000),
-  disabled_flag    integer
+  object_owner     varchar2( 250 ), -- the owner of test suite packages
+  object_name      varchar2( 250 ), -- the name of test suite package
+  item_name        varchar2( 250 ), -- the name of suite/test
+  item_description varchar2( 250 ), -- the description of suite/suite item
+  item_type        varchar2( 250 ), -- the type of item (UT_SUITE/UT_SUITE_CONTEXT/UT_TEST)
+  item_line_no     integer,         -- line_number where annotation identifying the item exists
+  path             varchar2( 4000 ),-- suitepath of the item
+  disabled_flag    integer          -- 0 (zero) if item is not disabled, 1 if item is disabled by --%disabled annotation
 )
 /
diff --git a/test/api/test_ut_runner.pkb b/test/api/test_ut_runner.pkb
@@ -81,13 +81,16 @@ end;';
 
   procedure keep_an_open_transaction is
     l_expected    varchar2(300);
+    l_output_data dbms_output.chararr;
+    l_num_lines   integer := 100000;
   begin
     --Arrange
     create_test_spec();
     create_test_body(0);
     l_expected := dbms_transaction.local_transaction_id(true);
     --Act
-    ut3.ut_runner.run(ut3.ut_varchar2_list('test_cache'),null, a_perform_rollback => false);
+    ut3.ut.run('test_cache');
+    dbms_output.get_lines( l_output_data, l_num_lines);
     --Assert
     ut.expect(dbms_transaction.local_transaction_id()).to_equal(l_expected);
     drop_test_package();
@@ -102,7 +105,7 @@ end;';
     create_test_body(0);
     rollback;
     --Act
-    ut3.ut_runner.run(ut3.ut_varchar2_list('test_cache'),null);
+    ut3.ut.run('test_cache');
     dbms_output.get_lines( l_output_data, l_num_lines);
     --Assert
     ut.expect(dbms_transaction.local_transaction_id()).to_be_null();
