Skip to content

Commit d9fc007

Browse files
jgebaljgebal
authored
Merge pull request #1058 from utPLSQL/feature/fixing_flaky_tests
Fixed flaky tests
2 parents 5532191 + 4d865ae commit d9fc007

File tree

1 file changed

+15
-17
lines changed

1 file changed

+15
-17
lines changed

‎test/ut3_user/expectations/test_expectations_cursor.pkb‎

Lines changed: 15 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -419,13 +419,12 @@ create or replace package body test_expectations_cursor is
419419
as
420420
l_expected sys_refcursor;
421421
l_actual sys_refcursor;
422-
l_date date := sysdate;
423-
l_second number := 1/24/60/60;
422+
c_second constant number := 1/24/60/60;
424423
begin
425424
--Arrange
426425
ut3.ut.set_nls;
427-
open l_actual for select l_date as some_date from dual;
428-
open l_expected for select l_date-l_second some_date from dual;
426+
open l_actual for select gc_date as some_date from dual;
427+
open l_expected for select gc_date - c_second some_date from dual;
429428
--Act
430429
ut3.ut.expect( l_actual ).to_equal( l_expected );
431430
--Assert
@@ -439,8 +438,8 @@ create or replace package body test_expectations_cursor is
439438
l_expected sys_refcursor;
440439
begin
441440
--Arrange
442-
open l_actual for select sysdate as some_date from dual;
443-
open l_expected for select to_date(to_char(sysdate)) as some_date from dual;
441+
open l_actual for select gc_date as some_date from dual;
442+
open l_expected for select to_date(to_char(gc_date)) as some_date from dual;
444443
--Act
445444
ut3.ut.expect(l_actual).to_equal(l_expected);
446445
--Assert
@@ -1970,10 +1969,10 @@ Diff:%
19701969
l_actual_tab some_object;
19711970
l_expected_tab some_object;
19721971
begin
1973-
select some_object( user,'TEST', sysdate, some_items( some_item(1,'test'), some_item(2,'test') ) )
1972+
select some_object( user,'TEST', gc_date, some_items( some_item(1,'test'), some_item(2,'test') ) )
19741973
into l_actual_tab from dual;
19751974

1976-
select some_object( user,'TEST', sysdate, some_items( some_item(1,'test'), some_item(2,'test') ) )
1975+
select some_object( user,'TEST', gc_date, some_items( some_item(1,'test'), some_item(2,'test') ) )
19771976
into l_expected_tab from dual;
19781977

19791978
--Arrange
@@ -1994,10 +1993,10 @@ Diff:%
19941993
l_actual_tab some_object;
19951994
l_expected_tab some_object;
19961995
begin
1997-
select some_object( user,'TEST', sysdate, some_items( some_item(1,'test'), some_item(2,'test') ) )
1996+
select some_object( user,'TEST', gc_date, some_items( some_item(1,'test'), some_item(2,'test') ) )
19981997
into l_actual_tab from dual;
19991998

2000-
select some_object( user,'TEST', sysdate, some_items( some_item(1,'test'), some_item(2,'test') ) )
1999+
select some_object( user,'TEST', gc_date, some_items( some_item(1,'test'), some_item(2,'test') ) )
20012000
into l_expected_tab from dual;
20022001

20032002
--Arrange
@@ -2018,10 +2017,10 @@ Diff:%
20182017
l_actual_tab some_object;
20192018
l_expected_tab some_object;
20202019
begin
2021-
select some_object( user,'TEST', sysdate, some_items( some_item(1,'test'), some_item(2,'test') ) )
2020+
select some_object( user,'TEST', gc_date, some_items( some_item(1,'test'), some_item(2,'test') ) )
20222021
into l_actual_tab from dual;
20232022

2024-
select some_object( user,'TEST', sysdate, some_items( some_item(1,'test'), some_item(2,'test') ) )
2023+
select some_object( user,'TEST', gc_date, some_items( some_item(1,'test'), some_item(2,'test') ) )
20252024
into l_expected_tab from dual;
20262025

20272026
--Arrange
@@ -2043,12 +2042,11 @@ Diff:%
20432042
l_expected_tab some_object;
20442043
l_expected_message varchar2(32767);
20452044
l_actual_message varchar2(32767);
2046-
l_date date := sysdate;
20472045
begin
2048-
select some_object( 'TEST','TEST', l_date, some_items( some_item(1,'BAD'), some_item(2,'test') ) )
2046+
select some_object( 'TEST','TEST', gc_date, some_items( some_item(1,'BAD'), some_item(2,'test') ) )
20492047
into l_actual_tab from dual;
20502048

2051-
select some_object( 'TEST','TEST', l_date, some_items( some_item(1,'TEST'), some_item(2,'test') ) )
2049+
select some_object( 'TEST','TEST', gc_date, some_items( some_item(1,'TEST'), some_item(2,'test') ) )
20522050
into l_expected_tab from dual;
20532051

20542052
--Arrange
@@ -2080,10 +2078,10 @@ Diff:%
20802078
l_expected_message varchar2(32767);
20812079
l_actual_message varchar2(32767);
20822080
begin
2083-
select some_object( 'TEST','TEST', sysdate, some_items( some_item(1,'BAD'), some_item(2,'test') ) )
2081+
select some_object( 'TEST','TEST', gc_date, some_items( some_item(1,'BAD'), some_item(2,'test') ) )
20842082
into l_actual_tab from dual;
20852083

2086-
select some_object( 'TEST','TEST', sysdate, some_items( some_item(1,'TEST'), some_item(2,'test') ) )
2084+
select some_object( 'TEST','TEST', gc_date, some_items( some_item(1,'TEST'), some_item(2,'test') ) )
20872085
into l_expected_tab from dual;
20882086

20892087
--Arrange

0 commit comments

Comments
 (0)