Added a hash of owner to the generated savepoint name.

jgebal · jgebal · commit 4bb7a951ef5b · 2019-11-30T16:55:24.000Z
Resolves #982
diff --git a/source/core/coverage/proftab.sql b/source/core/coverage/proftab.sql
@@ -37,7 +37,7 @@ begin
   if l_tab_exist = 0 then
     execute immediate q'[create table plsql_profiler_units
 (
-  runid              number(18) references plsql_profiler_runs,
+  runid              number references plsql_profiler_runs,
   unit_number        number,           -- internally generated library unit #
   unit_type          varchar2(128),     -- library unit type
   unit_owner         varchar2(128),     -- library unit owner name
diff --git a/source/core/ut_savepoint_seq.sql b/source/core/ut_savepoint_seq.sql
@@ -0,0 +1,15 @@
+create sequence ut_savepoint_seq
+  /*
+  utPLSQL - Version 3
+  Copyright 2016 - 2019 utPLSQL Project
+  Licensed under the Apache License, Version 2.0 (the "License"):
+  you may not use this file except in compliance with the License.
+  You may obtain a copy of the License at
+      http://www.apache.org/licenses/LICENSE-2.0
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+  */
+  start with 1 cache 20 minvalue 1 maxvalue 99999999999999999 cycle;
diff --git a/source/core/ut_utils.pkb b/source/core/ut_utils.pkb
@@ -22,6 +22,7 @@ create or replace package body ut_utils is
   gc_invalid_first_xml_char  constant varchar2(50)  := '[^_a-zA-Z]';
   gc_invalid_xml_char        constant varchar2(50)  := '[^_a-zA-Z0-9\.-]';
   gc_full_valid_xml_name     constant varchar2(50)  := '^([_a-zA-Z])([_a-zA-Z0-9\.-])*$';
+  gc_owner_hash              constant integer(11)   := dbms_utility.get_hash_value( ut_owner(), 0, power(2,31)-1);
 
   function surround_with(a_value varchar2, a_quote_char varchar2) return varchar2 is
   begin
@@ -59,7 +60,7 @@ create or replace package body ut_utils is
 
   function gen_savepoint_name return varchar2 is
   begin
-    return 's'||to_char(systimestamp,'yyyymmddhh24missff9');
+    return 's'||gc_owner_hash||trim(to_char(ut_savepoint_seq.nextval,'00000000000000000'));
   end;
 
   procedure debug_log(a_message varchar2) is
diff --git a/source/install.sql b/source/install.sql
@@ -59,6 +59,7 @@ end;
 @@install_component.sql 'core/types/ut_reporters_info.tps'
 @@install_component.sql 'core/ut_utils.pks'
 @@install_component.sql 'core/ut_metadata.pks'
+@@install_component.sql 'core/ut_savepoint_seq.sql'
 @@install_component.sql 'core/ut_utils.pkb'
 @@install_component.sql 'core/ut_metadata.pkb'
 @@install_component.sql 'reporters/ut_ansiconsole_helper.pks'
diff --git a/source/uninstall_objects.sql b/source/uninstall_objects.sql
@@ -243,6 +243,8 @@ end;
 
 drop package ut_utils;
 
+drop sequence ut_savepoint_seq;
+
 drop type ut_documentation_reporter force;
 
 drop type ut_debug_reporter force;

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ begin`
`37`	`37`	`if l_tab_exist = 0 then`
`38`	`38`	`execute immediate q'[create table plsql_profiler_units`
`39`	`39`	`(`
`40`		`- runid number(18) references plsql_profiler_runs,`
	`40`	`+ runid number references plsql_profiler_runs,`
`41`	`41`	`unit_number number, -- internally generated library unit #`
`42`	`42`	`unit_type varchar2(128), -- library unit type`
`43`	`43`	`unit_owner varchar2(128), -- library unit owner name`