Skip to content

Commit 62e8d8f

Browse files
committed
Build/Test Tools: Use list format when defining environment variables in Docker compose file.
This is the correct formatting detailed in the Docker `compose` documentation examples and helps to avoid ambiguities in the yaml parser when values that may cause warnings. Props pbrearne, ocean90, johnbillion, desrosj. Fixes #53820. git-svn-id: https://develop.svn.wordpress.org/trunk@51673 602fd350-edb4-49c9-b593-d223f7449a82
1 parent ebe147c commit 62e8d8f

1 file changed

Lines changed: 16 additions & 16 deletions

File tree

docker-compose.yml

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,10 @@ services:
3737
- wpdevnet
3838

3939
environment:
40-
LOCAL_PHP_XDEBUG: ${LOCAL_PHP_XDEBUG-false}
41-
LOCAL_PHP_MEMCACHED: ${LOCAL_PHP_MEMCACHED-false}
42-
PHP_FPM_UID: ${PHP_FPM_UID-1000}
43-
PHP_FPM_GID: ${PHP_FPM_GID-1000}
40+
- LOCAL_PHP_XDEBUG=${LOCAL_PHP_XDEBUG-false}
41+
- LOCAL_PHP_MEMCACHED=${LOCAL_PHP_MEMCACHED-false}
42+
- PHP_FPM_UID=${PHP_FPM_UID-1000}
43+
- PHP_FPM_GID=${PHP_FPM_GID-1000}
4444

4545
volumes:
4646
- ./tools/local-env/php-config.ini:/usr/local/etc/php/conf.d/php-config.ini
@@ -81,10 +81,10 @@ services:
8181
- wpdevnet
8282

8383
environment:
84-
LOCAL_PHP_XDEBUG: ${LOCAL_PHP_XDEBUG-false}
85-
LOCAL_PHP_MEMCACHED: ${LOCAL_PHP_MEMCACHED-false}
86-
PHP_FPM_UID: ${PHP_FPM_UID-1000}
87-
PHP_FPM_GID: ${PHP_FPM_GID-1000}
84+
- LOCAL_PHP_XDEBUG=${LOCAL_PHP_XDEBUG-false}
85+
- LOCAL_PHP_MEMCACHED=${LOCAL_PHP_MEMCACHED-false}
86+
- PHP_FPM_UID=${PHP_FPM_UID-1000}
87+
- PHP_FPM_GID=${PHP_FPM_GID-1000}
8888

8989
volumes:
9090
- ./:/var/www
@@ -102,14 +102,14 @@ services:
102102
- wpdevnet
103103

104104
environment:
105-
LOCAL_PHP_XDEBUG: ${LOCAL_PHP_XDEBUG-false}
106-
LOCAL_PHP_MEMCACHED: ${LOCAL_PHP_MEMCACHED-false}
107-
LOCAL_DIR: ${LOCAL_DIR-src}
108-
WP_MULTISITE: ${WP_MULTISITE-false}
109-
PHP_FPM_UID: ${PHP_FPM_UID-1000}
110-
PHP_FPM_GID: ${PHP_FPM_GID-1000}
111-
GITHUB_REF: ${GITHUB_REF-false}
112-
GITHUB_EVENT_NAME: ${GITHUB_EVENT_NAME-false}
105+
- LOCAL_PHP_XDEBUG=${LOCAL_PHP_XDEBUG-false}
106+
- LOCAL_PHP_MEMCACHED=${LOCAL_PHP_MEMCACHED-false}
107+
- PHP_FPM_UID=${PHP_FPM_UID-1000}
108+
- PHP_FPM_GID=${PHP_FPM_GID-1000}
109+
- LOCAL_DIR=${LOCAL_DIR-src}
110+
- WP_MULTISITE=${WP_MULTISITE-false}
111+
- GITHUB_REF=${GITHUB_REF-false}
112+
- GITHUB_EVENT_NAME=${GITHUB_EVENT_NAME-false}
113113

114114
volumes:
115115
- ./tools/local-env/phpunit-config.ini:/usr/local/etc/php/conf.d/phpunit-config.ini

0 commit comments

Comments
 (0)