Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: unruly/java-config-fallback
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: secrets-manager-adapter
Choose a base ref
...
head repository: unruly/java-config-fallback
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 10 commits
  • 5 files changed
  • 5 contributors

Commits on Sep 18, 2018

  1. docs(README): Bring README up to date 

    * Add Secrets Manager adapter documentation
* Make failure scenarios and fallback behaviour clear and explicit
* Add Contribution guidelines
* Add Maven Central badge

Co-authored-by: Ina Tsetsova <inatsetsova@gmail.com>
Co-authored-by: Alex Wilson <a.wilson@alumni.warwick.ac.uk>
    Shift @tsetsova @mrwilson
    3 people committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    f77a202 View commit details
    Browse the repository at this point in the history

  2. docs(README): Reflect correct return type in code examples 

    * Make custom configuration sources section header slightly neater

Co-authored-by: Ina Tsetsova <inatsetsova@gmail.com>
Co-authored-by: Alex Wilson <a.wilson@alumni.warwick.ac.uk>
    Shift @tsetsova @mrwilson
    3 people committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    f3a133b View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2018

  1. feat(system-properties-adapter): Create ConfigurationSource for syste… 

    …m properties

* This is similar to the existing environment() ConfigurationSource but exposes properties available through System.getProperty()

Co-authored-by: Sarah Young <sarahseewhy@gmail.com>
Co-authored-by: Alex Wilson <a.wilson@alumni.warwick.ac.uk>
    Shift @sarahseewhy @mrwilson
    3 people committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    82b9adc View commit details
    Browse the repository at this point in the history

  2. docs(system-properties-adapter): Add documentation for systemProperti… 

    …es()

* Add examples for systemProperties to demonstrate both user-specified and system default properties
* Rename test and add comment to explicitly capture why the test exists.

Co-authored-by: Sarah Young <sarahseewhy@gmail.com>
Co-authored-by: Alex Wilson <a.wilson@alumni.warwick.ac.uk>
    Shift @sarahseewhy @mrwilson
    3 people committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    cf741ca View commit details
    Browse the repository at this point in the history

  3. [maven-release-plugin] prepare release java-config-fallback-1.0.0

    ShiftDevelopers
    ShiftDevelopers committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    08ae4bc View commit details
    Browse the repository at this point in the history

  4. [maven-release-plugin] prepare for next development iteration

    ShiftDevelopers
    ShiftDevelopers committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    a08809f View commit details
    Browse the repository at this point in the history

  5. docs(README): Reflect release version in README 

    Co-authored-by: Sarah Young <sarahseewhy@gmail.com>
Co-authored-by: Alex Wilson <a.wilson@alumni.warwick.ac.uk>
    Shift @sarahseewhy @mrwilson
    3 people committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    7bdaf75 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2018

  1. docs: move password to secretsManager in example 

    Secrets Manager is made to store secrets like passwords,
so it makes more sense to show it there in the example
snippet.
    @jahed @mrwilson
    jahed authored and mrwilson committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    b88cc54 View commit details
    Browse the repository at this point in the history

  2. docs: clarify how secretsManager makes requests to AWS

    @jahed @mrwilson
    jahed authored and mrwilson committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    c2ba476 View commit details
    Browse the repository at this point in the history

  3. fix: create AWS client on demand to avoid side effects in constructor 

    AWSSecretsManagerClient prints debug logs when it's initialised which
may be triggered before logging preferences are processed in a static
context.

Fixes #8
    @jahed @mrwilson
    jahed authored and mrwilson committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    1e7e732 View commit details
    Browse the repository at this point in the history
Loading