fix Linux file open picker with space#22978
Merged
ajpinedam merged 2 commits intounoplatform:masterfrom Apr 9, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Linux (Skia X11) file picker/save picker results so that paths returned from xdg-desktop-portal file URIs are properly decoded (e.g., %20 → space), preventing failures when opening selected files.
Changes:
- Decode portal-returned
file://URIs usingUri.LocalPath(instead ofAbsolutePath) in the X11 open/save picker implementations. - Add a runtime test verifying that a
StorageFileopened from a path containing spaces returns the expected content.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Uno.UI.RuntimeTests/Tests/Windows_Storage/Given_StorageFile.cs | Adds a regression test for opening a file whose path contains spaces. |
| src/Uno.UI.Runtime.Skia.X11/Storage/Pickers/LinuxFileSaverExtension.cs | Switches URI-to-path conversion to LocalPath to properly decode %20. |
| src/Uno.UI.Runtime.Skia.X11/Storage/Pickers/LinuxFilePickerExtension.cs | Switches URI-to-path conversion to LocalPath for multi/single selection results. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22978/wasm-skia-net9/index.html |
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22978/wasm-skia-net9/index.html |
Contributor
|
The build 205991 found UI Test snapshots differences: Details
|
Contributor
|
|
Contributor
|
The build 205991 found UI Test snapshots differences: Details
|
spouliot
approved these changes
Apr 8, 2026
Contributor
|
The build 205991 found UI Test snapshots differences: Details
|
3b0719f to
e6133e8
Compare
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22978/wasm-skia-net9/index.html |
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue: closes #22751
PR Type:
What is the current behavior? 🤔
What is the new behavior? 🚀
PR Checklist ✅
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information ℹ️