Skip to content

feat: frontline metrics struct DI + metric improvements#5661

Closed
Flo4604 wants to merge 1 commit into04-08-internal_metrics_struct_difrom
04-08-frontline_metrics_struct_di
Closed

feat: frontline metrics struct DI + metric improvements#5661
Flo4604 wants to merge 1 commit into04-08-internal_metrics_struct_difrom
04-08-frontline_metrics_struct_di

Conversation

@Flo4604
Copy link
Copy Markdown
Member

@Flo4604 Flo4604 commented Apr 8, 2026

What does this PR do?

Fixes # (issue)

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps us understand why this PR exists

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Ran make fmt on /go directory
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 8, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dashboard Ready Ready Preview, Comment Apr 9, 2026 3:09pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 8, 2026 •
edited
Loading

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7bb00a81-cc42-45c6-9ca6-051c4b695d40

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 04-08-frontline_metrics_struct_di

Comment @coderabbitai help to get the list of available commands and usage tips.

This was referenced Apr 8, 2026
Closed
Closed
@Flo4604 Graphite App
Copy link
Copy Markdown
Member Author

Flo4604 commented Apr 8, 2026 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Apr 8, 2026
Closed
Closed
Closed
@Flo4604 Flo4604 force-pushed the 04-08-frontline_metrics_struct_di branch from 080ea4e to f85e1f5 Compare April 8, 2026 14:37
@Flo4604 Flo4604 force-pushed the 04-08-internal_metrics_struct_di branch from f419fb4 to 0f14ec9 Compare April 8, 2026 14:37
@Flo4604 Flo4604 force-pushed the 04-08-internal_metrics_struct_di branch from 0f14ec9 to b73ff0b Compare April 8, 2026 15:03
@Flo4604 Flo4604 force-pushed the 04-08-frontline_metrics_struct_di branch from f85e1f5 to 55b5554 Compare April 8, 2026 15:03
@Flo4604 Flo4604 force-pushed the 04-08-frontline_metrics_struct_di branch from 55b5554 to a27aae0 Compare April 8, 2026 20:04
@Flo4604 Flo4604 force-pushed the 04-08-internal_metrics_struct_di branch from b73ff0b to 2dda8fc Compare April 8, 2026 20:04
@Flo4604 Flo4604 force-pushed the 04-08-internal_metrics_struct_di branch from 2dda8fc to 6648cb8 Compare April 9, 2026 09:16
@Flo4604 Flo4604 force-pushed the 04-08-frontline_metrics_struct_di branch from a27aae0 to 1787f16 Compare April 9, 2026 09:16
@Flo4604 Flo4604 force-pushed the 04-08-frontline_metrics_struct_di branch from 1787f16 to d957d85 Compare April 9, 2026 12:46
@Flo4604 Flo4604 force-pushed the 04-08-internal_metrics_struct_di branch from 6648cb8 to 6d7b700 Compare April 9, 2026 12:46
@Flo4604
feat: frontline metrics struct DI + metric improvements
027a442 
Convert frontline proxy, router, and middleware metrics to Metrics
struct DI pattern.

Metric improvements:
- Hops metric now a HistogramVec with src_region/dst_region labels
  for detecting routing anomalies per route pair
- New: forward_errors_total, backend_errors_total, request_errors_total
  convenience counters for simpler alerting
@Flo4604 Flo4604 force-pushed the 04-08-internal_metrics_struct_di branch from 6d7b700 to d69ee96 Compare April 9, 2026 15:04
@Flo4604 Flo4604 force-pushed the 04-08-frontline_metrics_struct_di branch from d957d85 to 027a442 Compare April 9, 2026 15:04
@Flo4604 Flo4604 closed this Apr 9, 2026
@Flo4604 Flo4604 deleted the 04-08-frontline_metrics_struct_di branch April 10, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Flo4604