Skip to content

Add support for swapExactTokensForTokensSupportingFeeOnTransferTokens #40

Closed

Description

@CryptoGnome

There is newer function for tokens that have Fee on Transfer that is causing issues on some transfers, could you please take a look to have a sanctity check [tokenin or tokenout] have this function in the abi to use the correct transfer method to prevent failed TX's

https://uniswap.org/docs/v2/smart-contracts/router02/#swapexacttokensfortokenssupportingfeeontransfertokens
function swapExactTokensForTokensSupportingFeeOnTransferTokens(
uint amountIn,
uint amountOutMin,
address[] calldata path,
address to,
uint deadline
) external;

Thanks for keeping this project alive and well!

Activity

  1. ErikBjare commented on Oct 19, 2020

    @ErikBjare
    Member

    Huh, that's interesting. Could you give an example of such a token? (I guess BOMB would be an example?)

    I probably don't have time to implement a fix, but I'd gladly review a PR if you're up for it. Shouldn't be too hard to fix.

  2. CryptoGnome commented on Oct 19, 2020

    @CryptoGnome
    Author

    CORE , there are tons like it popping up now

  3. changed the title [-]Add support for swapExactTokensForTokensSupportingFeeOnTransferTokens [Enhancement][/-] [+]Add support for swapExactTokensForTokensSupportingFeeOnTransferTokens[/+] on Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions