Skip to content

CI failing (ganache not responding, tx not getting included) #200

Closed

Description

@ErikBjare

Noticed CI was failing.

Every request to ganache after the first make_trade failed (Connection refused). Switched from ganache-cli to the new ganache v0.7.0-alpha, and now I instead get:

========================================================================================================================================================================== ERRORS ==========================================================================================================================================================================
______________________________________________________________________________________ ERROR at setup of TestUniswap.test_make_trade[1-0x0000000000000000000000000000000000000000-0x6B175474E89094C44Da98b954EedeAC495271d0F-1000000000000000000-None-does_not_raise] ______________________________________________________________________________________
E   web3._utils.threads.Timeout: 120 seconds

During handling of the above exception, another exception occurred:
E   web3.exceptions.TimeExhausted: Transaction HexBytes('0xb38da03c8d6a58f0d2987194c51aec29512821e8dc8accfbcacea5572a8ee453') is not in the chain, after 120 seconds

So for some reason, txs aren't being included.

Suspiciously, this first happened in https://github.com/uniswap-python/uniswap-python/runs/4021781576 (#190)

Need to take a look at this before I make a new release.

Activity

  1. ErikBjare commented on Dec 21, 2021

    @ErikBjare
    MemberAuthor

    Fixed most issues, but still getting timeout on a particular estimateGas call. No idea why, but I disabled gas estimation for the tests and will hopefully merge #201 soon.

    Edit: Related to ConsenSys-archive/ganache#985

  2. added
    ciRelating to Continuous Integration
    on Dec 21, 2021
  3. ErikBjare commented on Dec 21, 2021

    @ErikBjare
    MemberAuthor

    Merged, tests working again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ciRelating to Continuous Integration

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions