Skip to content

Swapping between an ERC20 token and ETH leaves the result in WETH #154

Open

Description

@romanbsd

The official uniswap v3 SDK unwraps the result using the unwrapWETH9 contract method.
The current behaviour is unexpected, since the output token is specified as ETH (address 0x0...0).
What's your position on this? I can probably make a patch that uses the multicall to swap and unwrap as I already have the code for it in my project. I think that for very least the uniswap-python should issue a warning log message at the moment.

Activity

  1. nimcon commented on Aug 16, 2021

    @nimcon
    Contributor

    I've run into the same issue. If WETh is specified as input token, ETH is taken from wallet instead. Similarly, if ETH is specified as the output token, WETH is sent to the recipient address.

  2. jhb10c commented on Sep 13, 2021

    @jhb10c
    Contributor

    If this is still open, I can fix this!

  3. romanbsd commented on Sep 14, 2021

    @romanbsd
    ContributorAuthor

    There's a pending PR #159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions