updating StartToCloseTimeout in fileprocessing sample (temporalio#169)

tsurdilo · web-flow · commit 497fcbe6b402 · 2021-10-05T17:19:28.000-04:00
* updating StartToCloseTimeout in fileprocessing sample

Signed-off-by: Tihomir Surdilovic &lt;tihomir@temporal.io&gt;

* typo

Signed-off-by: Tihomir Surdilovic &lt;tihomir@temporal.io&gt;

* add ScheduleToStartTimeout

Signed-off-by: Tihomir Surdilovic &lt;tihomir@temporal.io&gt;

* fixes

Signed-off-by: Tihomir Surdilovic &lt;tihomir@temporal.io&gt;

* add comment

Signed-off-by: Tihomir Surdilovic &lt;tihomir@temporal.io&gt;
diff --git a/src/main/java/io/temporal/samples/fileprocessing/FileProcessingWorkflowImpl.java b/src/main/java/io/temporal/samples/fileprocessing/FileProcessingWorkflowImpl.java
@@ -72,7 +72,20 @@ private void processFileImpl(URL source, URL destination) {
     ActivityOptions hostActivityOptions =
         ActivityOptions.newBuilder()
             .setTaskQueue(downloaded.getHostTaskQueue())
-            .setStartToCloseTimeout(Duration.ofSeconds(10))
+            // Set the amount a time an activity task can stay in the task queue before its picked
+            // up by a Worker. It allows us to support cases where
+            // the activity worker crashes or restarts before the activity starts execution.
+            // This timeout should be specified only when host specific activity task queues are
+            // used like in this sample.
+            // Note that scheduleToStart timeout is not retryable and retry options will ignore it.
+            // This timeout has to be handled by Workflow code.
+            .setScheduleToStartTimeout(Duration.ofSeconds(10))
+            // Set the max time of a single activity execution attempt.
+            // Activity is going to be executed by a Worker listening to the specified
+            // host task queue. If the activity is started but then the activity worker crashes
+            // for some reason, we want to make sure that it is retried after the specified timeout.
+            // This timeout should be be as short as the longest possible execution of the Activity.
+            .setStartToCloseTimeout(Duration.ofSeconds(2))
             .setRetryOptions(
                 RetryOptions.newBuilder()
                     .setInitialInterval(Duration.ofSeconds(1))
diff --git a/src/main/java/io/temporal/samples/hello/HelloCancellationScope.java b/src/main/java/io/temporal/samples/hello/HelloCancellationScope.java
@@ -98,7 +98,8 @@ public static class GreetingWorkflowImpl implements GreetingWorkflow {
 
     private static final int ACTIVITY_MAX_SLEEP_SECONDS = 30;
     private static final int ACTIVITY_MAX_CLEANUP_SECONDS = 5;
-    private static final int ACTIVITY_START_TO_CLOSE_TIMEOUT = ACTIVITY_MAX_SLEEP_SECONDS + ACTIVITY_MAX_CLEANUP_SECONDS + 10;
+    private static final int ACTIVITY_START_TO_CLOSE_TIMEOUT =
+        ACTIVITY_MAX_SLEEP_SECONDS + ACTIVITY_MAX_CLEANUP_SECONDS + 10;
 
     private static final String[] greetings =
         new String[] {"Hello", "Bye", "Hola", "Привет", "Oi", "Hallo"};
