Skip to content
This repository was archived by the owner on Sep 1, 2024. It is now read-only.

Commit 0f24a24

Browse files
committed
[cypress] Use Microsoft Edge for Windows integration tests
Chrome is slow on Windows, and Electron fails randomly with opaque errors.
1 parent 9bc5c47 commit 0f24a24

2 files changed

Lines changed: 9 additions & 3 deletions

File tree

packages/cypress-plugin/test/integration/src/parse-output.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -207,9 +207,12 @@ const parseRunStarting = (
207207

208208
expect(tableEntries["Cypress"]).toMatch(/^[0-9]+\.[0-9]+\.[0-9]+$/);
209209
expect(tableEntries["Browser"]).toMatch(
210-
// Electron is much faster on Windows than Chrome, and only a tiny bit slower on Linux, so we
211-
// just use it for all the integration tests.
212-
/^Electron [0-9]+ \x1B\[90m\(headless\)\x1B\[39m$/
210+
new RegExp(
211+
`^${
212+
// Chrome is slow to launch on Windows.
213+
process.platform === "win32" ? "Edge" : "Chrome"
214+
} [0-9]+ \x1B\\[90m\\(headless\\)\x1B\\[39m$`
215+
)
213216
);
214217
expect(tableEntries["Node Version"]).toMatch(
215218
new RegExp(

packages/cypress-plugin/test/integration/src/run-test-case.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -835,6 +835,9 @@ export const runTestCase = async (
835835
"--",
836836
// e2e/component
837837
`--${params.testMode}`,
838+
// Chrome is faster than Electron, at least on Mac. However, it's much slower on Windows.
839+
"--browser",
840+
process.platform === "win32" ? "edge" : "chrome",
838841
...(params.specNameStubs !== undefined
839842
? [
840843
"--spec",

0 commit comments

Comments
 (0)