adds some initial tests for basic series adds

Brian Luft · Brian Luft · commit f0d9d08d85ab · 2011-01-30T21:45:34.000-08:00
diff --git a/README.rst b/README.rst
@@ -7,7 +7,7 @@ For example::
 
     >>> import pyflot 
     >>> f = pyflot.Flot() 
-    >>> f.add_series([(1,1), (2,2), (3,3)]) 
+    >>> f.add_series([(1, 1), (2, 2), (3, 3)]) 
     >>> print f.series_json 
     [{"data": [[1, 1], [2, 2], [3, 3]]}]
 
diff --git a/pyflot/__init__.py b/pyflot/__init__.py
@@ -2,6 +2,11 @@
 import json
 
 
+class MissingDataException(Exception):
+    """Exception raised when a series does not contain
+    any data points"""
+
+
 class DuplicateLabelException(Exception):
     """Exception raised when an attempt is made to 
     label a new series with a label already in use"""
@@ -57,6 +62,8 @@ def add_series(self, series, label=None, **kwargs):
         """
         A series is a list of pairs (2-tuples)
         """
+        if not series:
+            raise MissingDataException
         new_series = {'data': series}
         if label and label in [x.get('label', None) for x in self._series]:
             raise DuplicateLabelException
diff --git a/tests/__init__.py b/tests/__init__.py
@@ -0,0 +1,51 @@
+import unittest
+
+from pyflot import Flot, MissingDataException, \
+        DuplicateLabelException
+
+
+SERIES = (
+    ((1, 1), (2, 2), (3, 3)),
+)
+S1, = SERIES
+
+class TestFlot(unittest.TestCase):
+
+    def setUp(self):
+        self.flot = Flot()
+
+    def check_add_series(self, raw, label=None):
+        count = len(self.flot._series)
+        self.flot.add_series(raw, label)
+        self.assertEqual(count+1, len(self.flot._series))
+        series = self.flot._series[count]
+        self.assertEqual(raw, series['data'])
+        if label:
+            self.assertEqual(label, series['label'])
+        else:
+            self.assertFalse('label' in series)
+
+    def test_basic_add_series(self):
+        "make sure a series can be added with no label or options"
+        self.check_add_series(S1)
+
+    def test_reject_empty_series(self):
+        """don't accept empty series"""
+        self.assertRaises(MissingDataException, self.flot.add_series, [])
+        self.assertEqual(len(self.flot._series), 0)
+
+    def test_add_series_with_label(self):
+        """make sure a label can be associated with a series"""
+        self.flot.add_series(S1, "as_arg")
+        self.flot._series = []
+        self.flot.add_series(S1, label="as_kwarg")
+
+    def test_reject_duplicate_label(self):
+        "make sure a series is not added if it has a duplicate label"
+        self.check_add_series(S1, "label1")
+        self.assertRaises(DuplicateLabelException, self.flot.add_series, S1, "label1")
+
+    def test_add_multiple_series(self):
+        "make sure multiple series can be added"
+        self.check_add_series(S1)
+        self.check_add_series(S1)
