Fix memory leak parsing large integers

bwoodsend · bwoodsend · commit 4baeb950df78 · 2026-03-11T21:45:16.000Z
diff --git a/src/ujson/python/JSONtoObj.c b/src/ujson/python/JSONtoObj.c
@@ -145,7 +145,9 @@ static JSOBJ Object_newIntegerFromString(void *prv, char *value, size_t length)
   char *buf = PyObject_Malloc(length + 1);
   memcpy(buf, value, length);
   buf[length] = '\0';
-  return PyLong_FromString(buf, NULL, 10);
+  PyObject *ret = PyLong_FromString(buf, NULL, 10);
+  PyObject_Free(buf);
+  return ret;
 }
 
 static JSOBJ Object_newDouble(void *prv, double value)
diff --git a/tests/test_ujson.py b/tests/test_ujson.py
@@ -656,6 +656,20 @@ def test_encode_decode_big_int(i, mode):
             assert ujson.decode(json_string) == python_object
 
 
+@pytest.mark.xfail(
+    sys.implementation.name == "pypy",
+    reason="PyPy's PyNumber_ToBase ignores sys.get_int_max_str_digits()",
+)
+def test_encode_too_big_int_error():
+    with pytest.raises(ValueError, match="integer string conversion"):
+        ujson.dumps(pow(10, 10_000))
+
+
+def test_decode_too_big_int_error():
+    with pytest.raises(ValueError, match="integer string conversion"):
+        ujson.loads("9" * 10_000)
+
+
 @pytest.mark.parametrize(
     "test_input, expected",
     [
