Raise AttributeError for unknown attributes

Jamie Lennox · lin-hua-cheng · commit 47977fcc323b · 2015-03-05T23:40:26.000-08:00
Not returning a value is the same as returning None. In the event that
someone asks ClientManager for an attribute that doesn't exist it should
raise AttributeError in the same way as other python objects rather
than return an empty value.

Change-Id: Id0ee825e6527c831c38e3a671958ded362fb96e1
diff --git a/openstackclient/common/clientmanager.py b/openstackclient/common/clientmanager.py
@@ -54,6 +54,8 @@ def __getattr__(self, name):
                     for o in auth.OPTIONS_LIST]:
             return self._auth_params[name[1:]]
 
+        raise AttributeError(name)
+
     def __init__(
         self,
         cli_options,
diff --git a/openstackclient/identity/client.py b/openstackclient/identity/client.py
@@ -46,7 +46,6 @@ def make_client(instance):
         API_VERSIONS)
     LOG.debug('Instantiating identity client: %s', identity_client)
 
-    LOG.debug('Using auth plugin: %s' % instance._auth_plugin)
     client = identity_client(
         session=instance.session,
         region_name=instance._region_name,
