add language param for AddCommas, add RemoveCommas

martinpopel · martinpopel · commit c8fbca0a38e8 · 2018-04-03T19:19:35.000+02:00
diff --git a/udapi/block/tutorial/addcommas.py b/udapi/block/tutorial/addcommas.py
@@ -1,10 +1,23 @@
 """tutorial.AddCommas block template."""
 from udapi.core.block import Block
 
+# nickname = xy123
+# TODO: make up a unique nickname and edit the previous line
+# if you want your results to be listed on the NPFL070 web (under that nickname).
+# Delete the line if you don't want to listed on the web.
 
 class AddCommas(Block):
     """Heuristically insert nodes for missing commas."""
 
+    def __init__(self, language='en', **kwargs):
+        """Create the AddCommas block object.
+
+        Args:
+        `language`: which language-specific rules to use ('en' or 'cs')
+        """
+        super().__init__(**kwargs)
+        self.language = language
+
     def process_node(self, node):
         if self.should_add_comma_before(node):
             comma = node.create_child(form=',', deprel='punct', upos='PUNCT')
@@ -15,7 +28,7 @@ def should_add_comma_before(self, node):
         prev_node = node.prev_node
         if prev_node is None:
             return False
-        if prev_node.lemma == 'however':
+        if self.language == 'en' and node.lemma == 'however':
             return True
         if any(n.deprel == 'appos' for n in prev_node.children):
             return True
diff --git a/udapi/block/tutorial/removecommas.py b/udapi/block/tutorial/removecommas.py
@@ -0,0 +1,13 @@
+"""tutorial.RemoveCommas helper block."""
+from udapi.core.block import Block
+
+
+class RemoveCommas(Block):
+    """Delete all comma nodes and edit SpaceAfter and text accordingly."""
+
+    def process_tree(self, root):
+        for node in root.descendants:
+            if node.form == ",":
+                node.remove(children="rehang")
+                del node.prev_node.misc['SpaceAfter']
+        root.text = root.compute_text()
