Skip to content

Commit 984a9ea

Browse files
committed
fix bug (prev_node instead of node) introduced in my last commit
1 parent 9a8015c commit 984a9ea

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

udapi/block/tutorial/addcommas.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,25 +10,20 @@ class AddCommas(Block):
1010
"""Heuristically insert nodes for missing commas."""
1111

1212
def __init__(self, language='en', **kwargs):
13-
"""Create the AddCommas block object.
14-
15-
Args:
16-
`language`: which language-specific rules to use ('en' or 'cs')
17-
"""
1813
super().__init__(**kwargs)
1914
self.language = language
2015

2116
def process_node(self, node):
17+
# TODO: Your task: implement some heuristics
2218
if self.should_add_comma_before(node):
2319
comma = node.create_child(form=',', deprel='punct', upos='PUNCT')
2420
comma.shift_before_node(node)
2521

2622
def should_add_comma_before(self, node):
27-
# TODO: Your task: implement some heuristics
2823
prev_node = node.prev_node
2924
if prev_node is None:
3025
return False
31-
if self.language == 'en' and node.lemma == 'however':
26+
if self.language == 'en' and prev_node.lemma == 'however':
3227
return True
3328
if any(n.deprel == 'appos' for n in prev_node.children):
3429
return True

0 commit comments

Comments
 (0)