Skip to content

Commit d655f8f

Browse files
authored
Updates to deploy releases to Central Portal (#1234)
Fixes #1218. I also updated the Shadow plugin to a more recent version, as that often has subtle interactions with releasing. To test, I followed the instructions at https://github.com/vanniktech/gradle-maven-publish-plugin/releases/tag/0.33.0. I successfully uploaded a `SNAPSHOT` release with these changes, but we should cut a normal release after this lands to make sure that works. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated Maven Publish Gradle plugin and Shadow plugin to newer versions. * Switched Shadow plugin provider to improve build configuration. * Updated publishing properties to enable Maven Central publishing. * Adjusted build tasks to use updated Javadoc JAR task names. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent de6b680 commit d655f8f

5 files changed

Lines changed: 9 additions & 9 deletions

File tree

build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,13 @@ buildscript {
2323

2424
dependencies {
2525
classpath 'com.android.tools.build:gradle:7.3.0'
26-
classpath 'com.vanniktech:gradle-maven-publish-plugin:0.25.3'
26+
classpath 'com.vanniktech:gradle-maven-publish-plugin:0.34.0'
2727
}
2828
}
2929
plugins {
3030
id "com.diffplug.spotless" version "6.25.0"
3131
id "net.ltgt.errorprone" version "4.1.0" apply false
32-
id "com.github.johnrengelman.shadow" version "8.1.1" apply false
32+
id "com.gradleup.shadow" version "8.3.8" apply false
3333
id "me.champeau.jmh" version "0.7.1" apply false
3434
id "com.github.ben-manes.versions" version "0.51.0"
3535
id "com.felipefzdz.gradle.shellcheck" version "1.5.0"

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,5 +30,5 @@ POM_DEVELOPER_NAME=Uber Technologies
3030
POM_DEVELOPER_URL=https://uber.com
3131

3232
# Publishing configuration for vanniktech/gradle-maven-publish-plugin
33-
SONATYPE_HOST=DEFAULT
33+
mavenCentralPublishing=true
3434
RELEASE_SIGNING_ENABLED=true

jar-infer/jar-infer-cli/build.gradle

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
plugins {
22
id "java-library"
33
id "com.vanniktech.maven.publish"
4-
id "com.github.johnrengelman.shadow"
4+
id "com.gradleup.shadow"
55
}
66

77
repositories {
@@ -112,12 +112,12 @@ publishing {
112112
// (rather than just signShadowPublication)
113113
project.tasks.named('generateMetadataFileForMavenPublication').configure {
114114
dependsOn 'sourcesJar'
115-
dependsOn 'simpleJavadocJar'
115+
dependsOn 'plainJavadocJar'
116116
}
117117
if (project.tasks.findByName('signShadowPublication')) {
118118
project.tasks.named('signShadowPublication').configure {
119119
dependsOn 'sourcesJar'
120-
dependsOn 'simpleJavadocJar'
120+
dependsOn 'plainJavadocJar'
121121
}
122122
}
123123
project.tasks.named('publishShadowPublicationToMavenCentralRepository').configure {
@@ -127,7 +127,7 @@ publishing {
127127
}
128128
project.tasks.named('publishShadowPublicationToMavenLocal').configure {
129129
dependsOn 'sourcesJar'
130-
dependsOn 'simpleJavadocJar'
130+
dependsOn 'plainJavadocJar'
131131
if (project.tasks.findByName('signMavenPublication')) {
132132
dependsOn 'signMavenPublication'
133133
}

jdk-javac-plugin/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
plugins {
22
id 'java'
33
// we use the shadow jar when building the JDK
4-
id 'com.github.johnrengelman.shadow'
4+
id 'com.gradleup.shadow'
55
id 'nullaway.java-test-conventions'
66
}
77

library-model/library-model-generator-cli/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616
plugins {
1717
id "java-library"
18-
id "com.github.johnrengelman.shadow"
18+
id "com.gradleup.shadow"
1919
}
2020

2121
jar{

0 commit comments

Comments
 (0)