making a random choice from candidates

stamparm · stamparm · commit 54576ab3a61e · 2012-04-13T10:54:30.000Z
diff --git a/lib/controller/checks.py b/lib/controller/checks.py
@@ -8,6 +8,7 @@
 """
 
 import httplib
+import random
 import re
 import socket
 import time
@@ -349,10 +350,10 @@ def genCmpPayload():
                             if not injectable and not conf.string and kb.pageStable:
                                 trueSet = set(extractTextTagContent(truePage))
                                 falseSet = set(extractTextTagContent(falsePage))
-                                candidate = reduce(lambda x, y: x or (y.strip() if y.strip() in (kb.pageTemplate or "") and y.strip() not in falsePage else None), (trueSet - falseSet), None)
-                                if candidate:
-                                    conf.string = candidate
-                                    infoMsg = "%s parameter '%s' seems to be '%s' injectable (with --string=%s)" % (place, parameter, title, repr(candidate).lstrip('u'))
+                                candidates = filter(None, (_.strip() if _.strip() in (kb.pageTemplate or "") and _.strip() not in falsePage else None for _ in (trueSet - falseSet)))
+                                if candidates:
+                                    conf.string = random.sample(candidates, 1)[0]
+                                    infoMsg = "%s parameter '%s' seems to be '%s' injectable (with --string=%s)" % (place, parameter, title, repr(conf.string).lstrip('u'))
                                     logger.info(infoMsg)
 
                                     injectable = True
