Skip to content

Commit b972545

Browse files
author
MB
committed
[AdRoll] Force www, sort, invert, enumerate, squish, add tests, add comments
1 parent 57aaa3a commit b972545

File tree

2 files changed

+58
-10
lines changed

2 files changed

+58
-10
lines changed

‎src/chrome/content/rules/AdRoll.xml‎

Lines changed: 57 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
<!--
2-
Disabled by https-everywhere-checker because:
3-
Fetch error: http://adroll.com/ => https://adroll.com/: (7, 'Failed to connect to adroll.com port 443: Connection refused')
42
For problematic rules, see AdRoll-problematic.xml
53
64
@@ -33,27 +31,76 @@ Fetch error: http://adroll.com/ => https://adroll.com/: (7, 'Failed to connect t
3331
3432
Problematic subdomains:
3533
34+
- ^ ¹
3635
- a (akamai)
3736
- feedback (works, mismatched, CN: userecho.com)
3837
38+
¹ Refused
39+
40+
41+
Fully covered hosts in *adroll.com:
42+
43+
- (www.)? (^ → www)
44+
- a (→ s)
45+
- d
46+
- s
47+
48+
49+
Insecure cookies are set for these domains and hosts:
50+
51+
- .adroll.com
52+
- feedback.adroll.com
53+
3954
4055
s.adroll.com sets __ar_v4 and _te_ wildcard cookies
4156
on whichever domain it is loaded from.
4257
4358
-->
44-
<ruleset name="AdRoll (partial)" default_off='failed ruleset test'>
59+
<ruleset name="AdRoll (partial)">
60+
61+
<!-- Direct rewrites:
62+
-->
63+
<target host="d.adroll.com" />
64+
<target host="s.adroll.com" />
65+
<target host="www.adroll.com" />
4566

67+
<!-- Complications:
68+
-->
4669
<target host="adroll.com" />
47-
<target host="*.adroll.com" />
70+
<target host="a.adroll.com" />
71+
<target host="feedback.adroll.com" />
4872

73+
<exclusion pattern="^http://feedback\.adroll\.com/(?!s/)" />
4974

50-
<rule from="^http://(d\.|www\.)?adroll\.com/"
51-
to="https://$1adroll.com/" />
75+
<!-- +ve:
76+
-->
77+
<test url="http://feedback.adroll.com/topic/683270-visbility-of-segments-across-advertiser-profiles/" />
78+
<test url="http://feedback.adroll.com/users/360899-egg-to-apples/topic/" />
5279

53-
<rule from="^http://[as]\.adroll\.com/"
80+
<!-- -ve:
81+
-->
82+
<test url="http://feedback.adroll.com/s/assets2.0/css/font-awesome.min.css" />
83+
<test url="http://feedback.adroll.com/s/assets2.0/css/plugins/lightbox/img/close.png" />
84+
85+
86+
<!-- Not secured by server:
87+
-->
88+
<!--securecookie host="^\.adroll\.com$" name="^__adroll$" /-->
89+
<!--securecookie host="^feedback\.adroll\.com$" name="^uesessionid$" /-->
90+
91+
<securecookie host="^\.adroll\.com$" name="^__adroll$" />
92+
93+
94+
<rule from="^http://adroll\.com/"
95+
to="https://www.adroll.com/" />
96+
97+
<rule from="^http://a\.adroll\.com/"
5498
to="https://s.adroll.com/" />
5599

56-
<rule from="^http://feedback\.adroll\.com/s/"
57-
to="https://userecho.com/s/" />
100+
<rule from="^http://feedback\.adroll\.com/"
101+
to="https://userecho.com/" />
102+
103+
<rule from="^http:"
104+
to="https:" />
58105

59-
</ruleset>
106+
</ruleset>

‎utils/duplicate-whitelist.txt‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
abcnews.go.com
22
acm.org
3+
feedback.adroll.com
34
addons.videolan.org
45
adyadvantage.com
56
affair-guide.com

0 commit comments

Comments
 (0)