Remove testRulesetRetrievalPerformance.

jsha · jsha · commit 4f90a021eb5c · 2015-08-19T13:19:43.000-07:00
This flags in the AMO validator because of a synchronous network fetch. We may
want to reinstate it later in the specific testing extension.
diff --git a/src/chrome/content/code/HTTPSRules.js b/src/chrome/content/code/HTTPSRules.js
@@ -425,14 +425,6 @@ const HTTPSRules = {
     if (gitCommitQuery.executeStep()) {
       this.GITCommitID = gitCommitQuery.row.git_commit;
     }
-
-    try {
-      if (HTTPSEverywhere.instance.prefs.getBoolPref("performance_tests")) {
-        this.testRulesetRetrievalPerformance();
-      }
-    } catch(e) {
-      this.log(WARN, "Exception during testing " + e);
-    }
     return;
   },
 
@@ -683,36 +675,6 @@ const HTTPSRules = {
     return results;
   },
 
-  testRulesetRetrievalPerformance: function() {
-    // We can use this function to measure the impact of changes in the ruleset
-    // storage architecture, potentiallyApplicableRulesets() caching
-    // implementations, etc. 
-    var req = Cc["@mozilla.org/xmlextras/xmlhttprequest;1"]
-                 .createInstance(Ci.nsIXMLHttpRequest);
-    req.open("GET", "https://www.eff.org/files/alexa-top-10000-global.txt", false);
-    req.send();
-    var domains = req.response.split("\n");
-    var domains_l = domains.length - 1; // The last entry in this thing is bogus
-    var prefix = "";
-    this.log(WARN, "Calling potentiallyApplicableRulesets() with " + domains_l + " domains");
-    var count = 0;
-    var t1 = new Date().getTime();
-    for (var n = 0; n < domains_l; n++) {
-      if (this.potentiallyApplicableRulesets(prefix + domains[n]).length != 0)
-        count++;
-    }
-    var t2 = new Date().getTime();
-    this.log(NOTE, count + " hits: average call to potentiallyApplicableRulesets took " + (t2 - t1) / domains_l + " milliseconds");
-    count = 0;
-    t1 = new Date().getTime();
-    for (var n = 0; n < domains_l; n++) {
-      if (this.potentiallyApplicableRulesets(prefix + domains[n]).length != 0)
-        count++;
-    }
-    t2 = new Date().getTime();
-    this.log(NOTE, count + " hits: average subsequent call to potentiallyApplicableRulesets took " + (t2 - t1) / domains_l + " milliseconds");
-  },
-
   /**
    * If a cookie's domain attribute has a leading dot to indicate it should be
    * sent for all subdomains (".example.com"), return the actual host part (the
diff --git a/translations b/translations
@@ -1 +1 @@
-Subproject commit fc0de706194863e3c8e772a83782dbb9cab04cf1
+Subproject commit f81d74fab705af7493eda23b7e7daff2d64f5b55
