Skip to content

Commit 414f026

Browse files
yoshi-automationbusunkim96
yoshi-automation
authored and
busunkim96
committed
Security Center: remove 'having' filter arguments from query methods (via synth).
1 parent f242cc1 commit 414f026

File tree

4 files changed

+69
-195
lines changed

4 files changed

+69
-195
lines changed

‎securitycenter/google/cloud/securitycenter_v1/gapic/security_center_client.py‎

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -566,7 +566,6 @@ def group_assets(
566566
filter_=None,
567567
compare_duration=None,
568568
read_time=None,
569-
having=None,
570569
page_size=None,
571570
retry=google.api_core.gapic_v1.method.DEFAULT,
572571
timeout=google.api_core.gapic_v1.method.DEFAULT,
@@ -682,9 +681,6 @@ def group_assets(
682681
683682
If a dict is provided, it must be of the same form as the protobuf
684683
message :class:`~google.cloud.securitycenter_v1.types.Timestamp`
685-
having (str): Filter that specifies what fields to further filter on *after* the query
686-
filter has been executed. Currently only 'state\_change' is supported
687-
and requires compare\_duration to be specified.
688684
page_size (int): The maximum number of resources contained in the
689685
underlying API response. If page streaming is performed per-
690686
resource, this parameter does not affect the return value. If page
@@ -729,7 +725,6 @@ def group_assets(
729725
filter=filter_,
730726
compare_duration=compare_duration,
731727
read_time=read_time,
732-
having=having,
733728
page_size=page_size,
734729
)
735730
iterator = google.api_core.page_iterator.GRPCIterator(
@@ -754,7 +749,6 @@ def group_findings(
754749
filter_=None,
755750
read_time=None,
756751
compare_duration=None,
757-
having=None,
758752
page_size=None,
759753
retry=google.api_core.gapic_v1.method.DEFAULT,
760754
timeout=google.api_core.gapic_v1.method.DEFAULT,
@@ -869,10 +863,6 @@ def group_findings(
869863
870864
If a dict is provided, it must be of the same form as the protobuf
871865
message :class:`~google.cloud.securitycenter_v1.types.Duration`
872-
having (str): Filter that specifies what fields to further filter on *after* the query
873-
filter has been executed. Currently only 'finding.state' and
874-
'state\_change' are supported and requires compare\_duration to be
875-
specified.
876866
page_size (int): The maximum number of resources contained in the
877867
underlying API response. If page streaming is performed per-
878868
resource, this parameter does not affect the return value. If page
@@ -917,7 +907,6 @@ def group_findings(
917907
filter=filter_,
918908
read_time=read_time,
919909
compare_duration=compare_duration,
920-
having=having,
921910
page_size=page_size,
922911
)
923912
iterator = google.api_core.page_iterator.GRPCIterator(
@@ -942,7 +931,6 @@ def list_assets(
942931
order_by=None,
943932
read_time=None,
944933
compare_duration=None,
945-
having=None,
946934
field_mask=None,
947935
page_size=None,
948936
retry=google.api_core.gapic_v1.method.DEFAULT,
@@ -1047,9 +1035,6 @@ def list_assets(
10471035
10481036
If a dict is provided, it must be of the same form as the protobuf
10491037
message :class:`~google.cloud.securitycenter_v1.types.Duration`
1050-
having (str): Filter that specifies what fields to further filter on *after* the query
1051-
filter has been executed. Currently only 'state\_change' is supported
1052-
and requires compare\_duration to be specified.
10531038
field_mask (Union[dict, ~google.cloud.securitycenter_v1.types.FieldMask]): Optional.
10541039
10551040
A field mask to specify the ListAssetsResult fields to be listed in the
@@ -1102,7 +1087,6 @@ def list_assets(
11021087
order_by=order_by,
11031088
read_time=read_time,
11041089
compare_duration=compare_duration,
1105-
having=having,
11061090
field_mask=field_mask,
11071091
page_size=page_size,
11081092
)
@@ -1128,7 +1112,6 @@ def list_findings(
11281112
order_by=None,
11291113
read_time=None,
11301114
compare_duration=None,
1131-
having=None,
11321115
field_mask=None,
11331116
page_size=None,
11341117
retry=google.api_core.gapic_v1.method.DEFAULT,
@@ -1234,10 +1217,6 @@ def list_findings(
12341217
12351218
If a dict is provided, it must be of the same form as the protobuf
12361219
message :class:`~google.cloud.securitycenter_v1.types.Duration`
1237-
having (str): Filter that specifies what fields to further filter on *after* the query
1238-
filter has been executed. Currently only 'finding.state' and
1239-
'state\_change' are supported and requires compare\_duration to be
1240-
specified.
12411220
field_mask (Union[dict, ~google.cloud.securitycenter_v1.types.FieldMask]): Optional.
12421221
12431222
A field mask to specify the Finding fields to be listed in the response.
@@ -1289,7 +1268,6 @@ def list_findings(
12891268
order_by=order_by,
12901269
read_time=read_time,
12911270
compare_duration=compare_duration,
1292-
having=having,
12931271
field_mask=field_mask,
12941272
page_size=page_size,
12951273
)

‎securitycenter/google/cloud/securitycenter_v1/proto/securitycenter_service.proto‎

Lines changed: 8 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -331,11 +331,6 @@ message GroupAssetsRequest {
331331
// NOW.
332332
google.protobuf.Timestamp read_time = 5;
333333

334-
// Filter that specifies what fields to further filter on *after* the query
335-
// filter has been executed. Currently only 'state_change' is supported and
336-
// requires compare_duration to be specified.
337-
string having = 6;
338-
339334
// The value returned by the last `GroupAssetsResponse`; indicates
340335
// that this is a continuation of a prior `GroupAssets` call, and that the
341336
// system should return the next page of data.
@@ -344,6 +339,8 @@ message GroupAssetsRequest {
344339
// The maximum number of results to return in a single response. Default is
345340
// 10, minimum is 1, maximum is 1000.
346341
int32 page_size = 8;
342+
343+
reserved 6;
347344
}
348345

349346
// Response message for grouping by assets.
@@ -446,11 +443,6 @@ message GroupFindingsRequest {
446443
// `group_by`.
447444
google.protobuf.Duration compare_duration = 5;
448445

449-
// Filter that specifies what fields to further filter on *after* the query
450-
// filter has been executed. Currently only 'finding.state' and 'state_change'
451-
// are supported and requires compare_duration to be specified.
452-
string having = 6;
453-
454446
// The value returned by the last `GroupFindingsResponse`; indicates
455447
// that this is a continuation of a prior `GroupFindings` call, and
456448
// that the system should return the next page of data.
@@ -459,6 +451,8 @@ message GroupFindingsRequest {
459451
// The maximum number of results to return in a single response. Default is
460452
// 10, minimum is 1, maximum is 1000.
461453
int32 page_size = 8;
454+
455+
reserved 6;
462456
}
463457

464458
// Response message for group by findings.
@@ -591,11 +585,6 @@ message ListAssetsRequest {
591585
// read_time.
592586
google.protobuf.Duration compare_duration = 5;
593587

594-
// Filter that specifies what fields to further filter on *after* the query
595-
// filter has been executed. Currently only 'state_change' is supported and
596-
// requires compare_duration to be specified.
597-
string having = 6;
598-
599588
// Optional.
600589
//
601590
// A field mask to specify the ListAssetsResult fields to be listed in the
@@ -611,6 +600,8 @@ message ListAssetsRequest {
611600
// The maximum number of results to return in a single response. Default is
612601
// 10, minimum is 1, maximum is 1000.
613602
int32 page_size = 9;
603+
604+
reserved 6;
614605
}
615606

616607
// Response message for listing assets.
@@ -735,11 +726,6 @@ message ListFindingsRequest {
735726
// read_time.
736727
google.protobuf.Duration compare_duration = 5;
737728

738-
// Filter that specifies what fields to further filter on *after* the query
739-
// filter has been executed. Currently only 'finding.state' and 'state_change'
740-
// are supported and requires compare_duration to be specified.
741-
string having = 6;
742-
743729
// Optional.
744730
//
745731
// A field mask to specify the Finding fields to be listed in the response.
@@ -754,6 +740,8 @@ message ListFindingsRequest {
754740
// The maximum number of results to return in a single response. Default is
755741
// 10, minimum is 1, maximum is 1000.
756742
int32 page_size = 9;
743+
744+
reserved 6;
757745
}
758746

759747
// Response message for listing findings.

0 commit comments

Comments
 (0)