Add new spec definitions

zhilingc · zhilingc · commit 4f946d6a6d24 · 2019-08-22T14:06:02.000+08:00
diff --git a/protos/feast/specs/FeatureSet.proto b/protos/feast/specs/FeatureSet.proto
@@ -0,0 +1,46 @@
+//
+// * Copyright 2019 The Feast Authors
+// *
+// * Licensed under the Apache License, Version 2.0 (the "License");
+// * you may not use this file except in compliance with the License.
+// * You may obtain a copy of the License at
+// *
+// *     https://www.apache.org/licenses/LICENSE-2.0
+// *
+// * Unless required by applicable law or agreed to in writing, software
+// * distributed under the License is distributed on an "AS IS" BASIS,
+// * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// * See the License for the specific language governing permissions and
+// * limitations under the License.
+//
+
+syntax = "proto3";
+
+package feast.specs;
+
+option java_package = "feast.specs";
+option java_outer_classname = "FeatureSetProto";
+option go_package = "github.com/gojek/feast/protos/generated/go/feast/specs";
+
+import "feast/types/Value.proto";
+
+message FeatureSet {
+  // Name of the featureSet. Must be unique.
+  string name = 1;
+  // FeatureSet version.
+  string version = 2;
+  // Features contained within this featureSet.
+  repeated FeatureSpec features = 3;
+}
+
+message FeatureSpec {
+  // Name of the feature.
+  string name = 1;
+  // Value type of the feature.
+  feast.types.ValueType.Enum valueType = 2;
+  // Describes whether a feature is also a key.
+  // This allows the feature to be used during joins between feature sets.
+  // If the featureSet is ingested into a store that supports keys, this value
+  // will be made a key.
+  bool isKey = 3;
+}
diff --git a/protos/feast/specs/ServingSpec.proto b/protos/feast/specs/ServingSpec.proto
@@ -0,0 +1,48 @@
+//
+// * Copyright 2019 The Feast Authors
+// *
+// * Licensed under the Apache License, Version 2.0 (the "License");
+// * you may not use this file except in compliance with the License.
+// * You may obtain a copy of the License at
+// *
+// *     https://www.apache.org/licenses/LICENSE-2.0
+// *
+// * Unless required by applicable law or agreed to in writing, software
+// * distributed under the License is distributed on an "AS IS" BASIS,
+// * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// * See the License for the specific language governing permissions and
+// * limitations under the License.
+//
+
+syntax = "proto3";
+package feast.specs;
+
+option java_package = "feast.specs";
+option java_outer_classname = "ServingStoreProto";
+option go_package = "github.com/gojek/feast/protos/generated/go/feast/specs";
+
+message ServingStore {
+
+  message StoreType {
+    enum Enum {
+      UNKNOWN = 0;
+      REDIS = 1;
+      BIGQUERY = 2;
+      CASSANDRA = 3;
+    }
+  }
+
+  // Name of the store.
+  string name = 1;
+
+  // Type of store.
+  ServingStore.StoreType type = 2;
+
+  // URI to connect to the database. Should contain all necessary information
+  // to connect to and write/read to the store.
+  string databaseURI = 3;
+
+  // Feature sets to subscribe to. Regex strings are allowed, in the form of
+  // featureSetId:version. E.g. my-feature-set:2^
+  repeated string subscriptions = 4;
+}
diff --git a/protos/feast/types/Value.proto b/protos/feast/types/Value.proto
@@ -34,14 +34,19 @@ message ValueType {
     DOUBLE = 5;
     FLOAT = 6;
     BOOL = 7;
-    TIMESTAMP = 8;
+    BYTES_LIST = 11;
+    STRING_LIST = 12;
+    INT32_LIST = 13;
+    INT64_LIST = 14;
+    DOUBLE_LIST = 15;
+    FLOAT_LIST = 16;
+    BOOL_LIST = 17;
   }
 }
 
 message Value {
   // ValueType is referenced by the metadata types, FeatureInfo and EntityInfo.
   // The enum values do not have to match the oneof val field ids, but they should.
-
   oneof val {
     bytes bytesVal = 1;
     string stringVal = 2;
@@ -50,20 +55,13 @@ message Value {
     double doubleVal = 5;
     float floatVal = 6;
     bool boolVal = 7;
-    google.protobuf.Timestamp timestampVal = 8;
-  }
-}
-
-message ValueList {
-  oneof valueList {
-    BytesList bytesList = 1;
-    StringList stringList = 2;
-    Int32List int32List = 3;
-    Int64List int64List = 4;
-    DoubleList doubleList = 5;
-    FloatList floatList = 6;
-    BoolList boolList = 7;
-    TimestampList timestampList = 8;
+    BytesList bytesListVal = 11;
+    StringList stringListVal = 12;
+    Int32List int32ListVal = 13;
+    Int64List int64ListVal = 14;
+    DoubleList doubleListVal = 15;
+    FloatList floatListVal = 16;
+    BoolList boolListVal = 17;
   }
 }
 
@@ -94,7 +92,3 @@ message FloatList {
 message BoolList {
   repeated bool val = 1;
 }
-
-message TimestampList {
-  repeated google.protobuf.Timestamp val = 1;
-}
