Use the ordinal number as aliases for GROUP BY

cedk · cedk · commit 484a87d13b36 · 2025-11-25T10:23:15.000+01:00
Closes #96
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,3 +1,4 @@
+* Use the ordinal number as aliases for GROUP BY
 * Check the coherence of the aliases of GROUP BY and ORDER BY expressions
 * Do not use parameter for EXTRACT field
 * Remove support for Python older than 3.6
diff --git a/sql/__init__.py b/sql/__init__.py
@@ -629,19 +629,26 @@ def __str__(self):
                 and (self.limit is not None or self.offset is not None)):
             return self._rownum(str)
 
+        ordinals = {}
         for expression in chain(
                 self.group_by or [],
                 self.order_by or []):
             if not isinstance(expression, As):
                 continue
-            for column in self.columns:
+            for i, column in enumerate(self.columns, start=1):
                 if not isinstance(column, As):
                     continue
                 if column.output_name != expression.output_name:
                     continue
                 if (str(column.expression) != str(expression.expression)
                         or column.params != expression.params):
                     raise ValueError("%r != %r" % (expression, column))
+                ordinals[column.output_name] = i
+
+        def str_or_ordinal(expression):
+            if isinstance(expression, As):
+                expression = ordinals.get(expression.output_name, expression)
+            return str(expression)
 
         with AliasManager():
             if self.from_ is not None:
@@ -671,7 +678,8 @@ def __str__(self):
                 where = ' WHERE ' + str(self.where)
             group_by = ''
             if self.group_by:
-                group_by = ' GROUP BY ' + ', '.join(map(str, self.group_by))
+                group_by = ' GROUP BY ' + ', '.join(
+                    map(str_or_ordinal, self.group_by))
             having = ''
             if self.having:
                 having = ' HAVING ' + str(self.having)
diff --git a/sql/tests/test_select.py b/sql/tests/test_select.py
@@ -197,7 +197,7 @@ def test_select_group_by(self):
         output = column.as_('c1')
         query = self.table.select(output, group_by=output)
         self.assertEqual(str(query),
-            'SELECT "a"."c" AS "c1" FROM "t" AS "a" GROUP BY "c1"')
+            'SELECT "a"."c" AS "c1" FROM "t" AS "a" GROUP BY 1')
         self.assertEqual(tuple(query.params), ())
 
         query = self.table.select(Literal('foo'), group_by=Literal('foo'))

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+* Use the ordinal number as aliases for GROUP BY`
`1`	`2`	`* Check the coherence of the aliases of GROUP BY and ORDER BY expressions`
`2`	`3`	`* Do not use parameter for EXTRACT field`
`3`	`4`	`* Remove support for Python older than 3.6`