perf(webapp,run-store): group per-item run reads into batched queries#4205
Draft
d-cs wants to merge 2 commits into
Draft
perf(webapp,run-store): group per-item run reads into batched queries#4205d-cs wants to merge 2 commits into
d-cs wants to merge 2 commits into
Conversation
Several run-ops read paths issued one database query per item where a single batched query returns the same data: batch results hydrated each member run separately, the run retrieve endpoint resolved each locked worker version separately, the dedicated-schema relation hydrator ran per row, and a few services read runs in per-id loops. These now group into batched reads. Adds a grouped findRunsByIds to the run store (one residency-partitioned read for a set of run ids) and routes the presenters and services through it. The dedicated-schema relation hydrator batches across all rows per relation. The waitpoint connected-runs read also regains its display limit at the fetch, so it no longer loads every connected run into memory before slicing to five.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
WalkthroughThis change replaces per-item read-through and per-id fan-out database queries with grouped, batched reads across presenters, services, run-store APIs, and control-plane worker resolution. It adds 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (3)
internal-packages/run-store/src/runOpsStore.ts (1)
1174-1189: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueDuplicate
.bind(this)cast pattern forfindRunsByIds.Both
#reresolveConnectedRunsCrossDband#hydrateEdgeTaskRunsCrossDbrepeat the identical(this.findRunsByIds as (...rest: unknown[]) => Promise<Map<string, unknown>>).bind(this)cast. Extracting this into a small private helper (e.g.#findRunsByIdsUntyped(ids, args, client)) would remove the duplication without changing behavior.♻️ Proposed extraction
+ // Untyped call-through to `findRunsByIds` for internal cross-DB re-resolution helpers, where + // the caller's projection shape is `unknown` and doesn't line up with the public overload set. + `#findRunsByIdsUntyped`( + ids: string[], + args: unknown, + client?: ReadClient + ): Promise<Map<string, unknown>> { + return (this.findRunsByIds as (...rest: unknown[]) => Promise<Map<string, unknown>>).call( + this, + ids, + args, + client + ); + } + async `#reresolveConnectedRunsCrossDb`( waitpointId: string, projection: SubProjection, client?: ReadClient ): Promise<unknown[]> { const runIds = await this.findWaitpointConnectedRunIds(waitpointId, client); const args = projectionAsArgs(projection); - const findRunsByIds = ( - this.findRunsByIds as (...rest: unknown[]) => Promise<Map<string, unknown>> - ).bind(this); - const byId = runIds.length > 0 ? await findRunsByIds(runIds, args, client) : new Map(); + const byId = + runIds.length > 0 ? await this.#findRunsByIdsUntyped(runIds, args, client) : new Map(); return runIds.map((id) => byId.get(id)).filter((run) => run != null); }Also applies to: 1349-1370
apps/webapp/test/waitpointPresenter.connectedRunsBounded.test.ts (1)
1-62: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winConsider extracting shared test setup into a helper module.
Both
waitpointPresenter.connectedRunsBounded.test.tsandwaitpointPresenter.splitConnectedRuns.test.tsshare near-identicalvi.mockblocks,vi.hoistedholders,seedParents,seedRun,SeedContext, andvi.setConfigsetup. Extracting these into a sharedwaitpointPresenterTestHelpers.ts(or similar) would reduce duplication and keep the two files focused on their distinct assertions.internal-packages/run-store/src/PostgresRunStore.groupedRelations.test.ts (1)
110-227: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winSolid grouped-query coverage for both join-relation hydrators. Only the
select-style nestedtaskRunprojection is exercised here — consider adding a companion case withinclude: { taskRun: {...} }given the concern raised inPostgresRunStore.tsabouthydrateBlockingTaskRunsonly checkingprojection?.select?.taskRun.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 88d641bf-e524-40b5-9e71-4aa161ba7324
📒 Files selected for processing (20)
apps/webapp/app/presenters/v3/ApiBatchResultsPresenter.server.tsapps/webapp/app/presenters/v3/ApiRetrieveRunPresenter.server.tsapps/webapp/app/presenters/v3/WaitpointPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.test.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/services/cancelDevSessionRuns.server.tsapps/webapp/test/apiBatchResultsPresenter.dedicatedSeam.test.tsapps/webapp/test/apiBatchResultsPresenter.splitNPlus1.test.tsapps/webapp/test/apiRetrieveRunPresenter.groupedLockedWorker.test.tsapps/webapp/test/cancelDevSessionRunsGroupedReads.test.tsapps/webapp/test/waitpointPresenter.connectedRunsBounded.test.tsapps/webapp/test/waitpointPresenter.splitConnectedRuns.test.tsinternal-packages/run-engine/src/engine/tests/legacyRunNewTokenResumeFlow.test.tsinternal-packages/run-store/src/PostgresRunStore.findRunsByIds.test.tsinternal-packages/run-store/src/PostgresRunStore.groupedRelations.test.tsinternal-packages/run-store/src/PostgresRunStore.tsinternal-packages/run-store/src/runOpsStore.groupedReads.test.tsinternal-packages/run-store/src/runOpsStore.tsinternal-packages/run-store/src/scheduleSeam.test.tsinternal-packages/run-store/src/types.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (24)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 10)
- GitHub Check: internal / 🧪 Unit Tests: Internal (2, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (10, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 10)
- GitHub Check: internal / 🧪 Unit Tests: Internal (8, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (6, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (11, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 10)
- GitHub Check: internal / 🧪 Unit Tests: Internal (12, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (5, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (4, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (7, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (1, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (3, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 10)
- GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
- GitHub Check: typecheck / typecheck
- GitHub Check: code-quality / code-quality
🧰 Additional context used
📓 Path-based instructions (10)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead
Files:
apps/webapp/test/cancelDevSessionRunsGroupedReads.test.tsapps/webapp/test/apiRetrieveRunPresenter.groupedLockedWorker.test.tsapps/webapp/test/apiBatchResultsPresenter.splitNPlus1.test.tsinternal-packages/run-store/src/PostgresRunStore.findRunsByIds.test.tsapps/webapp/app/presenters/v3/ApiRetrieveRunPresenter.server.tsapps/webapp/test/waitpointPresenter.connectedRunsBounded.test.tsapps/webapp/test/waitpointPresenter.splitConnectedRuns.test.tsapps/webapp/app/presenters/v3/WaitpointPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.test.tsinternal-packages/run-store/src/PostgresRunStore.groupedRelations.test.tsinternal-packages/run-engine/src/engine/tests/legacyRunNewTokenResumeFlow.test.tsinternal-packages/run-store/src/types.tsinternal-packages/run-store/src/scheduleSeam.test.tsinternal-packages/run-store/src/runOpsStore.groupedReads.test.tsapps/webapp/test/apiBatchResultsPresenter.dedicatedSeam.test.tsapps/webapp/app/presenters/v3/ApiBatchResultsPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsinternal-packages/run-store/src/PostgresRunStore.tsinternal-packages/run-store/src/runOpsStore.tsapps/webapp/app/v3/services/cancelDevSessionRuns.server.ts
{packages/core,apps/webapp}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use zod for validation in packages/core and apps/webapp
Files:
apps/webapp/test/cancelDevSessionRunsGroupedReads.test.tsapps/webapp/test/apiRetrieveRunPresenter.groupedLockedWorker.test.tsapps/webapp/test/apiBatchResultsPresenter.splitNPlus1.test.tsapps/webapp/app/presenters/v3/ApiRetrieveRunPresenter.server.tsapps/webapp/test/waitpointPresenter.connectedRunsBounded.test.tsapps/webapp/test/waitpointPresenter.splitConnectedRuns.test.tsapps/webapp/app/presenters/v3/WaitpointPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.test.tsapps/webapp/test/apiBatchResultsPresenter.dedicatedSeam.test.tsapps/webapp/app/presenters/v3/ApiBatchResultsPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/services/cancelDevSessionRuns.server.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use function declarations instead of default exports
**/*.{ts,tsx,js,jsx}: Prefer static imports over dynamicimport(); only use dynamic imports when resolving circular dependencies, enabling real code splitting, or conditionally loading a module at runtime.
Always import from@trigger.dev/sdk; never use@trigger.dev/sdk/v3or the deprecatedclient.defineJob.
Files:
apps/webapp/test/cancelDevSessionRunsGroupedReads.test.tsapps/webapp/test/apiRetrieveRunPresenter.groupedLockedWorker.test.tsapps/webapp/test/apiBatchResultsPresenter.splitNPlus1.test.tsinternal-packages/run-store/src/PostgresRunStore.findRunsByIds.test.tsapps/webapp/app/presenters/v3/ApiRetrieveRunPresenter.server.tsapps/webapp/test/waitpointPresenter.connectedRunsBounded.test.tsapps/webapp/test/waitpointPresenter.splitConnectedRuns.test.tsapps/webapp/app/presenters/v3/WaitpointPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.test.tsinternal-packages/run-store/src/PostgresRunStore.groupedRelations.test.tsinternal-packages/run-engine/src/engine/tests/legacyRunNewTokenResumeFlow.test.tsinternal-packages/run-store/src/types.tsinternal-packages/run-store/src/scheduleSeam.test.tsinternal-packages/run-store/src/runOpsStore.groupedReads.test.tsapps/webapp/test/apiBatchResultsPresenter.dedicatedSeam.test.tsapps/webapp/app/presenters/v3/ApiBatchResultsPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsinternal-packages/run-store/src/PostgresRunStore.tsinternal-packages/run-store/src/runOpsStore.tsapps/webapp/app/v3/services/cancelDevSessionRuns.server.ts
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use vitest for all tests in the Trigger.dev repository
Files:
apps/webapp/test/cancelDevSessionRunsGroupedReads.test.tsapps/webapp/test/apiRetrieveRunPresenter.groupedLockedWorker.test.tsapps/webapp/test/apiBatchResultsPresenter.splitNPlus1.test.tsinternal-packages/run-store/src/PostgresRunStore.findRunsByIds.test.tsapps/webapp/test/waitpointPresenter.connectedRunsBounded.test.tsapps/webapp/test/waitpointPresenter.splitConnectedRuns.test.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.test.tsinternal-packages/run-store/src/PostgresRunStore.groupedRelations.test.tsinternal-packages/run-engine/src/engine/tests/legacyRunNewTokenResumeFlow.test.tsinternal-packages/run-store/src/scheduleSeam.test.tsinternal-packages/run-store/src/runOpsStore.groupedReads.test.tsapps/webapp/test/apiBatchResultsPresenter.dedicatedSeam.test.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries
Files:
apps/webapp/test/cancelDevSessionRunsGroupedReads.test.tsapps/webapp/test/apiRetrieveRunPresenter.groupedLockedWorker.test.tsapps/webapp/test/apiBatchResultsPresenter.splitNPlus1.test.tsinternal-packages/run-store/src/PostgresRunStore.findRunsByIds.test.tsapps/webapp/app/presenters/v3/ApiRetrieveRunPresenter.server.tsapps/webapp/test/waitpointPresenter.connectedRunsBounded.test.tsapps/webapp/test/waitpointPresenter.splitConnectedRuns.test.tsapps/webapp/app/presenters/v3/WaitpointPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.test.tsinternal-packages/run-store/src/PostgresRunStore.groupedRelations.test.tsinternal-packages/run-engine/src/engine/tests/legacyRunNewTokenResumeFlow.test.tsinternal-packages/run-store/src/types.tsinternal-packages/run-store/src/scheduleSeam.test.tsinternal-packages/run-store/src/runOpsStore.groupedReads.test.tsapps/webapp/test/apiBatchResultsPresenter.dedicatedSeam.test.tsapps/webapp/app/presenters/v3/ApiBatchResultsPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsinternal-packages/run-store/src/PostgresRunStore.tsinternal-packages/run-store/src/runOpsStore.tsapps/webapp/app/v3/services/cancelDevSessionRuns.server.ts
apps/webapp/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
apps/webapp/**/*.{ts,tsx}: Access environment variables through theenvexport ofenv.server.tsinstead of directly accessingprocess.env
Use subpath exports from@trigger.dev/corepackage instead of importing from the root@trigger.dev/corepathAlways use
findFirstinstead offindUniquefor Prisma queries.
Files:
apps/webapp/test/cancelDevSessionRunsGroupedReads.test.tsapps/webapp/test/apiRetrieveRunPresenter.groupedLockedWorker.test.tsapps/webapp/test/apiBatchResultsPresenter.splitNPlus1.test.tsapps/webapp/app/presenters/v3/ApiRetrieveRunPresenter.server.tsapps/webapp/test/waitpointPresenter.connectedRunsBounded.test.tsapps/webapp/test/waitpointPresenter.splitConnectedRuns.test.tsapps/webapp/app/presenters/v3/WaitpointPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.test.tsapps/webapp/test/apiBatchResultsPresenter.dedicatedSeam.test.tsapps/webapp/app/presenters/v3/ApiBatchResultsPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/services/cancelDevSessionRuns.server.ts
apps/webapp/**/*.test.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
Do not import
env.server.tsdirectly or indirectly into test files; instead pass environment-dependent values through options/parameters to make code testable
Files:
apps/webapp/test/cancelDevSessionRunsGroupedReads.test.tsapps/webapp/test/apiRetrieveRunPresenter.groupedLockedWorker.test.tsapps/webapp/test/apiBatchResultsPresenter.splitNPlus1.test.tsapps/webapp/test/waitpointPresenter.connectedRunsBounded.test.tsapps/webapp/test/waitpointPresenter.splitConnectedRuns.test.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.test.tsapps/webapp/test/apiBatchResultsPresenter.dedicatedSeam.test.ts
apps/webapp/**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
In test files, never import
env.server.ts; pass configuration as options instead.
Files:
apps/webapp/test/cancelDevSessionRunsGroupedReads.test.tsapps/webapp/test/apiRetrieveRunPresenter.groupedLockedWorker.test.tsapps/webapp/test/apiBatchResultsPresenter.splitNPlus1.test.tsapps/webapp/test/waitpointPresenter.connectedRunsBounded.test.tsapps/webapp/test/waitpointPresenter.splitConnectedRuns.test.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.test.tsapps/webapp/test/apiBatchResultsPresenter.dedicatedSeam.test.ts
**/*.test.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
Place test files next to their source files, e.g.
MyService.ts->MyService.test.ts.
Files:
apps/webapp/test/cancelDevSessionRunsGroupedReads.test.tsapps/webapp/test/apiRetrieveRunPresenter.groupedLockedWorker.test.tsapps/webapp/test/apiBatchResultsPresenter.splitNPlus1.test.tsinternal-packages/run-store/src/PostgresRunStore.findRunsByIds.test.tsapps/webapp/test/waitpointPresenter.connectedRunsBounded.test.tsapps/webapp/test/waitpointPresenter.splitConnectedRuns.test.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.test.tsinternal-packages/run-store/src/PostgresRunStore.groupedRelations.test.tsinternal-packages/run-engine/src/engine/tests/legacyRunNewTokenResumeFlow.test.tsinternal-packages/run-store/src/scheduleSeam.test.tsinternal-packages/run-store/src/runOpsStore.groupedReads.test.tsapps/webapp/test/apiBatchResultsPresenter.dedicatedSeam.test.ts
internal-packages/run-engine/src/engine/tests/**/*.test.ts
📄 CodeRabbit inference engine (internal-packages/run-engine/CLAUDE.md)
Implement tests for RunEngine in
src/engine/tests/using testcontainers for Redis and PostgreSQL containerization
Files:
internal-packages/run-engine/src/engine/tests/legacyRunNewTokenResumeFlow.test.ts
🧠 Learnings (23)
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).
Applied to files:
apps/webapp/test/cancelDevSessionRunsGroupedReads.test.tsapps/webapp/test/apiRetrieveRunPresenter.groupedLockedWorker.test.tsapps/webapp/test/apiBatchResultsPresenter.splitNPlus1.test.tsinternal-packages/run-store/src/PostgresRunStore.findRunsByIds.test.tsapps/webapp/app/presenters/v3/ApiRetrieveRunPresenter.server.tsapps/webapp/test/waitpointPresenter.connectedRunsBounded.test.tsapps/webapp/test/waitpointPresenter.splitConnectedRuns.test.tsapps/webapp/app/presenters/v3/WaitpointPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.test.tsinternal-packages/run-store/src/PostgresRunStore.groupedRelations.test.tsinternal-packages/run-engine/src/engine/tests/legacyRunNewTokenResumeFlow.test.tsinternal-packages/run-store/src/types.tsinternal-packages/run-store/src/scheduleSeam.test.tsinternal-packages/run-store/src/runOpsStore.groupedReads.test.tsapps/webapp/test/apiBatchResultsPresenter.dedicatedSeam.test.tsapps/webapp/app/presenters/v3/ApiBatchResultsPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsinternal-packages/run-store/src/PostgresRunStore.tsinternal-packages/run-store/src/runOpsStore.tsapps/webapp/app/v3/services/cancelDevSessionRuns.server.ts
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.
Applied to files:
apps/webapp/test/cancelDevSessionRunsGroupedReads.test.tsapps/webapp/test/apiRetrieveRunPresenter.groupedLockedWorker.test.tsapps/webapp/test/apiBatchResultsPresenter.splitNPlus1.test.tsinternal-packages/run-store/src/PostgresRunStore.findRunsByIds.test.tsapps/webapp/app/presenters/v3/ApiRetrieveRunPresenter.server.tsapps/webapp/test/waitpointPresenter.connectedRunsBounded.test.tsapps/webapp/test/waitpointPresenter.splitConnectedRuns.test.tsapps/webapp/app/presenters/v3/WaitpointPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.test.tsinternal-packages/run-store/src/PostgresRunStore.groupedRelations.test.tsinternal-packages/run-engine/src/engine/tests/legacyRunNewTokenResumeFlow.test.tsinternal-packages/run-store/src/types.tsinternal-packages/run-store/src/scheduleSeam.test.tsinternal-packages/run-store/src/runOpsStore.groupedReads.test.tsapps/webapp/test/apiBatchResultsPresenter.dedicatedSeam.test.tsapps/webapp/app/presenters/v3/ApiBatchResultsPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsinternal-packages/run-store/src/PostgresRunStore.tsinternal-packages/run-store/src/runOpsStore.tsapps/webapp/app/v3/services/cancelDevSessionRuns.server.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.
Applied to files:
apps/webapp/test/cancelDevSessionRunsGroupedReads.test.tsapps/webapp/test/apiRetrieveRunPresenter.groupedLockedWorker.test.tsapps/webapp/test/apiBatchResultsPresenter.splitNPlus1.test.tsinternal-packages/run-store/src/PostgresRunStore.findRunsByIds.test.tsapps/webapp/app/presenters/v3/ApiRetrieveRunPresenter.server.tsapps/webapp/test/waitpointPresenter.connectedRunsBounded.test.tsapps/webapp/test/waitpointPresenter.splitConnectedRuns.test.tsapps/webapp/app/presenters/v3/WaitpointPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.test.tsinternal-packages/run-store/src/PostgresRunStore.groupedRelations.test.tsinternal-packages/run-engine/src/engine/tests/legacyRunNewTokenResumeFlow.test.tsinternal-packages/run-store/src/types.tsinternal-packages/run-store/src/scheduleSeam.test.tsinternal-packages/run-store/src/runOpsStore.groupedReads.test.tsapps/webapp/test/apiBatchResultsPresenter.dedicatedSeam.test.tsapps/webapp/app/presenters/v3/ApiBatchResultsPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsinternal-packages/run-store/src/PostgresRunStore.tsinternal-packages/run-store/src/runOpsStore.tsapps/webapp/app/v3/services/cancelDevSessionRuns.server.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.
Applied to files:
apps/webapp/test/cancelDevSessionRunsGroupedReads.test.tsapps/webapp/test/apiRetrieveRunPresenter.groupedLockedWorker.test.tsapps/webapp/test/apiBatchResultsPresenter.splitNPlus1.test.tsinternal-packages/run-store/src/PostgresRunStore.findRunsByIds.test.tsapps/webapp/app/presenters/v3/ApiRetrieveRunPresenter.server.tsapps/webapp/test/waitpointPresenter.connectedRunsBounded.test.tsapps/webapp/test/waitpointPresenter.splitConnectedRuns.test.tsapps/webapp/app/presenters/v3/WaitpointPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.test.tsinternal-packages/run-store/src/PostgresRunStore.groupedRelations.test.tsinternal-packages/run-engine/src/engine/tests/legacyRunNewTokenResumeFlow.test.tsinternal-packages/run-store/src/types.tsinternal-packages/run-store/src/scheduleSeam.test.tsinternal-packages/run-store/src/runOpsStore.groupedReads.test.tsapps/webapp/test/apiBatchResultsPresenter.dedicatedSeam.test.tsapps/webapp/app/presenters/v3/ApiBatchResultsPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsinternal-packages/run-store/src/PostgresRunStore.tsinternal-packages/run-store/src/runOpsStore.tsapps/webapp/app/v3/services/cancelDevSessionRuns.server.ts
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.
Applied to files:
apps/webapp/test/cancelDevSessionRunsGroupedReads.test.tsapps/webapp/test/apiRetrieveRunPresenter.groupedLockedWorker.test.tsapps/webapp/test/apiBatchResultsPresenter.splitNPlus1.test.tsinternal-packages/run-store/src/PostgresRunStore.findRunsByIds.test.tsapps/webapp/app/presenters/v3/ApiRetrieveRunPresenter.server.tsapps/webapp/test/waitpointPresenter.connectedRunsBounded.test.tsapps/webapp/test/waitpointPresenter.splitConnectedRuns.test.tsapps/webapp/app/presenters/v3/WaitpointPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.test.tsinternal-packages/run-store/src/PostgresRunStore.groupedRelations.test.tsinternal-packages/run-engine/src/engine/tests/legacyRunNewTokenResumeFlow.test.tsinternal-packages/run-store/src/types.tsinternal-packages/run-store/src/scheduleSeam.test.tsinternal-packages/run-store/src/runOpsStore.groupedReads.test.tsapps/webapp/test/apiBatchResultsPresenter.dedicatedSeam.test.tsapps/webapp/app/presenters/v3/ApiBatchResultsPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsinternal-packages/run-store/src/PostgresRunStore.tsinternal-packages/run-store/src/runOpsStore.tsapps/webapp/app/v3/services/cancelDevSessionRuns.server.ts
📚 Learning: 2026-06-17T17:13:49.929Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).
Applied to files:
apps/webapp/test/cancelDevSessionRunsGroupedReads.test.tsapps/webapp/test/apiRetrieveRunPresenter.groupedLockedWorker.test.tsapps/webapp/test/apiBatchResultsPresenter.splitNPlus1.test.tsinternal-packages/run-store/src/PostgresRunStore.findRunsByIds.test.tsapps/webapp/app/presenters/v3/ApiRetrieveRunPresenter.server.tsapps/webapp/test/waitpointPresenter.connectedRunsBounded.test.tsapps/webapp/test/waitpointPresenter.splitConnectedRuns.test.tsapps/webapp/app/presenters/v3/WaitpointPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.test.tsinternal-packages/run-store/src/PostgresRunStore.groupedRelations.test.tsinternal-packages/run-engine/src/engine/tests/legacyRunNewTokenResumeFlow.test.tsinternal-packages/run-store/src/types.tsinternal-packages/run-store/src/scheduleSeam.test.tsinternal-packages/run-store/src/runOpsStore.groupedReads.test.tsapps/webapp/test/apiBatchResultsPresenter.dedicatedSeam.test.tsapps/webapp/app/presenters/v3/ApiBatchResultsPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsinternal-packages/run-store/src/PostgresRunStore.tsinternal-packages/run-store/src/runOpsStore.tsapps/webapp/app/v3/services/cancelDevSessionRuns.server.ts
📚 Learning: 2026-06-23T13:04:21.413Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4023
File: apps/webapp/app/services/upsertBranch.server.ts:14-18
Timestamp: 2026-06-23T13:04:21.413Z
Learning: In TypeScript, it’s valid to `import { type X }` and then use `typeof X` in a type-only position, e.g. `type Alias = z.infer<typeof X>`. The `type` modifier suppresses the runtime import, but the type checker still has the full exported type so `z.infer<typeof X>` can resolve correctly. In code reviews, don’t flag this as a TypeScript compile error as long as `typeof X` is used in a type context (e.g., with `z.infer`, `type` aliases, generics), not as a runtime value.
Applied to files:
apps/webapp/test/cancelDevSessionRunsGroupedReads.test.tsapps/webapp/test/apiRetrieveRunPresenter.groupedLockedWorker.test.tsapps/webapp/test/apiBatchResultsPresenter.splitNPlus1.test.tsinternal-packages/run-store/src/PostgresRunStore.findRunsByIds.test.tsapps/webapp/app/presenters/v3/ApiRetrieveRunPresenter.server.tsapps/webapp/test/waitpointPresenter.connectedRunsBounded.test.tsapps/webapp/test/waitpointPresenter.splitConnectedRuns.test.tsapps/webapp/app/presenters/v3/WaitpointPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.test.tsinternal-packages/run-store/src/PostgresRunStore.groupedRelations.test.tsinternal-packages/run-engine/src/engine/tests/legacyRunNewTokenResumeFlow.test.tsinternal-packages/run-store/src/types.tsinternal-packages/run-store/src/scheduleSeam.test.tsinternal-packages/run-store/src/runOpsStore.groupedReads.test.tsapps/webapp/test/apiBatchResultsPresenter.dedicatedSeam.test.tsapps/webapp/app/presenters/v3/ApiBatchResultsPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsinternal-packages/run-store/src/PostgresRunStore.tsinternal-packages/run-store/src/runOpsStore.tsapps/webapp/app/v3/services/cancelDevSessionRuns.server.ts
📚 Learning: 2026-05-07T12:25:18.271Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3531
File: apps/webapp/test/sentryTraceContext.server.test.ts:9-47
Timestamp: 2026-05-07T12:25:18.271Z
Learning: In the triggerdotdev/trigger.dev webapp test suite, it is acceptable to leave `createInMemoryTracing()` calls that register a global `NodeTracerProvider` without `afterEach`/`afterAll` teardown. Do not flag this as a test-ordering risk when the code follows the established pattern used across webapp tests (e.g., replication service/benchmark/backfiller tests). This is considered safe because `trace.getActiveSpan()` when called outside a `context.with(...)` block reads `AsyncLocalStorage.getStore()` (undefined when no `run()` scope exists), so it falls back to `ROOT_CONTEXT` with no attached span—regardless of which provider is registered.
Applied to files:
apps/webapp/test/cancelDevSessionRunsGroupedReads.test.tsapps/webapp/test/apiRetrieveRunPresenter.groupedLockedWorker.test.tsapps/webapp/test/apiBatchResultsPresenter.splitNPlus1.test.tsapps/webapp/test/waitpointPresenter.connectedRunsBounded.test.tsapps/webapp/test/waitpointPresenter.splitConnectedRuns.test.tsapps/webapp/test/apiBatchResultsPresenter.dedicatedSeam.test.ts
📚 Learning: 2026-05-28T20:02:10.647Z
Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3772
File: apps/webapp/test/findOrCreateBackgroundWorker.test.ts:1-1
Timestamp: 2026-05-28T20:02:10.647Z
Learning: In the triggerdotdev/trigger.dev monorepo, for the `apps/webapp` package use the established convention of storing Vitest tests (unit, integration, and e2e) under `apps/webapp/test/` rather than colocating them next to source files. Do not flag files located in `apps/webapp/test/` as violating any rule that says to colocate tests with source.
Applied to files:
apps/webapp/test/cancelDevSessionRunsGroupedReads.test.tsapps/webapp/test/apiRetrieveRunPresenter.groupedLockedWorker.test.tsapps/webapp/test/apiBatchResultsPresenter.splitNPlus1.test.tsapps/webapp/test/waitpointPresenter.connectedRunsBounded.test.tsapps/webapp/test/waitpointPresenter.splitConnectedRuns.test.tsapps/webapp/test/apiBatchResultsPresenter.dedicatedSeam.test.ts
📚 Learning: 2026-05-12T21:04:05.815Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3542
File: apps/webapp/app/components/sessions/v1/SessionStatus.tsx:1-3
Timestamp: 2026-05-12T21:04:05.815Z
Learning: In this Remix + TypeScript codebase, do not flag a server/client boundary violation when a file imports only types from a module matching `*.server`.
Specifically, it’s safe to import types using `import type { Foo } from "*.server"` or `import { type Foo } from "*.server"` because TypeScript erases type-only imports at compile time and they emit no JavaScript, so they won’t cross the Remix server/client bundle boundary.
Only raise the boundary concern for value imports (e.g., `import { Foo }` without `type`, or `import Foo`), since those produce JavaScript output.
Applied to files:
apps/webapp/test/cancelDevSessionRunsGroupedReads.test.tsapps/webapp/test/apiRetrieveRunPresenter.groupedLockedWorker.test.tsapps/webapp/test/apiBatchResultsPresenter.splitNPlus1.test.tsapps/webapp/app/presenters/v3/ApiRetrieveRunPresenter.server.tsapps/webapp/test/waitpointPresenter.connectedRunsBounded.test.tsapps/webapp/test/waitpointPresenter.splitConnectedRuns.test.tsapps/webapp/app/presenters/v3/WaitpointPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.test.tsapps/webapp/test/apiBatchResultsPresenter.dedicatedSeam.test.tsapps/webapp/app/presenters/v3/ApiBatchResultsPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/services/cancelDevSessionRuns.server.ts
📚 Learning: 2026-06-25T18:21:51.905Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4039
File: apps/webapp/app/routes/invite-revoke.tsx:0-0
Timestamp: 2026-06-25T18:21:51.905Z
Learning: During the Zod v4 migration in the triggerdotdev/trigger.dev webapp, ensure any imports from `conform-to/zod` use the Zod-4 subpath: `conform-to/zod/v4` (e.g., `import { parseWithZod } from "conform-to/zod/v4"`). Do not import from the package root `conform-to/zod`, because it is the Zod 3 implementation and may load Zod-3-only symbols (e.g., `ZodBranded`, `ZodEffects`), which can throw at module load (notably with `zod4.4.3`). This should be enforced across `apps/webapp/**/*` where helpers like `parseWithZod` and `conformZodMessage` are used.
Applied to files:
apps/webapp/test/cancelDevSessionRunsGroupedReads.test.tsapps/webapp/test/apiRetrieveRunPresenter.groupedLockedWorker.test.tsapps/webapp/test/apiBatchResultsPresenter.splitNPlus1.test.tsapps/webapp/app/presenters/v3/ApiRetrieveRunPresenter.server.tsapps/webapp/test/waitpointPresenter.connectedRunsBounded.test.tsapps/webapp/test/waitpointPresenter.splitConnectedRuns.test.tsapps/webapp/app/presenters/v3/WaitpointPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.test.tsapps/webapp/test/apiBatchResultsPresenter.dedicatedSeam.test.tsapps/webapp/app/presenters/v3/ApiBatchResultsPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/services/cancelDevSessionRuns.server.ts
📚 Learning: 2026-07-03T17:10:21.498Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 4148
File: apps/webapp/app/models/orgMember.server.ts:149-168
Timestamp: 2026-07-03T17:10:21.498Z
Learning: In triggerdotdev/trigger.dev, `User.email` (Prisma schema: `internal-packages/database/prisma/schema.prisma`) currently does NOT use `citext` and does NOT have a `lower(email)` functional unique index. Therefore, do not introduce Prisma queries like `where: { email: { equals: <value>, mode: "insensitive" } }` (or any case-insensitive lookup) against `User.email`, because it can force sequential scans of the `users` table under load. During review, ensure email is normalized (e.g., lowercased/trimmed) before both writes and subsequent lookups, and if true case-insensitive behavior/uniqueness is required, implement it via a separate app-wide migration (e.g., switch to `citext` and/or add a functional unique index with backfill) rather than bolting it onto individual feature PRs.
Applied to files:
apps/webapp/test/cancelDevSessionRunsGroupedReads.test.tsapps/webapp/test/apiRetrieveRunPresenter.groupedLockedWorker.test.tsapps/webapp/test/apiBatchResultsPresenter.splitNPlus1.test.tsapps/webapp/app/presenters/v3/ApiRetrieveRunPresenter.server.tsapps/webapp/test/waitpointPresenter.connectedRunsBounded.test.tsapps/webapp/test/waitpointPresenter.splitConnectedRuns.test.tsapps/webapp/app/presenters/v3/WaitpointPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.test.tsapps/webapp/test/apiBatchResultsPresenter.dedicatedSeam.test.tsapps/webapp/app/presenters/v3/ApiBatchResultsPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/services/cancelDevSessionRuns.server.ts
📚 Learning: 2026-05-18T14:40:02.173Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In the triggerdotdev/trigger.dev repo, the policy “Never mock anything — use testcontainers instead” should only be enforced for integration tests that interact with real external services (e.g., Redis, Postgres) via actual infrastructure. For unit tests that exercise pure in-memory logic (e.g., cache semantics) it is OK to stub collaborators such as `ApiClient` using Vitest (`vi.fn()`) to assert call counts or control behavior. Do not flag `vi.fn()`-based `ApiClient` stubs in unit tests as violations of the testcontainers policy.
Applied to files:
apps/webapp/test/cancelDevSessionRunsGroupedReads.test.tsapps/webapp/test/apiRetrieveRunPresenter.groupedLockedWorker.test.tsapps/webapp/test/apiBatchResultsPresenter.splitNPlus1.test.tsinternal-packages/run-store/src/PostgresRunStore.findRunsByIds.test.tsapps/webapp/test/waitpointPresenter.connectedRunsBounded.test.tsapps/webapp/test/waitpointPresenter.splitConnectedRuns.test.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.test.tsinternal-packages/run-store/src/PostgresRunStore.groupedRelations.test.tsinternal-packages/run-engine/src/engine/tests/legacyRunNewTokenResumeFlow.test.tsinternal-packages/run-store/src/scheduleSeam.test.tsinternal-packages/run-store/src/runOpsStore.groupedReads.test.tsapps/webapp/test/apiBatchResultsPresenter.dedicatedSeam.test.ts
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.
Applied to files:
apps/webapp/test/cancelDevSessionRunsGroupedReads.test.tsapps/webapp/test/apiRetrieveRunPresenter.groupedLockedWorker.test.tsapps/webapp/test/apiBatchResultsPresenter.splitNPlus1.test.tsinternal-packages/run-store/src/PostgresRunStore.findRunsByIds.test.tsapps/webapp/app/presenters/v3/ApiRetrieveRunPresenter.server.tsapps/webapp/test/waitpointPresenter.connectedRunsBounded.test.tsapps/webapp/test/waitpointPresenter.splitConnectedRuns.test.tsapps/webapp/app/presenters/v3/WaitpointPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.test.tsinternal-packages/run-store/src/PostgresRunStore.groupedRelations.test.tsinternal-packages/run-engine/src/engine/tests/legacyRunNewTokenResumeFlow.test.tsinternal-packages/run-store/src/types.tsinternal-packages/run-store/src/scheduleSeam.test.tsinternal-packages/run-store/src/runOpsStore.groupedReads.test.tsapps/webapp/test/apiBatchResultsPresenter.dedicatedSeam.test.tsapps/webapp/app/presenters/v3/ApiBatchResultsPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsinternal-packages/run-store/src/PostgresRunStore.tsinternal-packages/run-store/src/runOpsStore.tsapps/webapp/app/v3/services/cancelDevSessionRuns.server.ts
📚 Learning: 2026-06-09T17:58:04.699Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.
Applied to files:
apps/webapp/test/cancelDevSessionRunsGroupedReads.test.tsapps/webapp/test/apiRetrieveRunPresenter.groupedLockedWorker.test.tsapps/webapp/test/apiBatchResultsPresenter.splitNPlus1.test.tsinternal-packages/run-store/src/PostgresRunStore.findRunsByIds.test.tsapps/webapp/app/presenters/v3/ApiRetrieveRunPresenter.server.tsapps/webapp/test/waitpointPresenter.connectedRunsBounded.test.tsapps/webapp/test/waitpointPresenter.splitConnectedRuns.test.tsapps/webapp/app/presenters/v3/WaitpointPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.test.tsinternal-packages/run-store/src/PostgresRunStore.groupedRelations.test.tsinternal-packages/run-engine/src/engine/tests/legacyRunNewTokenResumeFlow.test.tsinternal-packages/run-store/src/types.tsinternal-packages/run-store/src/scheduleSeam.test.tsinternal-packages/run-store/src/runOpsStore.groupedReads.test.tsapps/webapp/test/apiBatchResultsPresenter.dedicatedSeam.test.tsapps/webapp/app/presenters/v3/ApiBatchResultsPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsinternal-packages/run-store/src/PostgresRunStore.tsinternal-packages/run-store/src/runOpsStore.tsapps/webapp/app/v3/services/cancelDevSessionRuns.server.ts
📚 Learning: 2026-06-16T09:19:47.637Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3960
File: apps/webapp/test/prismaInfrastructureErrorCapture.test.ts:0-0
Timestamp: 2026-06-16T09:19:47.637Z
Learning: In this repo’s Vitest setup, `vitest.config.ts` uses `globals: true`, so identifiers like `vi`, `describe`, `it`, and `expect` are available as globals in Vitest test files. During code review, do not flag missing `vi`/`describe`/`it`/`expect` imports as a runtime error or correctness issue when they’re used in `*.test.ts/tsx` or `*.spec.ts/tsx` files. Explicit imports are still preferred for consistency, but they’re not required for runtime behavior.
Applied to files:
apps/webapp/test/cancelDevSessionRunsGroupedReads.test.tsapps/webapp/test/apiRetrieveRunPresenter.groupedLockedWorker.test.tsapps/webapp/test/apiBatchResultsPresenter.splitNPlus1.test.tsinternal-packages/run-store/src/PostgresRunStore.findRunsByIds.test.tsapps/webapp/test/waitpointPresenter.connectedRunsBounded.test.tsapps/webapp/test/waitpointPresenter.splitConnectedRuns.test.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.test.tsinternal-packages/run-store/src/PostgresRunStore.groupedRelations.test.tsinternal-packages/run-engine/src/engine/tests/legacyRunNewTokenResumeFlow.test.tsinternal-packages/run-store/src/scheduleSeam.test.tsinternal-packages/run-store/src/runOpsStore.groupedReads.test.tsapps/webapp/test/apiBatchResultsPresenter.dedicatedSeam.test.ts
📚 Learning: 2026-02-06T19:53:38.843Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 2994
File: apps/webapp/app/presenters/v3/DeploymentListPresenter.server.ts:233-237
Timestamp: 2026-02-06T19:53:38.843Z
Learning: When constructing Vercel dashboard URLs from deployment IDs, always strip the dpl_ prefix from the ID. Implement this by transforming the ID with .replace(/^dpl_/, "") before concatenating into the URL: https://vercel.com/${teamSlug}/${projectName}/${cleanedDeploymentId}. Consider centralizing this logic in a small helper (e.g., getVercelDeploymentId(id) or a URL builder) and add tests to verify both prefixed and non-prefixed inputs.
Applied to files:
apps/webapp/app/presenters/v3/ApiRetrieveRunPresenter.server.tsapps/webapp/app/presenters/v3/WaitpointPresenter.server.tsapps/webapp/app/presenters/v3/ApiBatchResultsPresenter.server.ts
📚 Learning: 2026-05-05T09:38:02.512Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3523
File: apps/webapp/app/routes/api.v3.batches.ts:178-181
Timestamp: 2026-05-05T09:38:02.512Z
Learning: When reviewing code that catches `ServiceValidationError` in `*.server.ts` files, do not blindly forward `error.status` to HTTP responses, because SVEs may be thrown with non-default statuses (e.g., 400/500) and forwarding them can cause client-visible behavioral regressions (e.g., surfacing 500s to clients). Prefer a safe default response status of `error.status ?? 422`, but only after confirming via the reachable call graph that the caught `ServiceValidationError` instances are expected to carry those non-default statuses; otherwise, normalize to `422` to avoid unexpected client-visible 5xx behavior.
Applied to files:
apps/webapp/app/presenters/v3/ApiRetrieveRunPresenter.server.tsapps/webapp/app/presenters/v3/WaitpointPresenter.server.tsapps/webapp/app/presenters/v3/ApiBatchResultsPresenter.server.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/services/cancelDevSessionRuns.server.ts
📚 Learning: 2026-06-21T05:35:23.468Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 4005
File: apps/webapp/app/presenters/v3/ApiErrorListPresenter.server.ts:29-30
Timestamp: 2026-06-21T05:35:23.468Z
Learning: For triggerdotdev/trigger.dev list endpoints (and their presenters/handlers that implement list pagination), it is an established shared convention to allow both cursor query params `page[after]` and `page[before]` to be provided at the same time. When both are present, `page[before]` must take precedence (i.e., it should be used/wins). During code review, do NOT flag missing per-endpoint mutual-exclusion validation between `page[after]` and `page[before]` as a problem; if stricter enforcement is ever desired, it should be implemented as a codebase-wide shared convention (not individually per endpoint).
Applied to files:
apps/webapp/app/presenters/v3/ApiRetrieveRunPresenter.server.tsapps/webapp/app/presenters/v3/WaitpointPresenter.server.tsapps/webapp/app/presenters/v3/ApiBatchResultsPresenter.server.ts
📚 Learning: 2026-03-29T19:16:28.864Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3291
File: apps/webapp/app/v3/featureFlags.ts:53-65
Timestamp: 2026-03-29T19:16:28.864Z
Learning: When reviewing TypeScript code that uses Zod v3, treat `z.coerce.*()` schemas as their direct Zod type (e.g., `z.coerce.boolean()` returns a `ZodBoolean` with `_def.typeName === "ZodBoolean"`) rather than a `ZodEffects`. Only `.preprocess()`, `.refine()`/`.superRefine()`, and `.transform()` are expected to wrap schemas in `ZodEffects`. Therefore, in reviewers’ logic like `getFlagControlType`, do not flag/unblock failures that require unwrapping `ZodEffects` when the input schema is a `z.coerce.*` schema.
Applied to files:
apps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.test.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/services/cancelDevSessionRuns.server.ts
📚 Learning: 2026-06-09T16:27:26.195Z
Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3878
File: apps/webapp/app/v3/services/computeTemplateCreation.server.ts:0-0
Timestamp: 2026-06-09T16:27:26.195Z
Learning: When working in triggerdotdev/trigger.dev code related to worker-group/region default resolution (e.g., defaultWorkerInstanceGroupId handling used by getGlobalDefaultWorkerGroup, getDefaultWorkerGroupForProject, and RegionsPresenter), do NOT add org-level featureFlags overrides in only one resolution site. That can cause template creation routing/decisions to diverge from actual run routing. If org-level override of the default region/worker group is required, it must be centralized in getGlobalDefaultWorkerGroup so every resolution path remains aligned.
Applied to files:
apps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.test.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/services/cancelDevSessionRuns.server.ts
📚 Learning: 2026-05-14T08:21:07.614Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3614
File: apps/webapp/app/v3/mollifier/mollifierGate.server.ts:48-52
Timestamp: 2026-05-14T08:21:07.614Z
Learning: When using Trigger.dev v3 feature flags in the webapp, prefer the existing per-org gating mechanism supported by `flag()` via the `overrides` argument. Pass `Organization.featureFlags` (from `environment.organization.featureFlags`) as the `overrides` value; overrides must take precedence over the global `featureFlag` row. Do not require schema changes or add an `orgId` field to `FlagsOptions` for per-org gating—use the overrides pattern consistently (e.g., in gate flows like `resolveOrgFlag` and any server code that threads `environment.organization.featureFlags` into the gate call).
Applied to files:
apps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/services/cancelDevSessionRuns.server.ts
📚 Learning: 2026-03-10T17:56:20.938Z
Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 3201
File: apps/webapp/app/v3/services/setSeatsAddOn.server.ts:25-29
Timestamp: 2026-03-10T17:56:20.938Z
Learning: Do not implement local userId-to-organizationId authorization checks inside org-scoped service classes (e.g., SetSeatsAddOnService, SetBranchesAddOnService) in the web app. Rely on route-layer authentication (requireUserId(request)) and org membership enforcement via the _app.orgs.$organizationSlug layout route. Any userId/organizationId that reaches these services from org-scoped routes has already been validated. Apply this pattern across all org-scoped services to avoid redundant auth checks and maintain consistency.
Applied to files:
apps/webapp/app/v3/services/cancelDevSessionRuns.server.ts
🔇 Additional comments (21)
apps/webapp/app/presenters/v3/ApiBatchResultsPresenter.server.ts (1)
2-2: LGTM!Also applies to: 46-53, 139-139
apps/webapp/test/apiBatchResultsPresenter.dedicatedSeam.test.ts (1)
1-337: LGTM!apps/webapp/test/apiBatchResultsPresenter.splitNPlus1.test.ts (1)
1-251: LGTM!internal-packages/run-engine/src/engine/tests/legacyRunNewTokenResumeFlow.test.ts (1)
1-302: LGTM!internal-packages/run-store/src/runOpsStore.ts (1)
379-427: LGTM!internal-packages/run-store/src/runOpsStore.groupedReads.test.ts (1)
1-388: LGTM!internal-packages/run-store/src/scheduleSeam.test.ts (1)
1-306: LGTM!apps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.ts (1)
73-81: LGTM!Also applies to: 255-300, 302-334
apps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.test.ts (1)
1-168: LGTM!apps/webapp/app/presenters/v3/ApiRetrieveRunPresenter.server.ts (1)
167-174: LGTM!apps/webapp/test/apiRetrieveRunPresenter.groupedLockedWorker.test.ts (1)
1-266: LGTM!apps/webapp/app/presenters/v3/WaitpointPresenter.server.ts (3)
14-17: LGTM!
105-114: LGTM!
132-139: LGTM!apps/webapp/test/waitpointPresenter.connectedRunsBounded.test.ts (1)
1-232: LGTM!apps/webapp/test/waitpointPresenter.splitConnectedRuns.test.ts (1)
1-207: LGTM!internal-packages/run-store/src/types.ts (1)
576-590: LGTM!internal-packages/run-store/src/PostgresRunStore.ts (2)
2359-2378: Batched hydration correctly issues one query per relation key across all rows instead of per row, matching the PR's stated goal.
267-299: 🎯 Functional CorrectnessCheck
includehandling for nestedtaskRunConfirm whether callers can request
blockingTaskRunswithinclude: { taskRun: ... }; if so, this hydrator also needs to readprojection?.include?.taskRuninstead of onlyprojection?.select?.taskRun.internal-packages/run-store/src/PostgresRunStore.findRunsByIds.test.ts (1)
123-170: LGTM!apps/webapp/app/v3/services/cancelDevSessionRuns.server.ts (1)
137-139: 🎯 Functional CorrectnessDon’t infer
idvsfriendlyIdfrom therun_prefix. Internal IDs can also start withrun_, so they’ll be sent to the wrong lookup path and skipped; read byidfirst, then fall back tofriendlyId, and add a regression for an internalidthat starts withrun_.
…n unrequested findRunsByIds forces `id` into the select so it can key the result map, but did not remove it afterwards, so returned rows carried an `id` the declared payload type did not include. Delete the injected id from each value when the caller's select did not request it; the map stays keyed by id.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several run-ops read paths issued one database query per item where a single batched query returns the same data: batch results hydrated each member run separately, the run retrieve endpoint resolved each locked worker version separately, the dedicated-schema relation hydrator ran per row, and a few services read runs in per-id loops. These now group into batched reads, so the same responses come back with far fewer queries.
Fix
Adds a grouped
findRunsByIdsto the run store (one residency-partitioned read for a set of run ids: query the new store for the whole set, then probe the legacy store only for the misses) and routes the presenters and services through it instead ofPromise.all(map(...))fan-outs. The dedicated-schema relation hydrator now batches across all rows per relation key. Separately, the waitpoint connected-runs read regains its display limit at the fetch, so it no longer loads every connected run into memory before slicing to five.Behavior is unchanged; the query counts drop. Covered by tests against real Postgres, including cross-store and mixed-residency cases.