fix(webapp): capture Prisma infra errors and obfuscate leaked messages#3960
fix(webapp): capture Prisma infra errors and obfuscate leaked messages#3960d-cs wants to merge 1 commit into
Conversation
…eir messages Prisma infrastructure failures (P1xxx-class: DB unreachable/timed out/connection dropped, engine init/panic) carry the database hostname in their message. Capture them centrally and ensure they never reach API clients verbatim. - db.server.ts: a $allOperations extension on the writer and replica clients logs infra errors with the model/operation, then rethrows the ORIGINAL error so the ~40 call sites that branch on error.code (and transaction retries) keep working. - transaction boundary: log infra errors that surface from $transaction() without a Prisma code (e.g. PrismaClientInitializationError), which the existing coded- error callback misses. - clientSafeErrorMessage(): swap an infra error's message for "Internal Server Error" at the API routes that returned it raw, leaving status codes, headers, and all non-infra messages unchanged. Applied to the batch trigger routes, schedule delete, and the worker continue action. Adds testcontainer + real-error-instance tests covering message obfuscation, pass-through of P2xxx codes, transaction-interior firing, and the boundary path.
|
WalkthroughThree new exported functions are added to 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install timed out. The project may have too many dependencies for the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 13d47f12-7814-4dbb-a997-c13a63502979
📒 Files selected for processing (9)
.server-changes/prisma-infrastructure-error-capture.mdapps/webapp/app/db.server.tsapps/webapp/app/routes/api.v1.schedules.$scheduleId.tsapps/webapp/app/routes/api.v1.tasks.$taskId.batch.tsapps/webapp/app/routes/api.v2.tasks.batch.tsapps/webapp/app/routes/api.v3.batches.tsapps/webapp/app/routes/engine.v1.worker-actions.runs.$runFriendlyId.snapshots.$snapshotFriendlyId.continue.tsapps/webapp/app/utils/prismaErrors.tsapps/webapp/test/prismaInfrastructureErrorCapture.test.ts
📜 Review details
🧰 Additional context used
📓 Path-based instructions (11)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects insteadImport from
@trigger.dev/sdkwhen writing Trigger.dev tasks. Never use@trigger.dev/sdk/v3or deprecatedclient.defineJob
Files:
apps/webapp/app/routes/api.v1.tasks.$taskId.batch.tsapps/webapp/app/routes/api.v2.tasks.batch.tsapps/webapp/app/routes/api.v3.batches.tsapps/webapp/app/routes/engine.v1.worker-actions.runs.$runFriendlyId.snapshots.$snapshotFriendlyId.continue.tsapps/webapp/app/routes/api.v1.schedules.$scheduleId.tsapps/webapp/app/utils/prismaErrors.tsapps/webapp/test/prismaInfrastructureErrorCapture.test.tsapps/webapp/app/db.server.ts
{packages/core,apps/webapp}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use zod for validation in packages/core and apps/webapp
Files:
apps/webapp/app/routes/api.v1.tasks.$taskId.batch.tsapps/webapp/app/routes/api.v2.tasks.batch.tsapps/webapp/app/routes/api.v3.batches.tsapps/webapp/app/routes/engine.v1.worker-actions.runs.$runFriendlyId.snapshots.$snapshotFriendlyId.continue.tsapps/webapp/app/routes/api.v1.schedules.$scheduleId.tsapps/webapp/app/utils/prismaErrors.tsapps/webapp/test/prismaInfrastructureErrorCapture.test.tsapps/webapp/app/db.server.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use function declarations instead of default exports
**/*.{ts,tsx,js,jsx}: Prefer static imports over dynamic imports. Only use dynamicimport()when circular dependencies cannot be resolved, code splitting is needed for performance, or the module must be loaded conditionally at runtime
Import subpaths only frompackages/core(@trigger.dev/core), never import from the root
Files:
apps/webapp/app/routes/api.v1.tasks.$taskId.batch.tsapps/webapp/app/routes/api.v2.tasks.batch.tsapps/webapp/app/routes/api.v3.batches.tsapps/webapp/app/routes/engine.v1.worker-actions.runs.$runFriendlyId.snapshots.$snapshotFriendlyId.continue.tsapps/webapp/app/routes/api.v1.schedules.$scheduleId.tsapps/webapp/app/utils/prismaErrors.tsapps/webapp/test/prismaInfrastructureErrorCapture.test.tsapps/webapp/app/db.server.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries
Files:
apps/webapp/app/routes/api.v1.tasks.$taskId.batch.tsapps/webapp/app/routes/api.v2.tasks.batch.tsapps/webapp/app/routes/api.v3.batches.tsapps/webapp/app/routes/engine.v1.worker-actions.runs.$runFriendlyId.snapshots.$snapshotFriendlyId.continue.tsapps/webapp/app/routes/api.v1.schedules.$scheduleId.tsapps/webapp/app/utils/prismaErrors.tsapps/webapp/test/prismaInfrastructureErrorCapture.test.tsapps/webapp/app/db.server.ts
apps/webapp/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
apps/webapp/**/*.{ts,tsx}: Access environment variables through theenvexport ofenv.server.tsinstead of directly accessingprocess.env
Use subpath exports from@trigger.dev/corepackage instead of importing from the root@trigger.dev/corepathUse named constants for sentinel/placeholder values (e.g.
const UNSET_VALUE = '__unset__') instead of raw string literals scattered across comparisons
Files:
apps/webapp/app/routes/api.v1.tasks.$taskId.batch.tsapps/webapp/app/routes/api.v2.tasks.batch.tsapps/webapp/app/routes/api.v3.batches.tsapps/webapp/app/routes/engine.v1.worker-actions.runs.$runFriendlyId.snapshots.$snapshotFriendlyId.continue.tsapps/webapp/app/routes/api.v1.schedules.$scheduleId.tsapps/webapp/app/utils/prismaErrors.tsapps/webapp/test/prismaInfrastructureErrorCapture.test.tsapps/webapp/app/db.server.ts
**/*.{js,ts,tsx,jsx,css,json,md}
📄 CodeRabbit inference engine (AGENTS.md)
Use Prettier for code formatting and run
pnpm run formatbefore committing
Files:
apps/webapp/app/routes/api.v1.tasks.$taskId.batch.tsapps/webapp/app/routes/api.v2.tasks.batch.tsapps/webapp/app/routes/api.v3.batches.tsapps/webapp/app/routes/engine.v1.worker-actions.runs.$runFriendlyId.snapshots.$snapshotFriendlyId.continue.tsapps/webapp/app/routes/api.v1.schedules.$scheduleId.tsapps/webapp/app/utils/prismaErrors.tsapps/webapp/test/prismaInfrastructureErrorCapture.test.tsapps/webapp/app/db.server.ts
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use vitest for all tests in the Trigger.dev repository
Files:
apps/webapp/test/prismaInfrastructureErrorCapture.test.ts
apps/webapp/**/*.test.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
Do not import
env.server.tsdirectly or indirectly into test files; instead pass environment-dependent values through options/parameters to make code testableFor testable code, never import
env.server.tsin test files. Pass configuration as options instead (e.g.,realtimeClient.server.tstakes config as constructor arg,realtimeClientGlobal.server.tscreates singleton with env config)
Files:
apps/webapp/test/prismaInfrastructureErrorCapture.test.ts
**/*.test.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.test.{ts,tsx}: Never mock anything in tests - use testcontainers instead
Test files should be placed next to source files (e.g.,MyService.ts->MyService.test.ts)
Files:
apps/webapp/test/prismaInfrastructureErrorCapture.test.ts
**/*.test.{js,ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.test.{js,ts,tsx}: Test files should live beside the files under test and use descriptivedescribeanditblocks
Use vitest for unit testing
Tests should avoid mocks or stubs and use helpers from@internal/testcontainerswhen Redis or Postgres are needed
Files:
apps/webapp/test/prismaInfrastructureErrorCapture.test.ts
apps/webapp/**/*.server.ts
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
apps/webapp/**/*.server.ts: Never userequest.signalfor detecting client disconnects. UsegetRequestAbortSignal()fromapp/services/httpAsyncStorage.server.tsinstead, which is wired directly to Expressres.on('close')and fires reliably
Access environment variables viaenvexport fromapp/env.server.ts. Never useprocess.envdirectly
Always usefindFirstinstead offindUniquein Prisma queries.findUniquehas an implicit DataLoader that batches concurrent calls and has active bugs even in Prisma 6.x (uppercase UUIDs returning null, composite key SQL correctness issues, 5-10x worse performance).findFirstis never batched and avoids this entire class of issues
Files:
apps/webapp/app/db.server.ts
🧠 Learnings (13)
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).
Applied to files:
apps/webapp/app/routes/api.v1.tasks.$taskId.batch.tsapps/webapp/app/routes/api.v2.tasks.batch.tsapps/webapp/app/routes/api.v3.batches.tsapps/webapp/app/routes/engine.v1.worker-actions.runs.$runFriendlyId.snapshots.$snapshotFriendlyId.continue.tsapps/webapp/app/routes/api.v1.schedules.$scheduleId.tsapps/webapp/app/utils/prismaErrors.tsapps/webapp/test/prismaInfrastructureErrorCapture.test.tsapps/webapp/app/db.server.ts
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.
Applied to files:
apps/webapp/app/routes/api.v1.tasks.$taskId.batch.tsapps/webapp/app/routes/api.v2.tasks.batch.tsapps/webapp/app/routes/api.v3.batches.tsapps/webapp/app/routes/engine.v1.worker-actions.runs.$runFriendlyId.snapshots.$snapshotFriendlyId.continue.tsapps/webapp/app/routes/api.v1.schedules.$scheduleId.tsapps/webapp/app/utils/prismaErrors.tsapps/webapp/test/prismaInfrastructureErrorCapture.test.tsapps/webapp/app/db.server.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.
Applied to files:
apps/webapp/app/routes/api.v1.tasks.$taskId.batch.tsapps/webapp/app/routes/api.v2.tasks.batch.tsapps/webapp/app/routes/api.v3.batches.tsapps/webapp/app/routes/engine.v1.worker-actions.runs.$runFriendlyId.snapshots.$snapshotFriendlyId.continue.tsapps/webapp/app/routes/api.v1.schedules.$scheduleId.tsapps/webapp/app/utils/prismaErrors.tsapps/webapp/test/prismaInfrastructureErrorCapture.test.tsapps/webapp/app/db.server.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.
Applied to files:
apps/webapp/app/routes/api.v1.tasks.$taskId.batch.tsapps/webapp/app/routes/api.v2.tasks.batch.tsapps/webapp/app/routes/api.v3.batches.tsapps/webapp/app/routes/engine.v1.worker-actions.runs.$runFriendlyId.snapshots.$snapshotFriendlyId.continue.tsapps/webapp/app/routes/api.v1.schedules.$scheduleId.tsapps/webapp/app/utils/prismaErrors.tsapps/webapp/test/prismaInfrastructureErrorCapture.test.tsapps/webapp/app/db.server.ts
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.
Applied to files:
apps/webapp/app/routes/api.v1.tasks.$taskId.batch.tsapps/webapp/app/routes/api.v2.tasks.batch.tsapps/webapp/app/routes/api.v3.batches.tsapps/webapp/app/routes/engine.v1.worker-actions.runs.$runFriendlyId.snapshots.$snapshotFriendlyId.continue.tsapps/webapp/app/routes/api.v1.schedules.$scheduleId.tsapps/webapp/app/utils/prismaErrors.tsapps/webapp/test/prismaInfrastructureErrorCapture.test.tsapps/webapp/app/db.server.ts
📚 Learning: 2026-05-12T21:04:05.815Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3542
File: apps/webapp/app/components/sessions/v1/SessionStatus.tsx:1-3
Timestamp: 2026-05-12T21:04:05.815Z
Learning: In this Remix + TypeScript codebase, do not flag a server/client boundary violation when a file imports only types from a module matching `*.server`.
Specifically, it’s safe to import types using `import type { Foo } from "*.server"` or `import { type Foo } from "*.server"` because TypeScript erases type-only imports at compile time and they emit no JavaScript, so they won’t cross the Remix server/client bundle boundary.
Only raise the boundary concern for value imports (e.g., `import { Foo }` without `type`, or `import Foo`), since those produce JavaScript output.
Applied to files:
apps/webapp/app/routes/api.v1.tasks.$taskId.batch.tsapps/webapp/app/routes/api.v2.tasks.batch.tsapps/webapp/app/routes/api.v3.batches.tsapps/webapp/app/routes/engine.v1.worker-actions.runs.$runFriendlyId.snapshots.$snapshotFriendlyId.continue.tsapps/webapp/app/routes/api.v1.schedules.$scheduleId.tsapps/webapp/app/utils/prismaErrors.tsapps/webapp/test/prismaInfrastructureErrorCapture.test.tsapps/webapp/app/db.server.ts
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.
Applied to files:
apps/webapp/app/routes/api.v1.tasks.$taskId.batch.tsapps/webapp/app/routes/api.v2.tasks.batch.tsapps/webapp/app/routes/api.v3.batches.tsapps/webapp/app/routes/engine.v1.worker-actions.runs.$runFriendlyId.snapshots.$snapshotFriendlyId.continue.tsapps/webapp/app/routes/api.v1.schedules.$scheduleId.tsapps/webapp/app/utils/prismaErrors.tsapps/webapp/test/prismaInfrastructureErrorCapture.test.tsapps/webapp/app/db.server.ts
📚 Learning: 2026-06-09T17:58:04.699Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.
Applied to files:
apps/webapp/app/routes/api.v1.tasks.$taskId.batch.tsapps/webapp/app/routes/api.v2.tasks.batch.tsapps/webapp/app/routes/api.v3.batches.tsapps/webapp/app/routes/engine.v1.worker-actions.runs.$runFriendlyId.snapshots.$snapshotFriendlyId.continue.tsapps/webapp/app/routes/api.v1.schedules.$scheduleId.tsapps/webapp/app/utils/prismaErrors.tsapps/webapp/test/prismaInfrastructureErrorCapture.test.tsapps/webapp/app/db.server.ts
📚 Learning: 2026-05-07T12:25:18.271Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3531
File: apps/webapp/test/sentryTraceContext.server.test.ts:9-47
Timestamp: 2026-05-07T12:25:18.271Z
Learning: In the triggerdotdev/trigger.dev webapp test suite, it is acceptable to leave `createInMemoryTracing()` calls that register a global `NodeTracerProvider` without `afterEach`/`afterAll` teardown. Do not flag this as a test-ordering risk when the code follows the established pattern used across webapp tests (e.g., replication service/benchmark/backfiller tests). This is considered safe because `trace.getActiveSpan()` when called outside a `context.with(...)` block reads `AsyncLocalStorage.getStore()` (undefined when no `run()` scope exists), so it falls back to `ROOT_CONTEXT` with no attached span—regardless of which provider is registered.
Applied to files:
apps/webapp/test/prismaInfrastructureErrorCapture.test.ts
📚 Learning: 2026-05-28T20:02:10.647Z
Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3772
File: apps/webapp/test/findOrCreateBackgroundWorker.test.ts:1-1
Timestamp: 2026-05-28T20:02:10.647Z
Learning: In the triggerdotdev/trigger.dev monorepo, for the `apps/webapp` package use the established convention of storing Vitest tests (unit, integration, and e2e) under `apps/webapp/test/` rather than colocating them next to source files. Do not flag files located in `apps/webapp/test/` as violating any rule that says to colocate tests with source.
Applied to files:
apps/webapp/test/prismaInfrastructureErrorCapture.test.ts
📚 Learning: 2026-05-18T14:40:02.173Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In the triggerdotdev/trigger.dev repo, the policy “Never mock anything — use testcontainers instead” should only be enforced for integration tests that interact with real external services (e.g., Redis, Postgres) via actual infrastructure. For unit tests that exercise pure in-memory logic (e.g., cache semantics) it is OK to stub collaborators such as `ApiClient` using Vitest (`vi.fn()`) to assert call counts or control behavior. Do not flag `vi.fn()`-based `ApiClient` stubs in unit tests as violations of the testcontainers policy.
Applied to files:
apps/webapp/test/prismaInfrastructureErrorCapture.test.ts
📚 Learning: 2026-05-05T09:38:02.512Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3523
File: apps/webapp/app/routes/api.v3.batches.ts:178-181
Timestamp: 2026-05-05T09:38:02.512Z
Learning: When reviewing code that catches `ServiceValidationError` in `*.server.ts` files, do not blindly forward `error.status` to HTTP responses, because SVEs may be thrown with non-default statuses (e.g., 400/500) and forwarding them can cause client-visible behavioral regressions (e.g., surfacing 500s to clients). Prefer a safe default response status of `error.status ?? 422`, but only after confirming via the reachable call graph that the caught `ServiceValidationError` instances are expected to carry those non-default statuses; otherwise, normalize to `422` to avoid unexpected client-visible 5xx behavior.
Applied to files:
apps/webapp/app/db.server.ts
📚 Learning: 2026-05-14T14:54:39.095Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3545
File: .server-changes/agent-view-sessions.md:10-10
Timestamp: 2026-05-14T14:54:39.095Z
Learning: In the `trigger.dev` repository, do not flag inconsistent dot vs slash notation in route/path strings inside `.server-changes/*.md` files. These markdown files are consumed verbatim into the changelog, so the mixed notation (e.g., `resources.orgs.../runs.$runParam/...`) is intentional and should be preserved as-is.
Applied to files:
.server-changes/prisma-infrastructure-error-capture.md
🔇 Additional comments (18)
apps/webapp/app/utils/prismaErrors.ts (4)
1-6: LGTM!
45-76: LGTM!
78-97: LGTM!
99-104: LGTM!apps/webapp/test/prismaInfrastructureErrorCapture.test.ts (3)
12-20: LGTM!Also applies to: 22-124
126-170: LGTM!
172-205: LGTM!apps/webapp/app/db.server.ts (5)
15-18: LGTM!
47-56: LGTM!
58-63: LGTM!
139-141: LGTM!
143-146: LGTM!apps/webapp/app/routes/api.v1.schedules.$scheduleId.ts (1)
6-6: LGTM!Also applies to: 57-60
apps/webapp/app/routes/api.v1.tasks.$taskId.batch.ts (1)
7-7: LGTM!Also applies to: 127-130
apps/webapp/app/routes/api.v2.tasks.batch.ts (1)
24-24: LGTM!Also applies to: 177-181
apps/webapp/app/routes/api.v3.batches.ts (1)
17-17: LGTM!Also applies to: 192-196
apps/webapp/app/routes/engine.v1.worker-actions.runs.$runFriendlyId.snapshots.$snapshotFriendlyId.continue.ts (1)
6-6: LGTM!Also applies to: 34-36
.server-changes/prisma-infrastructure-error-capture.md (1)
1-6: LGTM!
| import { describe, expect, it } from "vitest"; | ||
| import { postgresTest } from "@internal/testcontainers"; | ||
| import { Prisma, PrismaClient } from "@trigger.dev/database"; | ||
| import { | ||
| captureInfrastructureErrors, | ||
| clientSafeErrorMessage, | ||
| logTransactionInfrastructureError, | ||
| } from "~/utils/prismaErrors"; | ||
|
|
||
| vi.setConfig({ testTimeout: 60_000 }); |
There was a problem hiding this comment.
Missing vi import causes runtime failure.
vi.setConfig on line 10 references vi but it's not imported. The import on line 1 only brings in describe, expect, it.
Proposed fix
-import { describe, expect, it } from "vitest";
+import { describe, expect, it, vi } from "vitest";📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| import { describe, expect, it } from "vitest"; | |
| import { postgresTest } from "@internal/testcontainers"; | |
| import { Prisma, PrismaClient } from "@trigger.dev/database"; | |
| import { | |
| captureInfrastructureErrors, | |
| clientSafeErrorMessage, | |
| logTransactionInfrastructureError, | |
| } from "~/utils/prismaErrors"; | |
| vi.setConfig({ testTimeout: 60_000 }); | |
| import { describe, expect, it, vi } from "vitest"; | |
| import { postgresTest } from "`@internal/testcontainers`"; | |
| import { Prisma, PrismaClient } from "`@trigger.dev/database`"; | |
| import { | |
| captureInfrastructureErrors, | |
| clientSafeErrorMessage, | |
| logTransactionInfrastructureError, | |
| } from "~/utils/prismaErrors"; | |
| vi.setConfig({ testTimeout: 60_000 }); |
Summary
Prisma infrastructure failures (P1xxx-class: database unreachable, timed out, connection dropped, engine init/panic) carry the database hostname in their
.message. This captures them centrally for observability and ensures they never reach API clients verbatim.Design
A
$allOperationsclient extension on the writer and replica clients logs infrastructure errors with the originating model and operation, then rethrows the original error unchanged — call sites that branch onerror.code(unique-violation idempotency, not-found handling) and transaction retries keep working. Only infrastructure errors are logged; routine query/validation errors (P2xxx) are left alone.$allOperationscan't see the transaction boundary ($transactionis a client method, not an operation), so infrastructure errors surfacing from$transaction()without a Prisma code — e.g.PrismaClientInitializationError— are logged separately at the transaction wrapper, where the existing coded-error path would otherwise miss them.clientSafeErrorMessage()swaps an infrastructure error's message for"Internal Server Error"at the API routes that previously returnederror.messageraw. Status codes, headers, and every non-infrastructure message are unchanged.Test plan
$transactionkeep their code (retry logic intact)clientSafeErrorMessageobfuscates infra messages, preserves all otherspnpm run typecheck --filter webapp(12/12)Note
Overlaps with #3391 (Prisma 7 migration) on
apps/webapp/app/db.server.ts— coordinate rebasing.