Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: triggerdotdev/trigger.dev
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: triggerdotdev/trigger.dev
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: refs/pull/3866/head
Choose a head ref
  • 8 commits
  • 4 files changed
  • 3 contributors

Commits on Jun 8, 2026

  1. ci: allow forks to override published container image namespace 

    The publish workflows hardcoded ghcr.io/triggerdotdev/... as the image
destination, so a fork building on push-to-main would attempt to push to
(and attest) the upstream packages.

Derive the webapp image repo from github.repository (overridable via the
WEBAPP_IMAGE_REPO variable) and read the worker namespace from the
IMAGE_REGISTRY variable, both defaulting to the current values so upstream
behaviour is unchanged.
    @d-cs
    d-cs committed Jun 8, 2026
    Configuration menu
    Copy the full SHA
    8ea6dba View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into image-registry-overrides

    @d-cs
    d-cs authored Jun 8, 2026
    Configuration menu
    Copy the full SHA
    e8e50a4 View commit details
    Browse the repository at this point in the history

  3. ci: make worker image defaults fork-aware 

    Mirror the webapp's fork-friendly default in the worker publish workflows:
default the image namespace to ghcr.io/<owner> instead of the hardcoded
ghcr.io/triggerdotdev. Upstream resolves byte-identically (owner is
triggerdotdev), while forks now publish worker images to their own
namespace with no IMAGE_REGISTRY config, matching publish-webapp.yml.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
    @d-cs @claude
    d-cs and claude committed Jun 8, 2026
    Configuration menu
    Copy the full SHA
    7645e6d View commit details
    Browse the repository at this point in the history

  4. ci: resolve image registry once in parent workflow 

    Per review feedback, resolve the target container registry namespace a
single time in publish.yml (the orchestration workflow) and pass it down
to every publish job as an image_registry input, rather than each child
workflow independently computing the default.

This also unifies on one override variable: webapp and workers now both
key off IMAGE_REGISTRY (a namespace, e.g. ghcr.io/<owner>), with the
webapp image living at <registry>/<repo-name>. The separate
WEBAPP_IMAGE_REPO variable is dropped, removing the prior asymmetry
between a full-path override for the webapp and a namespace override for
workers.

Children keep the vars.IMAGE_REGISTRY || ghcr.io/<owner> fallback so the
worker workflows still resolve correctly on their direct push triggers.
Upstream defaults are byte-identical (owner is triggerdotdev).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
    @d-cs @claude
    d-cs and claude committed Jun 8, 2026
    Configuration menu
    Copy the full SHA
    2715217 View commit details
    Browse the repository at this point in the history

  5. ci: resolve registry inline instead of a dedicated job 

    Drop the resolve-registry job to avoid its runner startup cost. GitHub
doesn't expose the env context to a reusable workflow's with: block, so
inline the resolution expression directly in each publish job's
image_registry input instead. Behavior and upstream defaults unchanged.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
    @d-cs @claude
    d-cs and claude committed Jun 8, 2026
    Configuration menu
    Copy the full SHA
    beb5391 View commit details
    Browse the repository at this point in the history

  6. ci: DRY the registry expression with a YAML anchor 

    Define the registry-resolution expression once on publish-webapp via a
YAML anchor (&image_registry) and reuse it in the worker jobs via aliases
(*image_registry). GitHub Actions has supported YAML anchors since
2025-09-18, so this gives a single source of truth without the runner
startup cost of a dedicated resolve job. Resolved value is unchanged.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
    @d-cs @claude
    d-cs and claude committed Jun 8, 2026
    Configuration menu
    Copy the full SHA
    c564e9d View commit details
    Browse the repository at this point in the history

  7. ci: inline the registry expression in each publish job 

    Drop the YAML anchor in favor of writing the registry-resolution
expression explicitly in all three publish jobs. No job, no anchor, no
runner startup; the expression is identical across the three. Resolved
value unchanged.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
    @d-cs @claude
    d-cs and claude committed Jun 8, 2026
    Configuration menu
    Copy the full SHA
    f4f3434 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into image-registry-overrides

    @d-cs
    d-cs authored Jun 8, 2026
    Configuration menu
    Copy the full SHA
    d8b0738 View commit details
    Browse the repository at this point in the history
Loading