fix(webapp): narrow synthetic-span machinePreset against the canonical enum

d-cs · claude · d-cs · commit c8ab214efb53 · 2026-05-26T16:59:02.000+01:00
\`SyntheticRun.machinePreset\` is a plain string sourced from the
mollifier snapshot, but \`SpanRun.machinePreset\` is the typed
\`MachinePresetName\` enum (micro / small-1x / small-2x / medium-1x /
medium-2x / large-1x / large-2x). The direct assignment failed
\`tsc --noEmit\` and CI typecheck. Validate via \`MachinePresetName.safeParse\`
and collapse unknown values to \`undefined\` so a stale preset
returned by the buffer doesn't bleed into the UI as a typed-but-unknown
value.

Co-Authored-By: Claude Opus 4.7 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/apps/webapp/app/v3/mollifier/syntheticSpanRun.server.ts b/apps/webapp/app/v3/mollifier/syntheticSpanRun.server.ts
@@ -4,9 +4,20 @@ import {
   extractIdempotencyKeyScope,
   getUserProvidedIdempotencyKey,
 } from "@trigger.dev/core/v3/serverOnly";
+import { MachinePresetName } from "@trigger.dev/core/v3/schemas";
 import type { SpanRun } from "~/presenters/v3/SpanPresenter.server";
 import type { SyntheticRun } from "./readFallback.server";
 
+// `SyntheticRun.machinePreset` is sourced from the snapshot payload as
+// a plain string, but `SpanRun.machinePreset` is the narrowed enum.
+// Validate against the canonical enum so an unknown / stale preset
+// string collapses to undefined rather than fighting the type checker.
+function narrowMachinePreset(value: string | undefined): SpanRun["machinePreset"] {
+  if (value === undefined) return undefined;
+  const parsed = MachinePresetName.safeParse(value);
+  return parsed.success ? parsed.data : undefined;
+}
+
 // Synthesise a SpanRun-shaped object from a buffered run so the run-detail
 // page's right-side details panel renders identically to a PG-resident
 // run. The shape matches `SpanPresenter.getRun`'s return value exactly;
@@ -147,7 +158,7 @@ export async function buildSyntheticSpanRun(args: {
     traceId: run.traceId ?? "",
     spanId: run.spanId ?? "",
     isCached: false,
-    machinePreset: run.machinePreset,
+    machinePreset: narrowMachinePreset(run.machinePreset),
     taskEventStore: "taskEvent",
     externalTraceId: undefined,
   };
