fix(webapp): log realtime run-change pub/sub failures at error level

ericallam · ericallam · commit 94c5a03b326f · 2026-06-08T12:10:35.000+01:00
Surface publish, subscribe, and unsubscribe failures in the realtime
run-change pub/sub at error level with clearer static messages, instead
of debug.
diff --git a/apps/webapp/app/services/realtime/runChangeNotifier.server.ts b/apps/webapp/app/services/realtime/runChangeNotifier.server.ts
@@ -78,11 +78,17 @@ export class RunChangeNotifier {
       const result = publisher.publish(channel, payload);
       if (typeof (result as Promise<number>)?.catch === "function") {
         (result as Promise<number>).catch((error) => {
-          logger.debug("[runChangeNotifier] publish failed", { error, channel });
+          logger.error("[runChangeNotifier] Failed to publish run-changed notification", {
+            error,
+            channel,
+          });
         });
       }
     } catch (error) {
-      logger.debug("[runChangeNotifier] publish threw", { error, channel });
+      logger.error("[runChangeNotifier] Failed to publish run-changed notification", {
+        error,
+        channel,
+      });
     }
   }
 
@@ -125,7 +131,10 @@ export class RunChangeNotifier {
       listeners = new Set();
       this.#listeners.set(channel, listeners);
       subscriber.subscribe(channel).catch((error) => {
-        logger.debug("[runChangeNotifier] subscribe failed", { error, channel });
+        logger.error("[runChangeNotifier] Failed to subscribe to run-change channel", {
+          error,
+          channel,
+        });
       });
     }
     listeners.add(resolveChanged);
@@ -161,15 +170,21 @@ export class RunChangeNotifier {
               // now unsubscribed in Redis but has live waiters. Re-subscribe so they
               // still receive messages (the long-poll backstop covers the gap).
               subscriber.subscribe(channel).catch((error) => {
-                logger.debug("[runChangeNotifier] resubscribe failed", { error, channel });
+                logger.error("[runChangeNotifier] Failed to re-subscribe to run-change channel", {
+                  error,
+                  channel,
+                });
               });
             }
           })
           .catch((error) => {
             // UNSUBSCRIBE failed: the channel is likely still subscribed in Redis.
             // Keep the (empty) map entry so a future subscriber reuses it without a
             // duplicate SUBSCRIBE and #onMessage stays consistent with Redis state.
-            logger.debug("[runChangeNotifier] unsubscribe failed", { error, channel });
+            logger.error("[runChangeNotifier] Failed to unsubscribe from run-change channel", {
+              error,
+              channel,
+            });
           });
       }
     };
