Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: trigger/trigger
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: trigger/trigger
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fix-bugbot-issues
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 9 files changed
  • 1 contributor

Commits on Feb 23, 2026

  1. feat(benchmarks): add IPy vs netaddr benchmark for ACL workloads 

    Benchmarks realistic ACL-scale operations: object creation, containment,
sorting, string roundtrip, host iteration, prefix introspection, and
CIDR merging.

Results: netaddr 1.3.0 wins 5/7 tests. IPy only wins sorting (3.5×)
and prefix introspection (1.7×), both negligible at real ACL scale.

Ref: #376
    @jathanism
    jathanism committed Feb 23, 2026
    Configuration menu
    Copy the full SHA
    afd13a7 View commit details
    Browse the repository at this point in the history

  2. feat: migrate from IPy to netaddr for IP address handling 

    Replace IPy dependency with netaddr>=1.0.0,<2 across the entire codebase:

- Rewrite TIP class to subclass netaddr.IPNetwork instead of IPy.IP
- Update make_inverse_mask() to return netaddr.IPAddress
- Handle partial IPv4 addresses (e.g. '10/8') by expanding octets
- Prevent netaddr's iteration protocol from interfering with RangeList
- Update inverse_mask_table in ios.py to use string keys
- Replace IPy.IP() calls in global_settings.py, tools.py, netscreen.py, cmds.py
- Update prefixlen() method calls to prefixlen property access
- Update netmask() method calls to netmask property access

Closes #376
    @jathanism
    jathanism committed Feb 23, 2026
    Configuration menu
    Copy the full SHA
    cce2849 View commit details
    Browse the repository at this point in the history

  3. fix: replace remaining IPy-specific APIs with netaddr equivalents 

    - cmds.py: Replace make_net=True with manual network/prefix construction
  in IPsubnet, and .make_net(mask) with f-string in _make_cidrs
- acl/tools.py: Wrap addresses with TIP instead of plain netaddr.IPNetwork
  in _add_addr so strNormal() is available downstream
- acl/support.py: Force /32 and /128 prefix display in junos_str output
  since TIP.__str__ omits prefix for non-negated single hosts
    @jathanism
    jathanism committed Feb 23, 2026
    Configuration menu
    Copy the full SHA
    bd75ca1 View commit details
    Browse the repository at this point in the history

  4. fix: handle negated /32|/128 in junos_str and skip IPv4 expansion for… 

    … IPv6 CIDR
    @jathanism
    jathanism committed Feb 23, 2026
    Configuration menu
    Copy the full SHA
    fb122b3 View commit details
    Browse the repository at this point in the history
Loading