fix(langchain): _create_llm_span() overwrites SpanHolder causing potential context token loss #3956

Summary

In packages/opentelemetry-instrumentation-langchain/opentelemetry/instrumentation/langchain/callback_handler.py, the _create_llm_span() method overwrites an existing SpanHolder entry in the span registry without first detaching the context tokens stored in the previous holder. This is pre-existing behavior that predates PR #3807.

Problem

When _create_llm_span() is called for a run ID that already has a SpanHolder in the registry, it replaces that entry directly. The old holder's token (and now association_properties_token introduced in #3807) are lost without being detached, which could silently corrupt the OpenTelemetry context stack in certain execution flows.

Impact

• Orphaned context attachments similar to the ones fixed in 🐛 Bug Report: Orphaned context_api.attach() Calls Corrupt OpenTelemetry Context Stack #3526 / fix(langchain): detach orphaned context_api.attach() calls that corrupt OTel context #3807 may still occur via this code path.
• Downstream spans or logs may inherit incorrect or stale context.

Related

• Identified during review of PR fix(langchain): detach orphaned context_api.attach() calls that corrupt OTel context #3807 (fix(langchain): detach orphaned context_api.attach() calls that corrupt OTel context #3807), which fixed two other orphaned context_api.attach() calls.
• Reported by @coderabbitai, requested by @saivedant169 to be tracked separately.

Suggested Fix

Before overwriting a SpanHolder entry in _create_llm_span(), check if an existing holder is present and detach its context tokens (token and association_properties_token) before replacing it.