fix(load[spinner]): guard _emit_success against build failure

tony · tony · commit 73d34d8308d7 · 2026-03-08T14:16:03.000-05:00
why: The spinner-enabled path called _emit_success() unconditionally
after _dispatch_build(), showing a success checkmark even when the
build failed and the user killed the session. The --no-progress path
already had the correct guard.
what:
- Add `if result is not None:` guard before _emit_success() call
- Add test verifying success message is not emitted on build failure
diff --git a/src/tmuxp/cli/load.py b/src/tmuxp/cli/load.py
@@ -672,7 +672,8 @@ def _emit_success() -> None:
             on_error_hook=spinner.stop,
             pre_prompt_hook=spinner.stop,
         )
-        _emit_success()
+        if result is not None:
+            _emit_success()
         return result
 
 
diff --git a/tests/cli/test_progress.py b/tests/cli/test_progress.py
@@ -4,9 +4,11 @@
 
 import atexit
 import io
+import pathlib
 import time
 import typing as t
 
+import libtmux
 import pytest
 
 from tmuxp.cli._colors import ColorMode
@@ -1386,3 +1388,38 @@ def test_success_template_value() -> None:
     assert "{workspace_path}" in SUCCESS_TEMPLATE
     assert "{summary}" in SUCCESS_TEMPLATE
     assert "Loaded workspace:" in SUCCESS_TEMPLATE
+
+
+def test_no_success_message_on_build_error(
+    server: libtmux.Server,
+    tmp_path: pathlib.Path,
+    monkeypatch: pytest.MonkeyPatch,
+    capfd: pytest.CaptureFixture[str],
+) -> None:
+    """Success message is not emitted when _dispatch_build returns None."""
+    import yaml
+
+    from tmuxp.cli._colors import Colors
+    from tmuxp.cli.load import load_workspace
+
+    monkeypatch.delenv("TMUX", raising=False)
+
+    config = {"session_name": "test-fail", "windows": [{"window_name": "main"}]}
+    config_file = tmp_path / "fail.yaml"
+    config_file.write_text(yaml.dump(config))
+
+    monkeypatch.setattr(
+        "tmuxp.cli.load._dispatch_build",
+        lambda *args, **kwargs: None,
+    )
+
+    result = load_workspace(
+        str(config_file),
+        socket_name=server.socket_name,
+        cli_colors=Colors(ColorMode.NEVER),
+    )
+
+    assert result is None
+    captured = capfd.readouterr()
+    assert "\u2713" not in captured.err
+    assert "Loaded workspace:" not in captured.err

Original file line number	Diff line number	Diff line change
`@@ -672,7 +672,8 @@ def _emit_success() -> None:`
`672`	`672`	`on_error_hook=spinner.stop,`
`673`	`673`	`pre_prompt_hook=spinner.stop,`
`674`	`674`	`)`
`675`		`- _emit_success()`
	`675`	`+ if result is not None:`
	`676`	`+ _emit_success()`
`676`	`677`	`return result`
`677`	`678`
`678`	`679`