style(_progress[bar]): Remove brackets from progress bar rendering

tony · tony · commit 4a55334c0ea3 · 2026-03-08T08:18:37.000-05:00
why: Cleaner visual output — block characters provide natural boundaries.
what:
- Remove [ ] from render_bar() return value
- Remove [ ] from _color_bar() in _build_extra()
- Remove [ ] from marching bar in _spin()
- Update doctests and unit tests to match bracketless output
- Update BAR_WIDTH comment to drop bracket reference
diff --git a/src/tmuxp/cli/_progress.py b/src/tmuxp/cli/_progress.py
@@ -34,7 +34,7 @@
 # Spinner frames (braille pattern)
 SPINNER_FRAMES = "⠋⠙⠹⠸⠼⠴⠦⠧⠇⠏"
 
-BAR_WIDTH = 10  # inner fill cells; total visual width is width + 2 for brackets
+BAR_WIDTH = 10  # inner fill character count
 DEFAULT_OUTPUT_LINES = 3  # default spinner panel height (lines of script output)
 
 PROGRESS_PRESETS: dict[str, str] = {
@@ -64,26 +64,26 @@ def render_bar(done: int, total: int, width: int = BAR_WIDTH) -> str:
     Returns
     -------
     str
-        A bracket-enclosed bar like ``"[█████░░░░░]"``.
+        A bar like ``"█████░░░░░"``.
         Returns ``""`` when *total* <= 0 or *width* <= 0.
 
     Examples
     --------
     >>> render_bar(0, 10)
-    '[░░░░░░░░░░]'
+    '░░░░░░░░░░'
     >>> render_bar(5, 10)
-    '[█████░░░░░]'
+    '█████░░░░░'
     >>> render_bar(10, 10)
-    '[██████████]'
+    '██████████'
     >>> render_bar(0, 0)
     ''
     >>> render_bar(3, 10, width=5)
-    '[█░░░░]'
+    '█░░░░'
     """
     if total <= 0 or width <= 0:
         return ""
     filled = min(width, int(done / total * width))
-    return "[" + "█" * filled + "░" * (width - filled) + "]"
+    return "█" * filled + "░" * (width - filled)
 
 
 class _SafeFormatMap(dict):  # type: ignore[type-arg]
@@ -637,11 +637,9 @@ def _spin(self) -> None:
                     # Marching bar: sweep a 2-cell highlight across the bar
                     p = march_pos % max(1, BAR_WIDTH - 1)
                     march_bar = (
-                        "["
-                        + self.colors.muted("░" * p)
+                        self.colors.muted("░" * p)
                         + self.colors.warning("░░")
                         + self.colors.muted("░" * max(0, BAR_WIDTH - p - 2))
-                        + "]"
                     )
                     extra: dict[str, t.Any] = {
                         "bar": march_bar,
@@ -712,7 +710,7 @@ def _build_extra(self) -> dict[str, t.Any]:
         ... )
         >>> extra = spinner._build_extra()
         >>> extra["bar"]
-        '[░░░░░░░░░░]'
+        '░░░░░░░░░░'
         >>> extra["status_icon"]
         ''
         """
@@ -739,12 +737,7 @@ def _color_bar(plain: str) -> str:
                 return plain
             filled = plain.count("█")
             empty = plain.count("░")
-            return (
-                "["
-                + self.colors.success("█" * filled)
-                + self.colors.muted("░" * empty)
-                + "]"
-            )
+            return self.colors.success("█" * filled) + self.colors.muted("░" * empty)
 
         return {
             "bar": _color_bar(composite_bar),
diff --git a/tests/cli/test_progress.py b/tests/cli/test_progress.py
@@ -487,17 +487,17 @@ def test_spinner_progress_format_none_uses_inline() -> None:
 
 def test_render_bar_empty() -> None:
     """render_bar with done=0 produces an all-empty bar."""
-    assert render_bar(0, 10) == "[░░░░░░░░░░]"
+    assert render_bar(0, 10) == "░░░░░░░░░░"
 
 
 def test_render_bar_half() -> None:
     """render_bar with done=5, total=10 fills exactly half."""
-    assert render_bar(5, 10) == "[█████░░░░░]"
+    assert render_bar(5, 10) == "█████░░░░░"
 
 
 def test_render_bar_full() -> None:
     """render_bar with done=total fills the entire bar."""
-    assert render_bar(10, 10) == "[██████████]"
+    assert render_bar(10, 10) == "██████████"
 
 
 def test_render_bar_zero_total() -> None:
@@ -507,13 +507,13 @@ def test_render_bar_zero_total() -> None:
 
 def test_render_bar_custom_width() -> None:
     """render_bar with custom width produces bar of that inner width."""
-    assert render_bar(3, 10, width=5) == "[█░░░░]"
+    assert render_bar(3, 10, width=5) == "█░░░░"
 
 
 def test_render_bar_width_constant() -> None:
     """BAR_WIDTH is the default inner width used by render_bar."""
     bar = render_bar(0, 10)
-    assert len(bar) == BAR_WIDTH + 2  # inner + 2 brackets
+    assert len(bar) == BAR_WIDTH
 
 
 # BuildTree new token tests
@@ -679,7 +679,6 @@ def test_spinner_bar_token_no_color() -> None:
     )
     spinner.on_build_event({"event": "pane_creating", "pane_num": 1, "pane_total": 2})
 
-    assert "[" in spinner.message
     assert "░" in spinner.message or "█" in spinner.message
 
 
@@ -706,7 +705,7 @@ def test_spinner_pane_bar_preset() -> None:
     spinner.on_build_event({"event": "window_done"})
 
     assert "2/4" in spinner.message
-    assert "[" in spinner.message
+    assert "░" in spinner.message or "█" in spinner.message
 
 
 def test_spinner_before_script_event_via_events() -> None:
